From: Wei Chen <Wei.Chen@arm.com>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.chen@arm.com, steve.capper@arm.com,
Kaly.Xin@arm.com, julien.grall@arm.com, nd@arm.com
Subject: [PATCH v4 18/19] xen/arm: Prevent slipping hypervisor SError to guest
Date: Wed, 5 Apr 2017 17:09:20 +0800 [thread overview]
Message-ID: <1491383361-22886-19-git-send-email-Wei.Chen@arm.com> (raw)
In-Reply-To: <1491383361-22886-1-git-send-email-Wei.Chen@arm.com>
If there is a pending SError while we're returning from trap. If the
SError handle option is "DIVERSE", we have to prevent slipping this
hypervisor SError to guest. So we have to use the dsb/isb to guarantee
that the pending hypervisor SError would be caught in hypervisor before
return to guest.
In previous patch, we will set SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT to
cpu_hwcaps when option is NOT "DIVERSE". This means we can use the
alternative to skip synchronizing SErrors for other SErrors handle options.
Because we have umasked the Abort/SError bit in previous patch. We have
to disable the Abort/SError before returning to guest as we have done
for IRQ.
Signed-off-by: Wei Chen <Wei.Chen@arm.com>
---
xen/arch/arm/traps.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index c092e66..c8163db 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -2989,6 +2989,19 @@ asmlinkage void leave_hypervisor_tail(void)
local_irq_disable();
if (!softirq_pending(smp_processor_id())) {
gic_inject();
+
+ /*
+ * If the SErrors handle option is "DIVERSE", we have to prevent
+ * slipping the hypervisor SError to guest. In this option, before
+ * returning from trap, we have to synchronize SErrors to guarantee
+ * that the pending SError would be caught in hypervisor.
+ *
+ * If option is NOT "DIVERSE", SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT
+ * will be set to cpu_hwcaps. This means we can use the alternative
+ * to skip synchronizing SErrors for other SErrors handle options.
+ */
+ SYNCHRONIZE_SERROR(SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT);
+
return;
}
local_irq_enable();
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-05 9:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 9:09 [PATCH v4 00/19] Provide a command line option to choose how to handle SErrors Wei Chen
2017-04-05 9:09 ` [PATCH v4 01/19] xen/arm: Save ESR_EL2 to avoid using mismatched value in syndrome check Wei Chen
2017-04-05 9:09 ` [PATCH v4 02/19] xen/arm: Introduce a helper to get default HCR_EL2 flags Wei Chen
2017-04-05 9:09 ` [PATCH v4 03/19] xen/arm: Set and restore HCR_EL2 register for each vCPU separately Wei Chen
2017-04-05 9:09 ` [PATCH v4 04/19] xen/arm: Avoid setting/clearing HCR_RW at every context switch Wei Chen
2017-04-05 9:09 ` [PATCH v4 05/19] xen/arm: Save HCR_EL2 when a guest took the SError Wei Chen
2017-04-05 9:09 ` [PATCH v4 06/19] xen/arm: Introduce a virtual abort injection helper Wei Chen
2017-04-05 9:09 ` [PATCH v4 07/19] xen/arm: Introduce a command line parameter for SErrors/Aborts Wei Chen
2017-04-05 9:09 ` [PATCH v4 08/19] xen/arm: Introduce a initcall to update cpu_hwcaps by serror_op Wei Chen
2017-04-05 9:09 ` [PATCH v4 09/19] xen/arm64: Use alternative to skip the check of pending serrors Wei Chen
2017-04-05 9:09 ` [PATCH v4 10/19] xen/arm32: " Wei Chen
2017-04-05 9:09 ` [PATCH v4 11/19] xen/arm: Move macro VABORT_GEN_BY_GUEST to common header Wei Chen
2017-04-05 9:09 ` [PATCH v4 12/19] xen/arm: Introduce new helpers to handle guest/hyp SErrors Wei Chen
2017-04-05 9:09 ` [PATCH v4 13/19] xen/arm: Replace do_trap_guest_serror with new helpers Wei Chen
2017-04-05 9:09 ` [PATCH v4 14/19] xen/arm: Unmask the Abort/SError bit in the exception entries Wei Chen
2017-04-05 9:09 ` [PATCH v4 15/19] xen/arm: Introduce a helper to check local abort is enabled Wei Chen
2017-04-05 11:14 ` Julien Grall
2017-04-05 9:09 ` [PATCH v4 16/19] xen/arm: Introduce a macro to synchronize SError Wei Chen
2017-04-05 11:15 ` Julien Grall
2017-04-05 9:09 ` [PATCH v4 17/19] xen/arm: Isolate the SError between the context switch of 2 vCPUs Wei Chen
2017-04-05 9:09 ` Wei Chen [this message]
2017-04-05 11:17 ` [PATCH v4 18/19] xen/arm: Prevent slipping hypervisor SError to guest Julien Grall
2017-04-05 9:09 ` [PATCH v4 19/19] xen/arm: Handle guest external abort as guest SError Wei Chen
2017-04-05 19:18 ` [PATCH v4 00/19] Provide a command line option to choose how to handle SErrors Stefano Stabellini
2017-04-06 4:52 ` Wei Chen
2017-04-07 15:37 ` Julien Grall
2017-04-07 23:20 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491383361-22886-19-git-send-email-Wei.Chen@arm.com \
--to=wei.chen@arm.com \
--cc=Kaly.Xin@arm.com \
--cc=julien.grall@arm.com \
--cc=nd@arm.com \
--cc=sstabellini@kernel.org \
--cc=steve.capper@arm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).