From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 03/11] truncation: Support globs, and multiple patterns
Date: Tue, 18 Apr 2017 16:56:44 +0100 [thread overview]
Message-ID: <1492531012-14315-4-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1492531012-14315-1-git-send-email-ian.jackson@eu.citrix.com>
Rename the variable to truncate_testids. It contains glob patterns as
for Tcl `string match', space-separated.
Adjust the two places which set it: cs-bisection-step (which needs to
quote any special characters) and mg-repro-setup (which does not
really process the value, but ought to be able to cope with
space-separated lists.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
cs-bisection-step | 4 +++-
mg-repro-setup | 2 +-
sg-run-job | 15 +++++++++------
3 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/cs-bisection-step b/cs-bisection-step
index 162e068..76f5010 100755
--- a/cs-bisection-step
+++ b/cs-bisection-step
@@ -1312,7 +1312,9 @@ END
$hostspec =~ m/=/;
$addvar->execute($popflight, $job, $`, $'); # '
}
- $addvar->execute($popflight, $job, 'truncate_testid', $testid);
+ my $testid_glob = $testid;
+ $testid_glob =~ s/[]\\*?[]/\\$&/g;
+ $addvar->execute($popflight, $job, 'truncate_testids', $testid_glob);
});
}
diff --git a/mg-repro-setup b/mg-repro-setup
index 5a64b1a..bb429b4 100755
--- a/mg-repro-setup
+++ b/mg-repro-setup
@@ -186,7 +186,7 @@ fi
progress "setting up flight ..."
-adjrunvar truncate_testid $testid
+adjrunvar truncate_testids "$testid"
./cs-adjust-flight $flight \
copy-jobs $example_flight $job \
diff --git a/sg-run-job b/sg-run-job
index 104c880..cc24b73 100755
--- a/sg-run-job
+++ b/sg-run-job
@@ -41,14 +41,14 @@ proc per-host-finish {} {
proc run-job {job} {
global jobinfo builds flight ok truncate need_xen_hosts anyfailed
- global nested_layers_hosts truncate_at
+ global nested_layers_hosts truncate_globs
set ok 1
set truncate 0
set anyfailed 0
jobdb::prepare $job
- set truncate_at [jobdb::read-runvar $flight $job truncate_testid]
+ set truncate_globs [jobdb::read-runvar $flight $job truncate_testids]
set nh [need-hosts/$jobinfo(recipe)]
if {![string compare $nh BUILD]} {
@@ -244,7 +244,7 @@ proc spawn-ts {iffail testid args} {
}
proc reap-ts {reap} {
- global truncate truncate_at
+ global truncate truncate_globs
switch -exact [lindex $reap 0] {
imm { return [lindex $reap 1] }
@@ -266,9 +266,12 @@ proc reap-ts {reap} {
eval jobdb::step-set-status [lrange $details 0 2] $result
jobdb::logputs stdout "finished $detstr $result $emsg"
- if {![string compare $testid $truncate_at]} {
- jobdb::logputs stdout "truncating job now as instructed"
- set truncate 1
+ foreach truncate_glob [split $truncate_globs] {
+ if {[string match $truncate_glob $testid]} {
+ jobdb::logputs stdout "truncating job now as instructed"
+ set truncate 1
+ break
+ }
}
return [expr {![string compare $result pass]}]
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-18 15:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 15:56 [OSSTEST PATCH 00/11] Coverity fix and mg-repro-setup improvements Ian Jackson
2017-04-18 15:56 ` [OSSTEST PATCH 01/11] TestSupport: Provide stashfilecontents Ian Jackson
2017-04-18 15:56 ` [OSSTEST PATCH 02/11] ts-coverity-upload: Pass HttpsProxyMITMCert to curl Ian Jackson
2017-04-18 15:56 ` Ian Jackson [this message]
2017-04-18 15:56 ` [OSSTEST PATCH 04/11] sg-run-job: Break out testid_matches_globs Ian Jackson
2017-04-18 15:56 ` [OSSTEST PATCH 05/11] sg-run-job: Start step a bit later Ian Jackson
2017-04-18 15:56 ` [OSSTEST PATCH 06/11] sg-run-job: Honour skip_testids runvar Ian Jackson
2017-04-18 15:56 ` [OSSTEST PATCH 07/11] mg-repro-setup: skip log capture (by default) Ian Jackson
2017-04-18 15:56 ` [OSSTEST PATCH 08/11] mg-allocate: Document --info-base in head comment Ian Jackson
2017-04-18 15:56 ` [OSSTEST PATCH 09/11] mg-allocate: Support --progress-fd Ian Jackson
2017-04-18 15:56 ` [OSSTEST PATCH 10/11] mg-execute-flight: " Ian Jackson
2017-04-18 15:56 ` [OSSTEST PATCH 11/11] mg-repro-setup: Use --progress-fd Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492531012-14315-4-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).