* [OSSTEST PATCH] ts-openstack-deploy: Set http proxy
@ 2017-04-25 15:14 Ian Jackson
2017-04-25 17:57 ` Anthony PERARD
0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2017-04-25 15:14 UTC (permalink / raw)
To: xen-devel; +Cc: Anthony PERARD, Ian Jackson
This allows ./stack.sh to access the global internet.
CC: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
ts-openstack-deploy | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ts-openstack-deploy b/ts-openstack-deploy
index a1c974f..d4c041d 100755
--- a/ts-openstack-deploy
+++ b/ts-openstack-deploy
@@ -137,8 +137,11 @@ END
}
sub deploy() {
+ my $httpproxy = http_proxy_envsettings($ho);
+
target_cmd($ho, <<END, 1800);
set -e
+ $httpproxy
cd $builddir/devstack
./stack.sh
END
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [OSSTEST PATCH] ts-openstack-deploy: Set http proxy
2017-04-25 15:14 [OSSTEST PATCH] ts-openstack-deploy: Set http proxy Ian Jackson
@ 2017-04-25 17:57 ` Anthony PERARD
2017-04-25 18:19 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Anthony PERARD @ 2017-04-25 17:57 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Tue, Apr 25, 2017 at 04:14:32PM +0100, Ian Jackson wrote:
> This allows ./stack.sh to access the global internet.
>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
> ts-openstack-deploy | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ts-openstack-deploy b/ts-openstack-deploy
> index a1c974f..d4c041d 100755
> --- a/ts-openstack-deploy
> +++ b/ts-openstack-deploy
> @@ -137,8 +137,11 @@ END
> }
>
> sub deploy() {
> + my $httpproxy = http_proxy_envsettings($ho);
> +
> target_cmd($ho, <<END, 1800);
> set -e
> + $httpproxy
> cd $builddir/devstack
> ./stack.sh
> END
The patch itself looks good, but I think http_proxy_envsettings only set
http_proxy, twice, but does not set https_proxy.
For this patch:
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [OSSTEST PATCH] ts-openstack-deploy: Set http proxy
2017-04-25 17:57 ` Anthony PERARD
@ 2017-04-25 18:19 ` Ian Jackson
0 siblings, 0 replies; 3+ messages in thread
From: Ian Jackson @ 2017-04-25 18:19 UTC (permalink / raw)
To: Anthony PERARD; +Cc: xen-devel
Anthony PERARD writes ("Re: [OSSTEST PATCH] ts-openstack-deploy: Set http proxy"):
> The patch itself looks good, but I think http_proxy_envsettings only set
> http_proxy, twice, but does not set https_proxy.
Indeed. See my patch "proxy config: Actually set https_proxy too"
posted today, when I tripped over this too.
> For this patch:
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks. I'm running more tests with the https mitm cert env setting
you suggested.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-25 18:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-25 15:14 [OSSTEST PATCH] ts-openstack-deploy: Set http proxy Ian Jackson
2017-04-25 17:57 ` Anthony PERARD
2017-04-25 18:19 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).