xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [OSSTEST PATCH] Debian grub2 config: set TERMINAL to 'serial console'
Date: Tue, 2 May 2017 17:17:37 +0100	[thread overview]
Message-ID: <1493741857-24905-1-git-send-email-ian.jackson@eu.citrix.com> (raw)

It is usually useful to enable the BIOS option `continue redirection
after boot', where provided.  This shows messages from pxelinux etc.

But this can breaks serial access for grub, depending on the host.
(This is true on the noblings, for example.)

Using TERMINAL='serial console' provides the output to both (and would
take input from whichever presses a key).

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 Osstest/Debian.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index acc4618..4155056 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -600,6 +600,9 @@ END
         target_editfile_root($ho, '/etc/default/grub', sub {
             my %k;
             while (<::EI>) {
+		# some bioses block the serial still so we try vga too
+		s/^(GRUB_TERMINAL=)(['"]?)serial\2\s*$/$1'serial console'\n/;
+
                 if (m/^\s*([A-Z_]+)\s*\=\s*(.*?)\s*$/) {
                     my ($k,$v) = ($1,$2);
                     $v =~ s/^\s*([\'\"])(.*)\1\s*$/$2/;
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

                 reply	other threads:[~2017-05-02 16:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493741857-24905-1-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).