From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [resend PATCH] xen: common: rbtree: ported updates from linux tree Date: Thu, 18 May 2017 16:47:17 +0200 Message-ID: <1495118837.7393.43.camel@citrix.com> References: <20170511172133.28179-1-kpraveen.lkml@gmail.com> <591DC4CD020000780015AF6B@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8806576210602970721==" Return-path: In-Reply-To: <591DC4CD020000780015AF6B@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Praveen Kumar Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org --===============8806576210602970721== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-oefkyRZp7qFZWCNllDgM" --=-oefkyRZp7qFZWCNllDgM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-05-18 at 07:59 -0600, Jan Beulich wrote: > > > > On 11.05.17 at 19:21, wrote: > >=20 > > The patch contains the updated version of rbtree implementation > > from linux > > kernel tree containing the fixes so far handled. >=20 > I suppose this isn't just fixes, but also enhancements. Furthermore > I'd appreciate if you recorded the Linux version this was taken from, > so that anyone wanting to do another upgrade would know what > the baseline is. In any event, as long as this is just a general > overhaul and upgrade, I'd like to either see individual bugs pointed > out which get fixed _and_ which affect us, or I'd expect this to be > part of a series which actually requires some of the new > functionality. > I fully agree. And in fact, this is actually quite a big patch, and does (although it touches only a few files) a bunch of different things (new functionalities, improved comments, etc). So, Jan, would it be ok for this thing that Praveen is trying to do, to be a series, with one patch for each original Linux commit? I think, if it were me doing this, that would be how I'd do it. Otherwise it is e.g. hard to understand why ... >=20 > > Signed-off-by: Praveen Kumar > > --- > > =C2=A0xen/common/rbtree.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 748 > > +++++++++++++++++++++++++------------ > > =C2=A0xen/include/xen/compiler.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0|=C2=A0=C2=A060 +++ > > =C2=A0xen/include/xen/rbtree.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0| 120 ++++-- > > =C2=A0xen/include/xen/rbtree_augmented.h | 283 ++++++++++++++ >=20 > ... namely this last (new) header (and what it provides) is needed > at all. >=20 Indeed. And in fact, for our original purpose (which is to use rb-trees=20 instead of linked lists for Credit2's runqueues), I don't think we actually need the augmented variant. Praveen, as we agreed on IRC, it is ok to send this patch (which I think should have been a patch series) first, but stating why you are actually doing this (i.e., a few words on the original purpose I'm mentioning above), is really useful, to set the context, and should be there (in the cover letter or a follow up email). Also, do Cc me please (in addition to what get_maintainers.pl says). :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-oefkyRZp7qFZWCNllDgM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZHbP1AAoJEBZCeImluHPut00QALlttFqUOpvfJUxYo5F61arS S8Oz0m+0+di/S6kZPI0d/tA2WqHvbdSJBRn2GWIQVFepirL/iCMtmHVroTGT3bL7 msLKrWrmw8Ab0KQsfIZzOTlTJwl0NcAKyzu5BGKiy8GH9D1DcPA3HJjZyq7JW+ZF qH0zLacD1lAy1bEZd77NGOQqlR8BAhO4fdLb3a2FoK3yeuOuS1i/AsC+uyexCz20 D3faceBdiEqlVeGFyFzciidlksQJO34gw01aRE5sfGRTwYFMAti0ezxIIp0iTwjw +5a6xWca0ataFAIN9wJTnnZN8U7Lw5VDBBYe/VdmFR+geUrUJk+8KM6Pp1SIfLuR XpUXNUnhtfnpGGUoO3Kr8NSVYTtd8AqaqhKER6LIbQdWPV/hLTIOktrwM7H6lHh+ s7LhifaU42UDC4rf6Yl4z58QuwHLJbfMwWWsJkT5NIMTQl2xRFFb/XzuOvqQwE++ 5lU2A3Bd7Cb+lv4dU7zWEpfFSMWhamC8/r2uSDuakjVhF0ZM8Oc0LD1RaEb5bTL0 yOt6wRe5gYXvSA1sHJVf3uy7PbWRaMztfLhQ45v2bR9r2t5rl1Yt70o+jlJBdzI4 znrNOfw6eHy1SZr++dnEptcjTY0UPMnjqtT8WPzjlb0Su7jnu/M7fN1JO9+sXgCr tmAVY9++6lsgF+Qsfzjq =waiQ -----END PGP SIGNATURE----- --=-oefkyRZp7qFZWCNllDgM-- --===============8806576210602970721== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============8806576210602970721==--