From: Dario Faggioli <dario.faggioli@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Luwei Kang <luwei.kang@intel.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2] x86/vpmu: add cpu hot unplug notifier for vpmu
Date: Thu, 18 May 2017 16:56:51 +0200 [thread overview]
Message-ID: <1495119411.7393.45.camel@citrix.com> (raw)
In-Reply-To: <591DBAD1020000780015AF32@prv-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1407 bytes --]
On Thu, 2017-05-18 at 07:16 -0600, Jan Beulich wrote:
> > > > On 18.05.17 at 15:03, <boris.ostrovsky@oracle.com> wrote:
> >
> > As I said last time, I'd rename cpu_callback() to something less
> > generic, like vpmu_cpu_callback() (or vpmu_cpuhp_callback()).
>
> The vpmu_ prefix is clearly pointless for a static function.
>
And "just" using cpu_callback is what we do in a lot of (although, not
everywhere :-( ) other places:
xen/common/timer.c: .notifier_call = cpu_callback,
xen/common/kexec.c: .notifier_call = cpu_callback
xen/common/cpupool.c: .notifier_call = cpu_callback
xen/arch/x86/hvm/hvm.c: .notifier_call = cpu_callback
xen/arch/x86/cpu/mcheck/mce_intel.c: .notifier_call = cpu_callback
xen/common/stop_machine.c: .notifier_call = cpu_callback
xen/common/tmem_xen.c: .notifier_call = cpu_callback
xen/common/tasklet.c: .notifier_call = cpu_callback,
xen/common/trace.c: .notifier_call = cpu_callback
xen/drivers/passthrough/io.c: .notifier_call = cpu_callback,
xen/drivers/cpufreq/cpufreq.c: .notifier_call = cpu_callback
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-05-18 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 15:57 [PATCH v2] x86/vpmu: add cpu hot unplug notifier for vpmu Luwei Kang
2017-05-18 9:07 ` Jan Beulich
2017-05-18 11:51 ` Kang, Luwei
2017-05-18 13:06 ` Jan Beulich
2017-05-18 13:19 ` Jan Beulich
2017-05-18 14:23 ` Kang, Luwei
2017-05-19 6:21 ` Jan Beulich
2017-05-22 2:08 ` Kang, Luwei
2017-05-18 13:03 ` Boris Ostrovsky
2017-05-18 13:16 ` Jan Beulich
2017-05-18 14:56 ` Dario Faggioli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495119411.7393.45.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=luwei.kang@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).