From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2] x86/vpmu: add cpu hot unplug notifier for vpmu Date: Thu, 18 May 2017 16:56:51 +0200 Message-ID: <1495119411.7393.45.camel@citrix.com> References: <1495036625-24071-1-git-send-email-luwei.kang@intel.com> <591D8063020000780015AC63@prv-mh.provo.novell.com> <07f2ab1f-e850-f8ac-99e3-8503cbe464fb@oracle.com> <591DBAD1020000780015AF32@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4033621085571150247==" Return-path: In-Reply-To: <591DBAD1020000780015AF32@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Luwei Kang , Boris Ostrovsky Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============4033621085571150247== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-o2afgSX0dFlnldsowSa2" --=-o2afgSX0dFlnldsowSa2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-05-18 at 07:16 -0600, Jan Beulich wrote: > > > > On 18.05.17 at 15:03, wrote: > >=20 > > As I said last time, I'd rename cpu_callback() to something less > > generic, like vpmu_cpu_callback() (or vpmu_cpuhp_callback()). >=20 > The vpmu_ prefix is clearly pointless for a static function. >=20 And "just" using cpu_callback is what we do in a lot of (although, not everywhere :-( ) other places: xen/common/timer.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cpu_callback, xen/common/kexec.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cpu_callback xen/common/cpupool.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cpu_callbac= k xen/arch/x86/hvm/hvm.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cpu_callb= ack xen/arch/x86/cpu/mcheck/mce_intel.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call = =3D cpu_callback xen/common/stop_machine.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cpu_ca= llback xen/common/tmem_xen.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cpu_callba= ck xen/common/tasklet.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cpu_callbac= k, xen/common/trace.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cpu_callback xen/drivers/passthrough/io.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cpu= _callback, xen/drivers/cpufreq/cpufreq.c:=C2=A0=C2=A0=C2=A0=C2=A0.notifier_call =3D cp= u_callback Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-o2afgSX0dFlnldsowSa2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZHbY0AAoJEBZCeImluHPuplAQALYskoxw12vWATSTI74fPTki Nca2FfeBWemVcnTduH1twnQbvxx3xJ+WzZypE1HVcc17JmEBD3+owUAhUCVDDdKS vPl+t6ZonHeDY7PMSSstM2mIfgjEciaOHL0Bhhb22F4gunxI4NzCMq/c+4pq3NdX DrG5GeAf6icqwDcNYR5WlFC5qiZiXOlhhdHjNugCsMGU7uCTLQV+ITy6dKkUZQYY 3T1ck8wEZGug1mXZKEIA0C7N+1nBNLGpauU40i2bXEfON1L6vGOrHhm0gul8Dg/C mHAlWPQ7PntXvDpN9f5i3LXRz1YcyZjfs1b+QpeCLUMwf4gr2ADgfLZWUfXK0Of+ 7ktK5fBJoHtFRN6aGCy4OyB3UjD4G2HWOef8KcWaHEseSHV7EWa28ipgVNdJpqug 15zi39VmL2WdbDcNELHybfuaGg3iqJh8uRdwvvbDipZ6m2yr1qAzxQhD0sUq3fqP PtETT2KojN+PvsKDnqvoIefq07AULsL6FJhBfkXv9N8U0TAqsUrvYtS5CqzFeTjk C6B01O0Sh6Aeu2jnWzu2GQ2NJsfmF6IlVOOehlKoV7RhaAmL+nK0XHHxhV7eXjOH HX3kqiwck7y889H6wJ98ZWrgQgMiMhbgXu7T1ghU5wmDYA+kDnXT3ormxc0EDpHW 793SvD5o339PirIzpvsi =ybZO -----END PGP SIGNATURE----- --=-o2afgSX0dFlnldsowSa2-- --===============4033621085571150247== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============4033621085571150247==--