From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [Xen-devel[PATCH Resend v2] xen: common: rbtree: ported updates from linux tree Date: Thu, 1 Jun 2017 00:34:46 +0200 Message-ID: <1496270086.6267.3.camel@citrix.com> References: <20170531212056.10583-1-kpraveen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8263668975635184658==" Return-path: In-Reply-To: <20170531212056.10583-1-kpraveen.lkml@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============8263668975635184658== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-1aBOI6r8Ual5UssgwJ80" --=-1aBOI6r8Ual5UssgwJ80 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > Hi All, >=20 Hi, > The patch imports the changes and updates of the rbtree > implementaiton > from Linux tree.=20 > Thanks Praveen for doing this. This series is much better than the previous single and giant patch. :-) > But since, the only current implementation is with tmem.c, > which am not much aware off much and therefore, was unable to test > the changes > thoroughly. Having said that, I do have plans of adding futher code > changes > which will be using rb-tree more in credit2 scheduler and that will > help in > further testing the same. > That is fine, I think, for now. We'll test this properly when you'll have the "usage in Credit2" part. >=20 > I have not imported augmented and rcu rbtree functionality to the xen > tree, > as there was no specific requirement for current planned > implementation. >=20 That's something I agree with, and you did the right thing saying it here in the cover letter. Another thing I would like to know, though, is whether there are other commits that, for one reason or another, you either decided to skip, or could not port, or if this series bring us basically on par with Linux's rb-trees. > From Praveen Kumar # This line is ignored. > From: Praveen Kumar > Subject:=C2=A0 > In-Reply-To:=C2=A0 >=20 This are a bit strange lines. No big deal, just saying. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-1aBOI6r8Ual5UssgwJ80 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZL0UHAAoJEBZCeImluHPuf2YP/jr1Ik7QNRiipdMNOYxIlq8F +ueTCi7kqLxhIJjXOrsDp54w3PRxZV8jlX9iWNwTbG0vzOwrmV3M5rR6A8e+2Xp2 Pvr8wUxp+H3cOt9MQwXaYUXBMIyowTrocMF9TQnWuS8x4iKexoC38tYr9JPraPpU 9Tf0Xjn7pAybbp78m9EUyxYem33OtxXtjOLExN6gj2+a0cerqYEhNCf2tX63Ahn7 kXxu+0FWnKFV160pobxEg/ILQz0xOn/TGKRnlf8dgGip7ThwkKm9La/PQk5Wih0V coFYhGKM79xm0MTJyPC26sXTX2geup75Ic7tW0rATV+aegUB/zwc7rdWcQNum7cP Dl2Ie+9+87psAL08HiieyMcseCgQjvM+2DjMYgf7nsipTcnWT92TIL3tfFCFeQlY abRFLqyR83pqYiQNomou6EpPX78JneDlHb1t8zq+9m7MY/XMpppRDiw8cn62Fb5R brnoTYixTS5/gVg8NPI8ihvKkNsfnUGi7zUGyTtLrZ0UP6vM+vT3gmISI85un7UR ua75DMaWioPADjvo9ert3EJfqkprGS1ETI6/OJ58RMSJ/qHmYGQ9Z0D3/SciB1ZX SYyJGOAtiprOLct+j/UQ+kmdqYMQfOIXoqn+6QGlTscW2Jxh6kwraALsmADzyVJU wURALP0/kr18IdNPYDsd =tQvt -----END PGP SIGNATURE----- --=-1aBOI6r8Ual5UssgwJ80-- --===============8263668975635184658== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============8263668975635184658==--