From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [Resend][PATCH 01/17] rb_tree: reorganize code in rb_erase() for additional changes Date: Thu, 1 Jun 2017 10:01:25 +0200 Message-ID: <1496304085.18953.1.camel@citrix.com> References: <20170531212056.10583-1-kpraveen.lkml@gmail.com> <20170531212056.10583-2-kpraveen.lkml@gmail.com> <1496270454.6267.5.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4388387497430953365==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , Praveen Kumar , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============4388387497430953365== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-N5ubxTUYNtQAdlsrDws4" --=-N5ubxTUYNtQAdlsrDws4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-05-31 at 23:56 +0100, Andrew Cooper wrote: > As an example, see >=20 > http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommitdiff;h=3Db01c2fb5834= ae > a0328db55c310caa34173021d3d >=20 Nice, I especially like how the changelog looks, i.e.: - original Linux patch description description - Linux's Signed-off-by, Reviewed-by, Acked-by, etc. - ref to Linux commit id - a line with "Ported to Xen." - author of the port's Signed-off-by - (Reviewed-by, Acked-by, etc. coming from xen-devel) Praveen, I suggest using the same pattern (if you also like it, of course :-D). Using patch 1 as an example, that would mean the following: Subject: [PATCH 01/17] rb_tree: reorganize code in rb_erase() for=C2=A0ad= ditional changes First, move some code around in order to make the next change more=C2=A0 obvious. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Peter Zijlstra Signed-off-by: Wolfram Strepp Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds [Linux commit 16c047add3ceaf0ab882e3e094d1ec904d02312d] Ported to Xen. Signed-off-by: Praveen Kumar --- > The way I prepare series like this for email is to use `git format- > patch > staging --cover-letter` to render the entire series as patch files in > the local directory,=C2=A0=C2=A0edit each patch to put suitable Cc: lines > beside > the From: header, then `git send-email --dry-run *.patch > --suppress-cc=3Dall` to check what it will actually send.=C2=A0=C2=A0The = Cc's in > the > header section are included, but no automatic Cc's are generated from > content in the body. >=20 Cool to know, thanks. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-N5ubxTUYNtQAdlsrDws4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZL8nVAAoJEBZCeImluHPuKvcP/14zmGvXJXcLxVIjYplz7b5/ 49Mu6AV9Jpnf+MrIc78ySlvl1vxG3JWB2MkKkjT3lh55m3MDazd11w35wTOpxQZ8 YFSUQV6PwYZm4VhMlMKufMXxBfugZgfDrEEXF9iVKFkVZva1Pxj8c47DXkTwxKXD 3nbt8ZkNGxi2ACKl7ClUuLQ1ZWsz6cdRzJS4G28U4quG+5xLWW0z34gQQalACMZx NDnIQV+A8SngKrqP2wCtpooLdMoqmiQT/s0mTafCckmuUlyjpSUk/AsOwdiVnMcq Qx82TuGB6L/ztBVx64n66jawIU8mKfc78UAwfhMcHvZhnAALDGo9BpDnpngdWCdm W74uZSI929toYcxCThGXMwTkDdP+TrhzVJnkWmciO46m50J2ga14hYNtEd+Tpje8 sOBOTvjrtaaRgGs/wZDBd7vYkr9HlFtu40nTisqI6ofgC3ASi9h9HY9ZOWMNtyFc NaH1hisXETmie2urdeqXaNS3dW2sBcvL2rAW/F3gQ+xOWKX4d9QJebf55rO+Ipt5 OKUBDss3RendML6m0FtM66igdFm8noNsd4LMagsoq7akgnvg5M/O59zjX6LgLwed v1g1eVx0Kx0AiDUPVYYhK5mV6TpvBvTw5uPJ8tDc29ZlG8I6isPHz47dgJAyzOGP dntZnaXclOIggKka0z3u =XqPl -----END PGP SIGNATURE----- --=-N5ubxTUYNtQAdlsrDws4-- --===============4388387497430953365== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============4388387497430953365==--