xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xen.org
Cc: jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>,
	boris.ostrovsky@oracle.com, sstabellini@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 06/18] xen/pvcalls: handle commands from the frontend
Date: Fri,  2 Jun 2017 12:31:43 -0700	[thread overview]
Message-ID: <1496431915-20774-6-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1496431915-20774-1-git-send-email-sstabellini@kernel.org>

When the other end notifies us that there are commands to be read
(pvcalls_back_event), wake up the backend thread to parse the command.

The command ring works like most other Xen rings, so use the usual
ring macros to read and write to it. The functions implementing the
commands are empty stubs for now.

Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
---
 drivers/xen/pvcalls-back.c | 119 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 119 insertions(+)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index bfea25f..6057533 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -51,12 +51,131 @@ struct pvcalls_fedata {
 	struct work_struct register_work;
 };
 
+static int pvcalls_back_socket(struct xenbus_device *dev,
+		struct xen_pvcalls_request *req)
+{
+	return 0;
+}
+
+static int pvcalls_back_connect(struct xenbus_device *dev,
+				struct xen_pvcalls_request *req)
+{
+	return 0;
+}
+
+static int pvcalls_back_release(struct xenbus_device *dev,
+				struct xen_pvcalls_request *req)
+{
+	return 0;
+}
+
+static int pvcalls_back_bind(struct xenbus_device *dev,
+			     struct xen_pvcalls_request *req)
+{
+	return 0;
+}
+
+static int pvcalls_back_listen(struct xenbus_device *dev,
+			       struct xen_pvcalls_request *req)
+{
+	return 0;
+}
+
+static int pvcalls_back_accept(struct xenbus_device *dev,
+			       struct xen_pvcalls_request *req)
+{
+	return 0;
+}
+
+static int pvcalls_back_poll(struct xenbus_device *dev,
+			     struct xen_pvcalls_request *req)
+{
+	return 0;
+}
+
+static int pvcalls_back_handle_cmd(struct xenbus_device *dev,
+				   struct xen_pvcalls_request *req)
+{
+	int ret = 0;
+
+	switch (req->cmd) {
+	case PVCALLS_SOCKET:
+		ret = pvcalls_back_socket(dev, req);
+		break;
+	case PVCALLS_CONNECT:
+		ret = pvcalls_back_connect(dev, req);
+		break;
+	case PVCALLS_RELEASE:
+		ret = pvcalls_back_release(dev, req);
+		break;
+	case PVCALLS_BIND:
+		ret = pvcalls_back_bind(dev, req);
+		break;
+	case PVCALLS_LISTEN:
+		ret = pvcalls_back_listen(dev, req);
+		break;
+	case PVCALLS_ACCEPT:
+		ret = pvcalls_back_accept(dev, req);
+		break;
+	case PVCALLS_POLL:
+		ret = pvcalls_back_poll(dev, req);
+		break;
+	default:
+		ret = -ENOTSUPP;
+		break;
+	}
+	return ret;
+}
+
 static void pvcalls_back_work(struct work_struct *work)
 {
+	struct pvcalls_fedata *priv = container_of(work,
+		struct pvcalls_fedata, register_work);
+	int notify, notify_all = 0, more = 1;
+	struct xen_pvcalls_request req;
+	struct xenbus_device *dev = priv->dev;
+
+	while (more) {
+		while (RING_HAS_UNCONSUMED_REQUESTS(&priv->ring)) {
+			RING_COPY_REQUEST(&priv->ring,
+					  priv->ring.req_cons++,
+					  &req);
+
+			if (!pvcalls_back_handle_cmd(dev, &req)) {
+				RING_PUSH_RESPONSES_AND_CHECK_NOTIFY(
+					&priv->ring, notify);
+				notify_all += notify;
+			}
+		}
+
+		if (notify_all)
+			notify_remote_via_irq(priv->irq);
+
+		RING_FINAL_CHECK_FOR_REQUESTS(&priv->ring, more);
+	}
 }
 
 static irqreturn_t pvcalls_back_event(int irq, void *dev_id)
 {
+	struct xenbus_device *dev = dev_id;
+	struct pvcalls_fedata *priv = NULL;
+
+	if (dev == NULL)
+		return IRQ_HANDLED;
+
+	priv = dev_get_drvdata(&dev->dev);
+	if (priv == NULL)
+		return IRQ_HANDLED;
+
+	/*
+	 * TODO: a small theoretical race exists if we try to queue work
+	 * after pvcalls_back_work checked for final requests and before
+	 * it returns. The queuing will fail, and pvcalls_back_work
+	 * won't do the work because it is about to return. In that
+	 * case, we lose the notification.
+	 */
+	queue_work(priv->wq, &priv->register_work);
+
 	return IRQ_HANDLED;
 }
 
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-06-02 19:31 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 19:31 [PATCH v3 00/18] introduce the Xen PV Calls backend Stefano Stabellini
2017-06-02 19:31 ` [PATCH v3 01/18] xen: introduce the pvcalls interface header Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 02/18] xen/pvcalls: introduce the pvcalls xenbus backend Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 03/18] xen/pvcalls: initialize the module and register the " Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 04/18] xen/pvcalls: xenbus state handling Stefano Stabellini
2017-06-12 21:19     ` Boris Ostrovsky
2017-06-02 19:31   ` [PATCH v3 05/18] xen/pvcalls: connect to a frontend Stefano Stabellini
2017-06-12 21:27     ` Boris Ostrovsky
2017-06-02 19:31   ` Stefano Stabellini [this message]
2017-06-12 22:03     ` [PATCH v3 06/18] xen/pvcalls: handle commands from the frontend Boris Ostrovsky
     [not found]     ` <3f119021-c866-5138-fe4b-263befa377b2@oracle.com>
2017-06-14 21:03       ` Stefano Stabellini
     [not found]       ` <alpine.DEB.2.10.1706141342420.12156@sstabellini-ThinkPad-X260>
2017-06-15 14:33         ` Boris Ostrovsky
     [not found]         ` <7013dd41-d7a7-3ccd-0c44-d774e0065f43@oracle.com>
2017-06-15 18:54           ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 07/18] xen/pvcalls: implement socket command Stefano Stabellini
2017-06-13  6:06     ` Juergen Gross
     [not found]     ` <e034149e-3dfa-8b61-b149-4405afd14c32@suse.com>
2017-06-14  0:46       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 08/18] xen/pvcalls: implement connect command Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 09/18] xen/pvcalls: implement bind command Stefano Stabellini
2017-06-13  7:00     ` Juergen Gross
     [not found]     ` <ff975b10-8f1a-20db-881a-4d18bdfa9350@suse.com>
2017-06-14  0:46       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 10/18] xen/pvcalls: implement listen command Stefano Stabellini
2017-06-13  7:00     ` Juergen Gross
2017-06-02 19:31   ` [PATCH v3 11/18] xen/pvcalls: implement accept command Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 12/18] xen/pvcalls: implement poll command Stefano Stabellini
2017-06-13  7:28     ` Juergen Gross
     [not found]     ` <a11c57d3-f8a7-efed-9216-e20b395eb335@suse.com>
2017-06-14  0:47       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 13/18] xen/pvcalls: implement release command Stefano Stabellini
2017-06-13  7:39     ` Juergen Gross
     [not found]     ` <18386730-7ef1-ed3e-0a0d-845bd8cbb8ef@suse.com>
2017-06-14  0:47       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 14/18] xen/pvcalls: disconnect and module_exit Stefano Stabellini
2017-06-13  7:49     ` Juergen Gross
     [not found]     ` <62e395b4-b4af-34d8-134a-222984ebe779@suse.com>
2017-06-14  0:54       ` Stefano Stabellini
     [not found]       ` <alpine.DEB.2.10.1706131748440.12156@sstabellini-ThinkPad-X260>
2017-06-14 13:51         ` Boris Ostrovsky
     [not found]         ` <e5834233-88f6-661e-6725-0710a6a7e320@oracle.com>
2017-06-14 19:15           ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 15/18] xen/pvcalls: implement the ioworker functions Stefano Stabellini
2017-06-13  7:51     ` Juergen Gross
     [not found]     ` <51e3bbad-d5f2-a3b9-b038-4535cd58ea2a@suse.com>
2017-06-14  0:56       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 16/18] xen/pvcalls: implement read Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 17/18] xen/pvcalls: implement write Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 18/18] xen: introduce a Kconfig option to enable the pvcalls backend Stefano Stabellini
2017-06-12 21:17   ` [PATCH v3 01/18] xen: introduce the pvcalls interface header Boris Ostrovsky
     [not found]   ` <1496431915-20774-18-git-send-email-sstabellini@kernel.org>
2017-06-13  6:02     ` [PATCH v3 18/18] xen: introduce a Kconfig option to enable the pvcalls backend Juergen Gross
     [not found]     ` <24ff4023-cd32-2e8c-eaec-6926e505b698@suse.com>
2017-06-13 23:46       ` Stefano Stabellini
     [not found]   ` <1496431915-20774-8-git-send-email-sstabellini@kernel.org>
2017-06-13  6:17     ` [PATCH v3 08/18] xen/pvcalls: implement connect command Juergen Gross
     [not found]     ` <3c2a8a1e-e50e-8d69-69ec-1a8bde626876@suse.com>
2017-06-14  0:46       ` Stefano Stabellini
     [not found]   ` <1496431915-20774-11-git-send-email-sstabellini@kernel.org>
2017-06-13  7:24     ` [PATCH v3 11/18] xen/pvcalls: implement accept command Juergen Gross
     [not found]     ` <c7d715eb-358a-47a7-95be-c87afc25c8b1@suse.com>
2017-06-14  0:47       ` Stefano Stabellini
     [not found]       ` <alpine.DEB.2.10.1706131721470.12156@sstabellini-ThinkPad-X260>
2017-06-14  6:32         ` Juergen Gross
     [not found]         ` <6749c353-5e63-77fb-2541-44703072e9ac@suse.com>
2017-06-14 19:27           ` Stefano Stabellini
     [not found]           ` <alpine.DEB.2.10.1706141219350.12156@sstabellini-ThinkPad-X260>
2017-06-15  6:58             ` Juergen Gross
     [not found]             ` <111dc29b-aabb-4558-4546-734e52ddc9be@suse.com>
2017-06-15 17:54               ` Stefano Stabellini
     [not found]   ` <1496431915-20774-16-git-send-email-sstabellini@kernel.org>
2017-06-13  7:56     ` [PATCH v3 16/18] xen/pvcalls: implement read Juergen Gross
     [not found]     ` <99664d75-df13-2e25-a992-0b8050776d49@suse.com>
2017-06-14  0:57       ` Stefano Stabellini
     [not found]   ` <1496431915-20774-17-git-send-email-sstabellini@kernel.org>
2017-06-13  7:59     ` [PATCH v3 17/18] xen/pvcalls: implement write Juergen Gross
     [not found]     ` <ab52e642-c276-aad7-5667-3b9c1be63b2f@suse.com>
2017-06-14  1:00       ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496431915-20774-6-git-send-email-sstabellini@kernel.org \
    --to=sstabellini@kernel.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano@aporeto.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).