xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: [PATCH 3/4] x86/apic: Drop CONFIG_LOCAL_APIC
Date: Tue, 6 Jun 2017 17:01:10 +0100	[thread overview]
Message-ID: <1496764871-27711-2-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1496764871-27711-1-git-send-email-andrew.cooper3@citrix.com>

It is unconditionally selected, and all 64bit processors have local APICs.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
---
 xen/arch/x86/acpi/boot.c     | 10 ----------
 xen/include/asm-x86/apic.h   |  8 --------
 xen/include/asm-x86/config.h |  1 -
 3 files changed, 19 deletions(-)

diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c
index 33c9133..6e6d338 100644
--- a/xen/arch/x86/acpi/boot.c
+++ b/xen/arch/x86/acpi/boot.c
@@ -54,15 +54,12 @@ bool_t __initdata acpi_ioapic;
 static bool_t acpi_skip_timer_override __initdata;
 boolean_param("acpi_skip_timer_override", acpi_skip_timer_override);
 
-#ifdef CONFIG_X86_LOCAL_APIC
 static u64 acpi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE;
-#endif
 
 /* --------------------------------------------------------------------------
                               Boot-time Configuration
    -------------------------------------------------------------------------- */
 
-#ifdef CONFIG_X86_LOCAL_APIC
 static int __init acpi_parse_madt(struct acpi_table_header *table)
 {
 	struct acpi_table_madt *madt;
@@ -207,8 +204,6 @@ acpi_parse_lapic_nmi(struct acpi_subtable_header * header, const unsigned long e
 	return 0;
 }
 
-#endif				/*CONFIG_X86_LOCAL_APIC */
-
 #if defined(CONFIG_X86_IO_APIC) /*&& defined(CONFIG_ACPI_INTERPRETER)*/
 
 static int __init
@@ -510,7 +505,6 @@ static int __init acpi_parse_fadt(struct acpi_table_header *table)
 	return 0;
 }
 
-#ifdef	CONFIG_X86_LOCAL_APIC
 /*
  * Parse LAPIC entries in MADT
  * returns 0 on success, < 0 on error
@@ -566,7 +560,6 @@ static int __init acpi_parse_madt_lapic_entries(void)
 	}
 	return 0;
 }
-#endif /* CONFIG_X86_LOCAL_APIC */
 
 #ifdef CONFIG_X86_IO_APIC
 /*
@@ -644,7 +637,6 @@ static inline int acpi_parse_madt_ioapic_entries(void)
 
 static void __init acpi_process_madt(void)
 {
-#ifdef CONFIG_X86_LOCAL_APIC
 	int error;
 
 	if (!acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
@@ -677,8 +669,6 @@ static void __init acpi_process_madt(void)
 			disable_acpi();
 		}
 	}
-#endif
-	return;
 }
 
 /*
diff --git a/xen/include/asm-x86/apic.h b/xen/include/asm-x86/apic.h
index d840ee5..342db73 100644
--- a/xen/include/asm-x86/apic.h
+++ b/xen/include/asm-x86/apic.h
@@ -49,8 +49,6 @@ const struct genapic *apic_x2apic_probe(void);
 	} while (0)
 
 
-#ifdef CONFIG_X86_LOCAL_APIC
-
 /*
  * Basic functions accessing APICs.
  */
@@ -205,10 +203,4 @@ extern unsigned int nmi_watchdog;
 #define NMI_IO_APIC	1
 #define NMI_LOCAL_APIC	2
 
-#else /* !CONFIG_X86_LOCAL_APIC */
-static inline int lapic_suspend(void) {return 0;}
-static inline int lapic_resume(void) {return 0;}
-
-#endif /* !CONFIG_X86_LOCAL_APIC */
-
 #endif /* __ASM_APIC_H */
diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h
index ba486d5..7587112 100644
--- a/xen/include/asm-x86/config.h
+++ b/xen/include/asm-x86/config.h
@@ -18,7 +18,6 @@
 #define BITS_PER_XEN_ULONG BITS_PER_LONG
 
 #define CONFIG_PAGING_ASSISTANCE 1
-#define CONFIG_X86_LOCAL_APIC 1
 #define CONFIG_X86_IO_APIC 1
 #define CONFIG_X86_PM_TIMER 1
 #define CONFIG_HPET_TIMER 1
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-06-06 16:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 14:51 [PATCH] x86/apic: Drop workarounds for Pentium/82489DX erratum Andrew Cooper
2017-06-06 15:18 ` Jan Beulich
2017-06-06 16:01 ` [PATCH 2/4] x86/apic: Drop the unused struct local_apic Andrew Cooper
2017-06-06 16:01   ` Andrew Cooper [this message]
2017-06-07 12:47     ` [PATCH 3/4] x86/apic: Drop CONFIG_LOCAL_APIC Jan Beulich
2017-06-06 16:01   ` [PATCH 4/4] x86/apic: Drop CONFIG_IO_APIC Andrew Cooper
2017-06-07 12:49     ` Jan Beulich
2017-06-07 12:51       ` Andrew Cooper
2017-06-07 12:44   ` [PATCH 2/4] x86/apic: Drop the unused struct local_apic Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496764871-27711-2-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).