From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>,
Armando Vega <armando@greenhost.nl>,
George Dunlap <george.dunlap@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com
Subject: Re: [PATCH 0/1] xl.cfg man page cleanup and fixes
Date: Thu, 8 Jun 2017 14:46:17 +0200 [thread overview]
Message-ID: <1496925977.9462.31.camel@citrix.com> (raw)
In-Reply-To: <22838.33728.137471.334545@mariner.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1381 bytes --]
On Tue, 2017-06-06 at 11:28 +0100, Ian Jackson wrote:
> Armando Vega writes ("[PATCH 0/1] xl.cfg man page cleanup and
> fixes"):
> > I've had to rework the NUMA node examples as it had what I would
> > call a
> > counting error and in the end presented incorrect information. It
> > would be
> > great if someone could check me up on that once more. Also, there
> > is no clear
> > explanation whether a person can use ^nodes:1 and nodes:^1
> > interchangably and
> > to be honest I wasn't sure myself. Haven't had the time to give
> > this proper
> > testing.
>
> I think this means we should get a review from Dario or George (added
> to the To: field).
>
Thanks Ian for the ping.
I've just verified that:
root@Zhaman:~# xl vcpu-pin 0 all all,node:^1
Invalid pcpu range: ^1.
root@Zhaman:~# xl vcpu-pin 0 all all,^node:1
root@Zhaman:~#
So, no, they're not interchangeable. "^node:1" is allowed, while
"node:^1" is not (and hence, it is wrong in the docs, and that's my
fault... sorry for that!).
Are you up for fixing that when respinning this patch?
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-08 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 20:47 [PATCH 0/1] xl.cfg man page cleanup and fixes Armando Vega
2017-06-05 20:47 ` [PATCH 1/1] " Armando Vega
2017-06-08 12:56 ` Dario Faggioli
2017-06-08 13:18 ` Armando Vega
2017-06-06 10:28 ` [PATCH 0/1] " Ian Jackson
2017-06-06 16:03 ` Armando Vega
2017-06-08 12:46 ` Dario Faggioli [this message]
2017-06-08 18:39 ` [PATCH v2 " Armando Vega
2017-06-08 18:39 ` [PATCH v2 1/1] " Armando Vega
2017-06-13 13:17 ` Ian Jackson
2017-06-13 13:59 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496925977.9462.31.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=armando@greenhost.nl \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).