From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1/1] xl.cfg man page cleanup and fixes Date: Thu, 8 Jun 2017 14:56:07 +0200 Message-ID: <1496926567.9462.33.camel@citrix.com> References: <20170605204755.22850-1-armando@greenhost.nl> <20170605204755.22850-2-armando@greenhost.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5447004395106335124==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIwz3-0007zm-9j for xen-devel@lists.xenproject.org; Thu, 08 Jun 2017 12:56:17 +0000 In-Reply-To: <20170605204755.22850-2-armando@greenhost.nl> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Armando Vega , xen-devel@lists.xenproject.org Cc: Armando Vega , wei.liu2@citrix.com, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============5447004395106335124== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-3RoDNTMIUwNS5Lu1y8s9" --=-3RoDNTMIUwNS5Lu1y8s9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2017-06-05 at 22:47 +0200, Armando Vega wrote: > From: Armando Vega > =C2=A0=3Ditem "all" > =C2=A0 > -To allow all the vcpus of the guest to run on all the cpus on the > host. > +To allow all the vCPUs of the guest to run on all the CPUs on the > host. > =C2=A0 > =C2=A0=3Ditem "0-3,5,^1" > =C2=A0 > -To allow all the vcpus of the guest to run on cpus 0,2,3,5. > Combining > -this with "all" is possible, meaning "all,^7" results in all the > vcpus > -of the guest running on all the cpus on the host except cpu 7. > +To allow all the vCPUs of the guest to run on CPUs 0,2,3,5. It is > possible to > +combine this with "all", meaning "all,^7" results in all the vCPUs > +of the guest being allowed to run on all the CPUs of the host except > CPU 7. > =C2=A0 > =C2=A0=3Ditem "nodes:0-3,node:^2" > As said in the other email, this is wrong. Should be "nodes:0-3,^node:2". =C2=A0 > -To allow all the vcpus of the guest to run on the cpus from NUMA > nodes > -0,1,3 of the host. So, if cpus 0-3 belongs to node 0, cpus 4-7 > belongs > -to node 1 and cpus 8-11 to node 3, the above would mean all the > vcpus > -of the guest will run on cpus 0-3,8-11. > +To allow all the vCPUs of the guest to run on the CPUs from NUMA > nodes > +0,1,3 of the host. So, if CPUs 0-3 belong to node 0, CPUs 4-7 belong > +to node 1, CPUs 8-11 to node 2 and CPUs 12-15 to node 3, the above > would mean > +all the vCPUs of the guest would be allowed to run on CPUs 0-7,12- > 15. > =C2=A0 Yes, here again, the original was wrong, and you're proposed fix is correct. > =C2=A0Combining this notation with the one above is possible. For > instance, > -"1,node:2,^6", means all the vcpus of the guest will run on cpu 1 > and > -on all the cpus of NUMA node 2, but not on cpu 6. Following the same > -example as above, that would be cpus 1,4,5,7. > +"1,node:1,^6", means all the vCPUs of the guest will run on CPU 1 > and > +on all the CPUs of NUMA node 1, but not on CPU 6. Following the same > +example as above, that would be CPUs 1,4,5,7. > =C2=A0 Correct again (your version). And I've also had a look to some other hunks, in particular, the ones about scheduling parameters, and they all look fine to me. So, with the above "nodes:^x" fixed, this patch can have my: Reviewed-by: Dario Faggioli Thanks for all the good work! Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-3RoDNTMIUwNS5Lu1y8s9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZOUlnAAoJEBZCeImluHPuSzwP/1c5xoVT1nlmYFcmwCo8XqjH HcGx46acIrL4YXEwEayubOZFnlkrmP7kPtfVDwF6zruppua3/9DJ+3gShF/cwJZh W00LtCRZpDO5cIbWEdyTZboBBrrKTx/Wu5TSnfNbh9Ayo8eJ6UqtPtmoerMV1YRe R7qASSS5TTPcO2GDZzUzzZCLAH1ys3NMzliwqglsD4mYqywa1lypOTg8rNoVVodO J1FrofKGQWZIJXKl1x78E5TlIO5cKnsa+zB4//QDXD3q+aeNhhhsDH1wr5OxjJQ0 JP0184+RsxMElxl75xTLesi5K0YV5jyFlDM74Oeims5iDZ+AX29KNQQfbhqaLSyV I8L8Pl+9fYN4WtVipnfMiOg5KlE+Q6VNRlEsrY/Fsej/4xXroq9d/ilfjZherLtJ 1ekTUdMET2A+C17KzPebHFwuyBWJeT6NWDSuWnLCrYk59tMDuqtPHedKw7Bd1W0Q pBzSH5SH7Qe0I3ance737kcUQLPjlbyO93LL7qk05y8jgZMIGpobmBC1R9Mu53G5 o0OLBLBrKZM54SlGAkh3UEJQtX3FyfUhlfQ8DnZdUmyzWBfzI7GT+tSJdxJ1UQnH MDbKZufq/qve15ODHatdWGxUhP9eTBADa3SVD4PBEJmO8U96fqo795vKU0dck2Op ErjZEQ1x8KVXKvxA7zxQ =Mxyy -----END PGP SIGNATURE----- --=-3RoDNTMIUwNS5Lu1y8s9-- --===============5447004395106335124== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5447004395106335124==--