From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [Resend][PATCH 04/17] rbtree: empty nodes have no color Date: Mon, 12 Jun 2017 18:42:52 +0200 Message-ID: <1497285772.26212.26.camel@citrix.com> References: <20170531212056.10583-1-kpraveen.lkml@gmail.com> <20170531212056.10583-5-kpraveen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6222171708936290508==" Return-path: In-Reply-To: <20170531212056.10583-5-kpraveen.lkml@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============6222171708936290508== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Iv8qqYb4CpqqAGgN+I77" --=-Iv8qqYb4CpqqAGgN+I77 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > Empty nodes have no color.=C2=A0=C2=A0We can make use of this property to > simplify the > code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE macros. >=20 Mmm... you have significantly cut the changelog. I appreciate=C2=A0that som= e of the removed text speaks about a function being removed,=C2=A0which we don't have in our tree. However: =C2=A0- the central part of the changelog, does not speak about=C2=A0 =C2=A0=C2=A0=C2=A0rb_init_node() being removed, and so you can keep it; =C2=A0- leave a mark in the changelog itself (like a one liner, surrounded =C2=A0=C2=A0=C2=A0by '[' ']') about the fact that you alrered the original= =C2=A0changelog. > commit 4c199a93a2d36b277a9fd209a0f2793f8460a215 from linux tree. >=20 > Signed-off-by: Praveen Kumar > Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Iv8qqYb4CpqqAGgN+I77 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZPsSMAAoJEBZCeImluHPuI3UQAJqbzrPuS9oYMfQQA1C4l5kQ pkTh/IB4owtWE1DWzvzgTrd5GHBdqfSlY38Z8dVYpBmJnBEYpyTQ1JSBh8csyNpM iFo+8DJRmvSEqihm68qiSgeOmOCta4Wh97EztmhEiGcVS6WUtCRUYuvqWa/IvJRY vyy6X21O+7Vx2rPAt+D3gqWREwiWhFXu9KvxgybhXoWPh4Q28hAmgTNryN0jGP9Z gSvljpokIBXAb6NGom+FNtdz4tpT1PvgefmrmWYr5wyvode6t2XPaMEzZeAb3iCK E3ZffaFtCtW7gmDwG6k14Y7YasYRQ6LQTRFwL62cpXCUjB5TWdZZz2opLSGEP3rU zLgEPXKTb6Z4DuhJJf6I4pnNKwQYzFZ3ZKNekYwWWtCWA+ESiwGoHVrvYR5BgTcG +fUkVfw4mH1NKBzzMq3gIZ79f9qEtvfzL6Sqy3ychC8f9mwhr00OJYGKsZlGIhjU A+hlEA+x996tZePbvQSWqqtym400re6NFzF/AX6dUte3zN6imCIGKRV+4S0um7AV r6htYvrp8RUgrmDX17evnksaflgaamBBx4U3ZcMZOpre3V7traF61YBIeeCLfJda k/o7JsH6+s+RlSvDBNLw2Y7sXW/wiD9ORC1c8ZcZihVjnKjF9YYY+4qWJTiT+Dye +TujwPSWlKCLZAxHLxJa =90rx -----END PGP SIGNATURE----- --=-Iv8qqYb4CpqqAGgN+I77-- --===============6222171708936290508== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============6222171708936290508==--