From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [Xen-devel[PATCH Resend v2] xen: common: rbtree: ported updates from linux tree Date: Mon, 12 Jun 2017 18:44:27 +0200 Message-ID: <1497285867.26212.27.camel@citrix.com> References: <20170531212056.10583-1-kpraveen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7564734006436070938==" Return-path: In-Reply-To: <20170531212056.10583-1-kpraveen.lkml@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============7564734006436070938== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-aC56QoMrihJ0HdJ/fnhq" --=-aC56QoMrihJ0HdJ/fnhq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > I have not imported augmented and rcu rbtree functionality to the xen > tree, > as there was no specific requirement for current planned > implementation. >=20 > Please share your inputs. Thanks in advance. >=20 So, I'm having another look at this series. Apart from the already mentioned authorship suppression problem, and apart from the comments I've made on the single patches of the series, I think the following (Linux) commits should also be considered (or a reason for not doing that, being stated in the cover letter): f4b477c47332367d35686bd2b808c2156b96d7c7 rbtree: add const qualifier to so= me functions 55a63998b8967615a15e2211ba0ff3a84a565824 lib/rbtree.c: optimize rb_erase() 7ce6ff9e5de99e7b72019c7de82fb438fe1dc5a0 rbtree: coding style adjustments = [*] 1b9c53e849aa65776d4f611d99aa09f856518dad lib/rbtree.c: fix typo in comment= of __rb_insert() ce093a04543c403d52c1a5788d8cb92e47453aba lib/rbtree.c: fix typo in comment= of ____rb_erase_color [**] [*] Either all, or just some honks of it. At least, the changes to the style of the comments are valuable, as they make them consistent with our style too. The others, I'm not sure, but I'd be tempted to say let's take it all, to make backport of other patches easier... [**] not sure about this, maybe you can give it a try, and see if it applies, or can be adapted easily (if the typo is actually present, of course). d72da4a4d973d8a0a0d3c97e7cdebf287fbe3a99 ("rbtree: Make lockless searches non-fatal") looks interesting, but I think we can leave it out for now. But, please, mention it (and the fact you're not porting it because we think we don't need it) in the cover letter. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-aC56QoMrihJ0HdJ/fnhq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZPsTrAAoJEBZCeImluHPuA8MP/0NDVZ9FVRkwBRcTox6VfijW Ol9xwcME8SVjISnP4ZfD3zPhA50E30ALboSuFVSF7irZGZ74viBHyTDA07V0hzBv 2b4NDNjqhqfMnDpuZzvrCGO8e87RvIwIqVpblpiPtoCXmELlybpo8JZq8vhHTobG pzjamraAqNLTXqy7I4zAFgYyyIyH2Fd4D79D7QaTwknsE0Ys+PIMHCVibmrKO9lY ZFhhRwlffzCnyWbaP/8tDJ6T324N4+uWKfRQabYxAdxMbgWakzlI5CFrH+DXf/4C cTstJpThserJtmlLO/RSg3mxiJKzSZUSy5w3mepoT+RJSKo9jDixy4F5ll9Xkjva WvdB1mf2VY6/E+ZJwFL645m7qD+m+hCBvrbyzmzlAcSeSpWg4toTUE+kPt05ZxCd YnYkirhqyEeD0sidu6+IXZUUwAkcNCNtX1wGYzhFTFJu4TUPvIhNGSospDBotcmj eTydOJRWYwHPbewRBSHSCDX5PV/4NixKRy/F5tte5TdiIW4vNrCWx4T0xrO4WyOW UVUB+xQ5act115EWt2bQ4sWW7rO05scY9sUjYvsZLCN2Eijm+nmwpD2IdbK2DJCD wZ6Ay4SkUHV3wIkjpqw4UPOGFsiqTTmYizhadWZHwAGrFoakRF/G6ZtUB4+P73RZ g/vNQNbKXW9O524fqh1e =0Nex -----END PGP SIGNATURE----- --=-aC56QoMrihJ0HdJ/fnhq-- --===============7564734006436070938== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7564734006436070938==--