From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xen.org
Cc: jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>,
boris.ostrovsky@oracle.com, sstabellini@kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 04/18] xen/pvcalls: xenbus state handling
Date: Thu, 15 Jun 2017 12:09:33 -0700 [thread overview]
Message-ID: <1497553787-3709-4-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1497553787-3709-1-git-send-email-sstabellini@kernel.org>
Introduce the code to handle xenbus state changes.
Implement the probe function for the pvcalls backend. Write the
supported versions, max-page-order and function-calls nodes to xenstore,
as required by the protocol.
Introduce stub functions for disconnecting/connecting to a frontend.
Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
---
drivers/xen/pvcalls-back.c | 152 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 152 insertions(+)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 9044cf2..7bce750 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -25,20 +25,172 @@
#include <xen/xenbus.h>
#include <xen/interface/io/pvcalls.h>
+#define PVCALLS_VERSIONS "1"
+#define MAX_RING_ORDER XENBUS_MAX_RING_GRANT_ORDER
+
struct pvcalls_back_global {
struct list_head frontends;
struct semaphore frontends_lock;
} pvcalls_back_global;
+static int backend_connect(struct xenbus_device *dev)
+{
+ return 0;
+}
+
+static int backend_disconnect(struct xenbus_device *dev)
+{
+ return 0;
+}
+
static int pvcalls_back_probe(struct xenbus_device *dev,
const struct xenbus_device_id *id)
{
+ int err, abort;
+ struct xenbus_transaction xbt;
+
+again:
+ abort = 1;
+
+ err = xenbus_transaction_start(&xbt);
+ if (err) {
+ pr_warn("%s cannot create xenstore transaction\n", __func__);
+ return err;
+ }
+
+ err = xenbus_printf(xbt, dev->nodename, "versions", "%s",
+ PVCALLS_VERSIONS);
+ if (err) {
+ pr_warn("%s write out 'version' failed\n", __func__);
+ goto abort;
+ }
+
+ err = xenbus_printf(xbt, dev->nodename, "max-page-order", "%u",
+ MAX_RING_ORDER);
+ if (err) {
+ pr_warn("%s write out 'max-page-order' failed\n", __func__);
+ goto abort;
+ }
+
+ err = xenbus_printf(xbt, dev->nodename, "function-calls",
+ XENBUS_FUNCTIONS_CALLS);
+ if (err) {
+ pr_warn("%s write out 'function-calls' failed\n", __func__);
+ goto abort;
+ }
+
+ abort = 0;
+abort:
+ err = xenbus_transaction_end(xbt, abort);
+ if (err) {
+ if (err == -EAGAIN && !abort)
+ goto again;
+ pr_warn("%s cannot complete xenstore transaction\n", __func__);
+ return err;
+ }
+
+ xenbus_switch_state(dev, XenbusStateInitWait);
+
return 0;
}
+static void set_backend_state(struct xenbus_device *dev,
+ enum xenbus_state state)
+{
+ while (dev->state != state) {
+ switch (dev->state) {
+ case XenbusStateClosed:
+ switch (state) {
+ case XenbusStateInitWait:
+ case XenbusStateConnected:
+ xenbus_switch_state(dev, XenbusStateInitWait);
+ break;
+ case XenbusStateClosing:
+ xenbus_switch_state(dev, XenbusStateClosing);
+ break;
+ default:
+ __WARN();
+ }
+ break;
+ case XenbusStateInitWait:
+ case XenbusStateInitialised:
+ switch (state) {
+ case XenbusStateConnected:
+ backend_connect(dev);
+ xenbus_switch_state(dev, XenbusStateConnected);
+ break;
+ case XenbusStateClosing:
+ case XenbusStateClosed:
+ xenbus_switch_state(dev, XenbusStateClosing);
+ break;
+ default:
+ __WARN();
+ }
+ break;
+ case XenbusStateConnected:
+ switch (state) {
+ case XenbusStateInitWait:
+ case XenbusStateClosing:
+ case XenbusStateClosed:
+ down(&pvcalls_back_global.frontends_lock);
+ backend_disconnect(dev);
+ up(&pvcalls_back_global.frontends_lock);
+ xenbus_switch_state(dev, XenbusStateClosing);
+ break;
+ default:
+ __WARN();
+ }
+ break;
+ case XenbusStateClosing:
+ switch (state) {
+ case XenbusStateInitWait:
+ case XenbusStateConnected:
+ case XenbusStateClosed:
+ xenbus_switch_state(dev, XenbusStateClosed);
+ break;
+ default:
+ __WARN();
+ }
+ break;
+ default:
+ __WARN();
+ }
+ }
+}
+
static void pvcalls_back_changed(struct xenbus_device *dev,
enum xenbus_state frontend_state)
{
+ switch (frontend_state) {
+ case XenbusStateInitialising:
+ set_backend_state(dev, XenbusStateInitWait);
+ break;
+
+ case XenbusStateInitialised:
+ case XenbusStateConnected:
+ set_backend_state(dev, XenbusStateConnected);
+ break;
+
+ case XenbusStateClosing:
+ set_backend_state(dev, XenbusStateClosing);
+ break;
+
+ case XenbusStateClosed:
+ set_backend_state(dev, XenbusStateClosed);
+ if (xenbus_dev_is_online(dev))
+ break;
+ device_unregister(&dev->dev);
+ break;
+ case XenbusStateUnknown:
+ set_backend_state(dev, XenbusStateClosed);
+ device_unregister(&dev->dev);
+ break;
+
+ default:
+ xenbus_dev_fatal(dev, -EINVAL, "saw state %d at frontend",
+ frontend_state);
+ break;
+ }
}
static int pvcalls_back_remove(struct xenbus_device *dev)
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-15 19:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.10.1706151156350.12156@sstabellini-ThinkPad-X260>
2017-06-15 19:09 ` [PATCH v4 01/18] xen: introduce the pvcalls interface header Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 02/18] xen/pvcalls: introduce the pvcalls xenbus backend Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 03/18] xen/pvcalls: initialize the module and register the " Stefano Stabellini
2017-06-15 19:09 ` Stefano Stabellini [this message]
2017-06-15 19:09 ` [PATCH v4 05/18] xen/pvcalls: connect to a frontend Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 06/18] xen/pvcalls: handle commands from the frontend Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 07/18] xen/pvcalls: implement socket command Stefano Stabellini
2017-06-20 15:49 ` Boris Ostrovsky
2017-06-20 16:11 ` Roger Pau Monné
[not found] ` <20170620161112.7x4qickboyt7qyvh@dhcp-3-128.uk.xensource.com>
2017-06-21 20:16 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.10.1706211312450.12819@sstabellini-ThinkPad-X260>
2017-06-22 8:26 ` Roger Pau Monné
[not found] ` <20170622082632.atg6dslz5zs2gtco@dhcp-3-128.uk.xensource.com>
2017-06-22 18:29 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.10.1706221118110.12819@sstabellini-ThinkPad-X260>
2017-06-22 18:36 ` Andrew Cooper
[not found] ` <0ae24b76-03f5-5adf-5437-2c61f934502b@citrix.com>
2017-06-22 18:38 ` Stefano Stabellini
2017-06-23 9:39 ` Roger Pau Monné
2017-06-15 19:09 ` [PATCH v4 08/18] xen/pvcalls: implement connect command Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 09/18] xen/pvcalls: implement bind command Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 10/18] xen/pvcalls: implement listen command Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 11/18] xen/pvcalls: implement accept command Stefano Stabellini
2017-06-20 16:02 ` Boris Ostrovsky
[not found] ` <fcbdad67-30ed-0049-de78-d501347fb561@oracle.com>
2017-06-21 20:29 ` Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 12/18] xen/pvcalls: implement poll command Stefano Stabellini
2017-06-20 16:43 ` Boris Ostrovsky
[not found] ` <15ea89f6-d46e-2495-1b52-d7290b47c478@oracle.com>
2017-06-21 20:39 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.10.1706211331590.12819@sstabellini-ThinkPad-X260>
2017-06-21 20:55 ` Boris Ostrovsky
2017-06-21 21:49 ` Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 13/18] xen/pvcalls: implement release command Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 14/18] xen/pvcalls: disconnect and module_exit Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 15/18] xen/pvcalls: implement the ioworker functions Stefano Stabellini
2017-06-20 17:26 ` Boris Ostrovsky
2017-06-15 19:09 ` [PATCH v4 16/18] xen/pvcalls: implement read Stefano Stabellini
2017-06-21 22:37 ` Boris Ostrovsky
[not found] ` <3fb2cd09-66b1-602a-f56a-8f08f7cbdda5@oracle.com>
2017-06-21 23:32 ` Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 17/18] xen/pvcalls: implement write Stefano Stabellini
2017-06-15 19:09 ` [PATCH v4 18/18] xen: introduce a Kconfig option to enable the pvcalls backend Stefano Stabellini
[not found] ` <1497553787-3709-8-git-send-email-sstabellini@kernel.org>
2017-06-20 15:43 ` [PATCH v4 08/18] xen/pvcalls: implement connect command Boris Ostrovsky
[not found] ` <85f49d02-a640-6259-727d-e3761631d1b5@oracle.com>
2017-06-20 15:47 ` Boris Ostrovsky
2017-06-21 20:25 ` Stefano Stabellini
[not found] ` <fd863110-cc9c-5535-887e-7126a88d62d7@oracle.com>
2017-06-21 20:26 ` Stefano Stabellini
[not found] ` <1497553787-3709-10-git-send-email-sstabellini@kernel.org>
2017-06-20 15:51 ` [PATCH v4 10/18] xen/pvcalls: implement listen command Boris Ostrovsky
[not found] ` <1497553787-3709-13-git-send-email-sstabellini@kernel.org>
2017-06-20 17:15 ` [PATCH v4 13/18] xen/pvcalls: implement release command Boris Ostrovsky
[not found] ` <fc2c34ea-a2de-722b-22e3-174e9ebb9ce3@oracle.com>
2017-06-21 21:33 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497553787-3709-4-git-send-email-sstabellini@kernel.org \
--to=sstabellini@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).