From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 09/20] rbtree: adjust root color in rb_insert_color() only when necessary Date: Mon, 19 Jun 2017 19:13:47 +0200 Message-ID: <1497892427.7405.17.camel@citrix.com> References: <20170617093253.3990-1-kpraveen.lkml@gmail.com> <20170617093253.3990-10-kpraveen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8464808523441527804==" Return-path: In-Reply-To: <20170617093253.3990-10-kpraveen.lkml@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============8464808523441527804== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-gouFe6sklie2VUHm64hN" --=-gouFe6sklie2VUHm64hN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > --- a/xen/common/rbtree.c > +++ b/xen/common/rbtree.c > @@ -90,8 +90,23 @@ void rb_insert_color(struct rb_node *node, struct > rb_root *root) > =C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct rb_node *parent, *gparent; > =C2=A0 > -=C2=A0=C2=A0=C2=A0=C2=A0while ((parent =3D rb_parent(node)) && rb_is_red= (parent)) > +=C2=A0=C2=A0=C2=A0=C2=A0while (true) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ > And here we are again. (I.e., in the cited Linux's commit, this is being turned into 'while (true) {`. So, I think we should gather others' opinion about how to deal with these aspects of this series. So, I'll stop my review for now, and chase feedback. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-gouFe6sklie2VUHm64hN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZSAZLAAoJEBZCeImluHPu+SMP/3BIMfS3keufCVPEWpLLgvKQ DlFc8uCmx9s1ajhi793ouQqr6hL29pnkl+sEggCKtN+izxW/Id3TtbEPmqmWZi+n U4jaFvJZQ1ejKx08iishU5vspewyprId7B0OcYJfNyuVHusBvU0Dz0McKnAhUk0+ OgO7jxnTy/M5UWiFVXebehbQVhxIJ28pFmJFwE5/2t+vDzLncQHERYhyRLB3Ifnw oJmPN7MRO49iYU72NWOhJQftbs1gG1ke+pwA6AdBCRNS4bPjLl48hkAAvSS9xIEW w1VyDhc5tYFQTnG9vKJPXRqtWeNkJ2Rel0T//DQYHHtp8f7K4RuJXfVlpVc6v3be 6DOaJ0Ps+321qO5LGvwKXHvGF5EJwkdSyR44ZqVC4X4vF0qP3cxbecMKAfjI4lFe eG9GHnfcnWKHGerUcJA1WOcWVuR66Sx4BMEbicH1lIMzxNB6QAd8TJqujunp5oNK N07offU7CqmyLp323+jaxxX/NrS8k3mnum2LHivRNZMmaNgilnprHemSVxdfwr7L twjYQv3m7QjACgn83WqtKN1S3M0RmXFvqoov0G7sFLtCh9yLIBZJzMVJPAONCtX0 CauDhNz14acFJC42sBByE+WnQ4eqK6gg4KOP9x6leQ5oIX/onQb+o4P/NcmEwmfR iyhrWhWyYKP2awtQVRp+ =mSfC -----END PGP SIGNATURE----- --=-gouFe6sklie2VUHm64hN-- --===============8464808523441527804== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============8464808523441527804==--