From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 09/20] rbtree: adjust root color in rb_insert_color() only when necessary Date: Tue, 20 Jun 2017 15:54:47 +0200 Message-ID: <1497966887.7405.23.camel@citrix.com> References: <20170617093253.3990-1-kpraveen.lkml@gmail.com> <20170617093253.3990-10-kpraveen.lkml@gmail.com> <1497892427.7405.17.camel@citrix.com> <5948EA34020000780016458A@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7959257130076833165==" Return-path: In-Reply-To: <5948EA34020000780016458A@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Praveen Kumar Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org --===============7959257130076833165== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-yWKBJqfZff0QGFonESds" --=-yWKBJqfZff0QGFonESds Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-06-20 at 01:26 -0600, Jan Beulich wrote: > > > > On 19.06.17 at 19:13, wrote: > > And here we are again. (I.e., in the cited Linux's commit, this is > > being turned into 'while (true) {`. > >=20 > > So, I think we should gather others' opinion about how to deal with > > these aspects of this series. So, I'll stop my review for now, and > > chase feedback. >=20 > I fully second your opinion here. I even wonder whether we > shouldn't convert the file back to be fully Linux style first thing, > so that Linux changes can be applied (mostly) as is, specifically > without having to convert tabs to spaces. >=20 That indeed would be good! Praveen, this would mean having a patch, at the beginning of the series, which converts the coding style of the files to Linux one. Basically, that would mean using tabs for indentation, and undoing any style change that may have been done in our tree, to make the file adopt the Xen style. In practise, the idea is ending up with something that is basically identical to what was in Linux, before all the patches you are porting were committed (and without the additional parts and features that we don't need, of course). At this point, even generating and applying the patches that you are porting, in this very series, would be really easy, and less error prone (as it can be almost entirely automated). Are you up for this? Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-yWKBJqfZff0QGFonESds Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZSSknAAoJEBZCeImluHPuBFQP/jBa+y3SD4UM6SifNYeGC85v XKF9cktvSb4dG63rU5Jmd+22ykwnhvZB458ov6EVdY65PdmpUvy+R+kMkZsnseCM O4QsCMpjeBQpI97/QIeTggq4aByVdWOqPSgKhNBTH4SBg58nubtqH6O+MDyaRItf a3+ijshudTZnRqu4t0fXHMpmwezEN51WaALW2EMgwGuPjhUUGvFJ3PfZB6pOlYOk HdC9sp8BvIC4K9o6ay6gJTI2KWDv4h0DrzU8V0qBS6BZNezFURaqMUW6b0ew/7RS zw+Gay95ApMzTTF8yToxjpfIh1S6R5dn51Ek5T1j2HkYMDj/h9g17vpTzpaSUD2l 1bsoTwYDN2zEeLxgIj1VgOnpq/s+ZadgwwNsYq9AO9eUawX/5qK37yEJDlMkJN0f 4LvrMbnZajN4qSSOtEKpUo1xtenA8dz03uxORjy4ajxBqCaxuJbRXtEFG+8xbsFc P1n6u0TQncY4LO5217GrpBDlykum/9D4NksqB4mNbnWRHCyqjbLlk8eSU8BfVZcv hoI4IGEJSHdY4if3TDO6GNjIHSd5nK/4HWdyFyf9A6aUdy7x43sy0S/+RXmXn//W VfT8KRUi1x4zEeAa0t8zfcBYzkfiXDqFJuYMSwSDzp4Gfy5uqndIiEmrHmatwWiT s0YSu9q08b4R4acqVYWd =TdVO -----END PGP SIGNATURE----- --=-yWKBJqfZff0QGFonESds-- --===============7959257130076833165== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7959257130076833165==--