From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 15/17 v5] xen/arm: vpl011: Add a new vuart console type to xenconsole client
Date: Thu, 22 Jun 2017 13:08:50 +0530 [thread overview]
Message-ID: <1498117132-27139-16-git-send-email-bhupinder.thakur@linaro.org> (raw)
In-Reply-To: <1498117132-27139-1-git-send-email-bhupinder.thakur@linaro.org>
Add a new console type VUART to connect to guest's emualated vuart
console.
Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
---
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>
Changes since v4:
- Removed the vuart compile time flag so that vuart code is compiled always.
Changes since v3:
- The vuart console support is under CONFIG_VUART_CONSOLE option.
- Since there is a change from last review, I have not included
reviewed-by tag from Stefano and acked-by tag from Wei.
tools/console/client/main.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/tools/console/client/main.c b/tools/console/client/main.c
index 977779f..3dbb06f 100644
--- a/tools/console/client/main.c
+++ b/tools/console/client/main.c
@@ -76,7 +76,7 @@ static void usage(const char *program) {
"\n"
" -h, --help display this help and exit\n"
" -n, --num N use console number N\n"
- " --type TYPE console type. must be 'pv' or 'serial'\n"
+ " --type TYPE console type. must be 'pv', 'serial' or 'vuart'\n"
" --start-notify-fd N file descriptor used to notify parent\n"
, program);
}
@@ -264,6 +264,7 @@ typedef enum {
CONSOLE_INVAL,
CONSOLE_PV,
CONSOLE_SERIAL,
+ CONSOLE_VUART,
} console_type;
static struct termios stdin_old_attr;
@@ -343,6 +344,7 @@ int main(int argc, char **argv)
char *end;
console_type type = CONSOLE_INVAL;
bool interactive = 0;
+ char *console_names = "serial, pv, vuart";
if (isatty(STDIN_FILENO) && isatty(STDOUT_FILENO))
interactive = 1;
@@ -361,9 +363,12 @@ int main(int argc, char **argv)
type = CONSOLE_SERIAL;
else if (!strcmp(optarg, "pv"))
type = CONSOLE_PV;
+ else if (!strcmp(optarg, "vuart"))
+ type = CONSOLE_VUART;
else {
fprintf(stderr, "Invalid type argument\n");
- fprintf(stderr, "Console types supported are: serial, pv\n");
+ fprintf(stderr, "Console types supported are: %s\n",
+ console_names);
exit(EINVAL);
}
break;
@@ -436,6 +441,10 @@ int main(int argc, char **argv)
else
snprintf(path, strlen(dom_path) + strlen("/device/console/%d/tty") + 5, "%s/device/console/%d/tty", dom_path, num);
}
+ if (type == CONSOLE_VUART) {
+ snprintf(path, strlen(dom_path) + strlen("/vuart/0/tty") + 1,
+ "%s/vuart/0/tty", dom_path);
+ }
/* FIXME consoled currently does not assume domain-0 doesn't have a
console which is good when we break domain-0 up. To keep us
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-22 7:39 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 7:38 [PATCH 00/17 v5] SBSA UART emulation support in Xen Bhupinder Thakur
2017-06-22 7:38 ` [PATCH 01/17 v5] xen/arm: vpl011: Move vgic register access functions to vreg.h Bhupinder Thakur
2017-06-22 7:38 ` [PATCH 02/17 v5] xen/arm: vpl011: Rename vgic_reg* functions definitions and calls to vreg_reg* Bhupinder Thakur
2017-06-23 9:42 ` Julien Grall
2017-06-22 7:38 ` [PATCH 03/17 v5] xen/arm: vpl011: Define common ring buffer helper functions in console.h Bhupinder Thakur
2017-06-22 22:36 ` Stefano Stabellini
2017-06-28 17:16 ` Wei Liu
2017-06-22 7:38 ` [PATCH 04/17 v5] xen/arm: vpl011: Add SBSA UART emulation in Xen Bhupinder Thakur
2017-06-22 22:53 ` Stefano Stabellini
2017-06-23 12:33 ` Julien Grall
2017-06-23 18:28 ` Stefano Stabellini
2017-06-23 19:58 ` Julien Grall
2017-06-23 13:10 ` Julien Grall
2017-06-22 7:38 ` [PATCH 05/17 v5] xen/arm: vpl011: Allocate a new GFN in the toolstack for vuart Bhupinder Thakur
2017-06-22 7:38 ` [PATCH 06/17 v5] xen/arm: vpl011: Add support for vuart in libxl Bhupinder Thakur
2017-06-22 22:57 ` Stefano Stabellini
2017-06-28 17:16 ` Wei Liu
2017-06-22 7:38 ` [PATCH 07/17 v5] xen/arm: vpl011: Rearrange xen header includes in alphabetical order in domctl.c Bhupinder Thakur
2017-06-22 22:58 ` Stefano Stabellini
2017-06-23 13:14 ` Julien Grall
2017-06-22 7:38 ` [PATCH 08/17 v5] xen/arm: vpl011: Add a new domctl API to initialize vpl011 Bhupinder Thakur
2017-06-22 23:04 ` Stefano Stabellini
2017-06-23 13:17 ` Julien Grall
2017-06-23 13:25 ` Julien Grall
2017-06-23 17:57 ` Stefano Stabellini
2017-06-27 13:43 ` Bhupinder Thakur
2017-06-27 13:57 ` Julien Grall
2017-06-23 13:26 ` Julien Grall
2017-06-28 17:16 ` Wei Liu
2017-06-22 7:38 ` [PATCH 09/17 v5] xen/arm: vpl011: Add a new vuart node in the xenstore Bhupinder Thakur
2017-06-22 23:06 ` Stefano Stabellini
2017-06-28 17:16 ` Wei Liu
2017-06-22 7:38 ` [PATCH 10/17 v5] xen/arm: vpl011: Modify xenconsole to define and use a new console structure Bhupinder Thakur
2017-06-22 23:20 ` Stefano Stabellini
2017-06-28 17:16 ` Wei Liu
2017-06-22 7:38 ` [PATCH 11/17 v5] xen/arm: vpl011: Rename the console structure field conspath to xspath Bhupinder Thakur
2017-06-22 23:21 ` Stefano Stabellini
2017-06-28 17:16 ` Wei Liu
2017-06-22 7:38 ` [PATCH 12/17 v5] xen/arm: vpl011: Modify xenconsole functions to take console structure as input Bhupinder Thakur
2017-06-28 17:16 ` Wei Liu
2017-06-22 7:38 ` [PATCH 13/17 v5] xen/arm: vpl011: Modify xenconsole to support multiple consoles Bhupinder Thakur
2017-06-22 23:51 ` Stefano Stabellini
2017-06-28 17:16 ` Wei Liu
2017-07-07 13:52 ` Bhupinder Thakur
2017-07-07 14:00 ` Wei Liu
2017-07-07 14:19 ` Bhupinder Thakur
2017-07-07 14:23 ` Wei Liu
2017-06-22 7:38 ` [PATCH 14/17 v5] xen/arm: vpl011: Add support for vuart console in xenconsole Bhupinder Thakur
2017-06-23 0:02 ` Stefano Stabellini
2017-06-28 17:17 ` Wei Liu
2017-06-22 7:38 ` Bhupinder Thakur [this message]
2017-06-22 23:09 ` [PATCH 15/17 v5] xen/arm: vpl011: Add a new vuart console type to xenconsole client Stefano Stabellini
2017-06-28 17:17 ` Wei Liu
2017-06-29 9:33 ` Bhupinder Thakur
2017-06-29 10:11 ` Wei Liu
2017-06-22 7:38 ` [PATCH 16/17 v5] xen/arm: vpl011: Add a pl011 uart DT node in the guest device tree Bhupinder Thakur
2017-06-28 17:17 ` Wei Liu
2017-06-22 7:38 ` [PATCH 17/17 v5] xen/arm: vpl011: Update documentation for vuart console support Bhupinder Thakur
2017-06-23 10:42 ` [PATCH 00/17 v5] SBSA UART emulation support in Xen Julien Grall
2017-06-23 17:58 ` Stefano Stabellini
2017-07-04 7:31 ` Bhupinder Thakur
2017-07-05 8:36 ` Julien Grall
2017-07-05 19:06 ` Stefano Stabellini
2017-07-05 19:43 ` Julien Grall
2017-07-05 19:51 ` Julien Grall
2017-07-05 20:05 ` Stefano Stabellini
2017-07-05 20:18 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498117132-27139-16-git-send-email-bhupinder.thakur@linaro.org \
--to=bhupinder.thakur@linaro.org \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).