From: Simon Waterman <watermansrdev@gmail.com>
To: xen-devel@lists.xen.org
Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com,
Simon Waterman <watermansrdev@gmail.com>
Subject: [PATCH RFC 3/3] libxl: upstream Qemu as PV backend for IOEMU stubdom
Date: Sun, 25 Jun 2017 23:15:31 +0100 [thread overview]
Message-ID: <1498428931-465-4-git-send-email-watermansrdev@gmail.com> (raw)
In-Reply-To: <1498428931-465-1-git-send-email-watermansrdev@gmail.com>
Set the PV model version for the IOEMU stubdom from
the new device_model_pv_version setting. Existing code
sets up the command line and spawns the specified version
correctly.
In addition, the upstream QEMU doesn't allow the restore
console to be undefined (it SEGV's) so if this is not a restore
set it to "null" instead. This has the same affect on both upstream
QEMU and qemu-xen-traditional.
Signed-off-by: Simon Waterman <watermansrdev@gmail.com>
---
tools/libxl/libxl_dm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index f8ba859..9e4a27a 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -1847,8 +1847,8 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss)
dm_config->b_info.u.pv.features = "";
- dm_config->b_info.device_model_version =
- guest_config->b_info.device_model_version;
+ dm_config->b_info.device_model_version =
+ guest_config->b_info.device_model_pv_version;
dm_config->b_info.device_model =
guest_config->b_info.device_model;
dm_config->b_info.extra = guest_config->b_info.extra;
@@ -2014,6 +2014,8 @@ static void spawn_stub_launch_dm(libxl__egc *egc,
if (d_state->saved_state)
console[i].output =
GCSPRINTF("pipe:%s", d_state->saved_state);
+ else
+ console[i].output = "null";
break;
default:
console[i].output = "pty";
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-25 22:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-25 22:15 [PATCH RFC 0/3] libxl: upstream Qemu as PV backend for IOEMU stubdom Simon Waterman
2017-06-25 22:15 ` [PATCH RFC 1/3] " Simon Waterman
2017-06-25 22:15 ` [PATCH RFC 2/3] " Simon Waterman
2017-06-25 22:15 ` Simon Waterman [this message]
2017-06-28 17:36 ` [PATCH RFC 0/3] " Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498428931-465-4-git-send-email-watermansrdev@gmail.com \
--to=watermansrdev@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).