From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: [PULL 1/3] xen/disk: don't leak stack data via response ring Date: Tue, 27 Jun 2017 15:04:41 -0700 Message-ID: <1498601083-11799-1-git-send-email-sstabellini@kernel.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPybM-0002yw-Ib for xen-devel@lists.xenproject.org; Tue, 27 Jun 2017 22:04:52 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: peter.maydell@linaro.org, stefanha@gmail.com Cc: sstabellini@kernel.org, stefanha@redhat.com, qemu-devel@nongnu.org, Jan Beulich , anthony.perard@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org UmF0aGVyIHRoYW4gY29uc3RydWN0aW5nIGEgbG9jYWwgc3RydWN0dXJlIGluc3RhbmNlIG9uIHRo ZSBzdGFjaywgZmlsbAp0aGUgZmllbGRzIGRpcmVjdGx5IG9uIHRoZSBzaGFyZWQgcmluZywganVz dCBsaWtlIG90aGVyIChMaW51eCkKYmFja2VuZHMgZG8uIEJ1aWxkIG9uIHRoZSBmYWN0IHRoYXQg YWxsIHJlc3BvbnNlIHN0cnVjdHVyZSBmbGF2b3JzIGFyZQphY3R1YWxseSBpZGVudGljYWwgKGFz aWRlIGZyb20gYWxpZ25tZW50IGFuZCBwYWRkaW5nIGF0IHRoZSBlbmQpLgoKVGhpcyBpcyBYU0Et MjE2LgoKUmVwb3J0ZWQgYnk6IEFudGhvbnkgUGVyYXJkIDxhbnRob255LnBlcmFyZEBjaXRyaXgu Y29tPgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClNpZ25l ZC1vZmYtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KQWNr ZWQtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgotLS0KIGh3 L2Jsb2NrL3hlbl9kaXNrLmMgfCAyNSArKysrKysrKysrKystLS0tLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv aHcvYmxvY2sveGVuX2Rpc2suYyBiL2h3L2Jsb2NrL3hlbl9kaXNrLmMKaW5kZXggM2EyMjgwNS4u OTIwMDUxMSAxMDA2NDQKLS0tIGEvaHcvYmxvY2sveGVuX2Rpc2suYworKysgYi9ody9ibG9jay94 ZW5fZGlzay5jCkBAIC03NjksMzEgKzc2OSwzMCBAQCBzdGF0aWMgaW50IGJsa19zZW5kX3Jlc3Bv bnNlX29uZShzdHJ1Y3QgaW9yZXEgKmlvcmVxKQogICAgIHN0cnVjdCBYZW5CbGtEZXYgICpibGtk ZXYgPSBpb3JlcS0+YmxrZGV2OwogICAgIGludCAgICAgICAgICAgICAgIHNlbmRfbm90aWZ5ICAg PSAwOwogICAgIGludCAgICAgICAgICAgICAgIGhhdmVfcmVxdWVzdHMgPSAwOwotICAgIGJsa2lm X3Jlc3BvbnNlX3QgIHJlc3A7Ci0gICAgdm9pZCAgICAgICAgICAgICAgKmRzdDsKLQotICAgIHJl c3AuaWQgICAgICAgID0gaW9yZXEtPnJlcS5pZDsKLSAgICByZXNwLm9wZXJhdGlvbiA9IGlvcmVx LT5yZXEub3BlcmF0aW9uOwotICAgIHJlc3Auc3RhdHVzICAgID0gaW9yZXEtPnN0YXR1czsKKyAg ICBibGtpZl9yZXNwb25zZV90ICAqcmVzcDsKIAogICAgIC8qIFBsYWNlIG9uIHRoZSByZXNwb25z ZSByaW5nIGZvciB0aGUgcmVsZXZhbnQgZG9tYWluLiAqLwogICAgIHN3aXRjaCAoYmxrZGV2LT5w cm90b2NvbCkgewogICAgIGNhc2UgQkxLSUZfUFJPVE9DT0xfTkFUSVZFOgotICAgICAgICBkc3Qg PSBSSU5HX0dFVF9SRVNQT05TRSgmYmxrZGV2LT5yaW5ncy5uYXRpdmUsIGJsa2Rldi0+cmluZ3Mu bmF0aXZlLnJzcF9wcm9kX3B2dCk7CisgICAgICAgIHJlc3AgPSAoYmxraWZfcmVzcG9uc2VfdCAq KSBSSU5HX0dFVF9SRVNQT05TRSgmYmxrZGV2LT5yaW5ncy5uYXRpdmUsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBibGtkZXYtPnJpbmdzLm5hdGl2ZS5yc3BfcHJvZF9wdnQpOwog ICAgICAgICBicmVhazsKICAgICBjYXNlIEJMS0lGX1BST1RPQ09MX1g4Nl8zMjoKLSAgICAgICAg ZHN0ID0gUklOR19HRVRfUkVTUE9OU0UoJmJsa2Rldi0+cmluZ3MueDg2XzMyX3BhcnQsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJsa2Rldi0+cmluZ3MueDg2XzMyX3BhcnQucnNw X3Byb2RfcHZ0KTsKKyAgICAgICAgcmVzcCA9IChibGtpZl9yZXNwb25zZV90ICopIFJJTkdfR0VU X1JFU1BPTlNFKCZibGtkZXYtPnJpbmdzLng4Nl8zMl9wYXJ0LAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYmxrZGV2LT5yaW5ncy54ODZfMzJfcGFydC5yc3BfcHJvZF9wdnQpOwog ICAgICAgICBicmVhazsKICAgICBjYXNlIEJMS0lGX1BST1RPQ09MX1g4Nl82NDoKLSAgICAgICAg ZHN0ID0gUklOR19HRVRfUkVTUE9OU0UoJmJsa2Rldi0+cmluZ3MueDg2XzY0X3BhcnQsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJsa2Rldi0+cmluZ3MueDg2XzY0X3BhcnQucnNw X3Byb2RfcHZ0KTsKKyAgICAgICAgcmVzcCA9IChibGtpZl9yZXNwb25zZV90ICopIFJJTkdfR0VU X1JFU1BPTlNFKCZibGtkZXYtPnJpbmdzLng4Nl82NF9wYXJ0LAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYmxrZGV2LT5yaW5ncy54ODZfNjRfcGFydC5yc3BfcHJvZF9wdnQpOwog ICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgotICAgICAgICBkc3QgPSBOVUxMOwogICAgICAg ICByZXR1cm4gMDsKICAgICB9Ci0gICAgbWVtY3B5KGRzdCwgJnJlc3AsIHNpemVvZihyZXNwKSk7 CisKKyAgICByZXNwLT5pZCAgICAgICAgPSBpb3JlcS0+cmVxLmlkOworICAgIHJlc3AtPm9wZXJh dGlvbiA9IGlvcmVxLT5yZXEub3BlcmF0aW9uOworICAgIHJlc3AtPnN0YXR1cyAgICA9IGlvcmVx LT5zdGF0dXM7CisKICAgICBibGtkZXYtPnJpbmdzLmNvbW1vbi5yc3BfcHJvZF9wdnQrKzsKIAog ICAgIFJJTkdfUFVTSF9SRVNQT05TRVNfQU5EX0NIRUNLX05PVElGWSgmYmxrZGV2LT5yaW5ncy5j b21tb24sIHNlbmRfbm90aWZ5KTsKLS0gCjEuOS4xCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==