From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [RTDS Patch v3 for Xen4.8] Date: Mon, 3 Jul 2017 19:09:33 +0200 Message-ID: <1499101773.12805.1.camel@citrix.com> References: <1499098656-1608-1-git-send-email-naroahlee@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9218889052896832764==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS4rT-00069t-1N for xen-devel@lists.xenproject.org; Mon, 03 Jul 2017 17:10:11 +0000 In-Reply-To: <1499098656-1608-1-git-send-email-naroahlee@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Haoran Li , xen-devel@lists.xenproject.org Cc: mengxu@cis.upenn.edu List-Id: xen-devel@lists.xenproject.org --===============9218889052896832764== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-LLljDLZVbhBU0PkbFMRh" --=-LLljDLZVbhBU0PkbFMRh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2017-07-03 at 11:17 -0500, Haoran Li wrote: > From: naroahlee >=20 > =C2=A0When more than one idle VCPUs that have > =C2=A0the same PCPU as their previous running core invoke runq_tickle(), > they will > =C2=A0tickle the same PCPU. The tickled PCPU will only pick at most one > VCPU, i.e., > =C2=A0the highest-priority one, to execute. The other VCPUs will not be > scheduled > =C2=A0for a period, even when there is an idle core, making these VCPUs > =C2=A0unnecessarily starve for one period. Therefore, always make sure > that we only > =C2=A0tickle PCPUs that have not been tickled already. >=20 > Signed-off-by: Haoran Li > Reviewed-by:=C2=A0=C2=A0=C2=A0Meng Xu=C2=A0=C2=A0=C2=A0 >=20 So, from what I can see from the 'From' tag, and from the pieces of emails, that appear below the patch, this is some kind of resubmission/new version, of a patch sent a while back. However, the subject seems to have changed... Or in any case, the current subject is no good. It's also a bit unusual, and definitely not comfortable for people managing the patch, to have a quoted email conversation below the patch itself (or so I think). So, please, remove it. Finally, in that quoted email conversation, I asked for some changes, and said that, with them done, my Reviewed-by: would stand. Have you made those changes? If yes, please, mention this somewhere (Ideally, between the S-o-b, R-b tags and the patch itself, after a '---' mark). Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-LLljDLZVbhBU0PkbFMRh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZWnpOAAoJEBZCeImluHPuQhYP/jWuoqAq8fjYw3T6ONI8oRP9 Qo4VjkGi+qJc+z/eUmU9Vzcfk88gFKqRG1T3uH0EQHRGDMZ2OKeYGuqOFp27tWHu yu/9HtzLoYjQFdwgdz0KBcqozfdI709uXRjZG0NlbynCFMjUQrKAh2qjs5l6IpTL eyjUFkdY90SakEFE8+h5Ag5QsXLjaTuH6H/1OKw7RqCiRb8Ee9UjRkyHnsqIdpmn NhEuZzaJRCg+AayfTl2sHHfP/qpguBjee78n0UZ8shzSMOUd8A9/8eVYxdd7ffch T1u5wsgBiZ3NHTa9O15hEvT9XWGoHO1KNUy449D9+emKYNsZjdcD9Gr4zPBkXk4n WQgn6vY9gyxNwF2Rz3LzS5PERCREvCFjVBDJeZt0kzEDk5g/dX6WQkDCZdGY2VyX iI2hJM2qy3VQK5HAf0vGK3SOgFU0tr1U8kFo1cDeLnexgNXon2lWOHiPgkfGm6Vv kV8Cqrchf6PsZx3gCBTYewjbdtn0aZr7mR1DUsNQgY+O36Zipn2LMj7NjK2dTIRP oFOxUlNsEcUU0rV4vkuLK2VqfaF+h3gb+KfuHIlaZwiB6dbnWm2SgTOEF4eLc7/F cdT4yhj0gm/c87FL5sZbPpOU4gmqladbbZpKEOc6vcRPGPXFhtLJlzucncQm+FwK TcUCbemXlp8hgUQTj0WM =jPpR -----END PGP SIGNATURE----- --=-LLljDLZVbhBU0PkbFMRh-- --===============9218889052896832764== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============9218889052896832764==--