From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/9] xen/mm: move modify_identity_mmio to global file and drop __init Date: Tue, 25 Apr 2017 10:09:34 +0100 Message-ID: <14e43c58-48fe-758e-b869-e1a9badfbac1@arm.com> References: <20170420151743.90889-1-roger.pau@citrix.com> <20170420151743.90889-4-roger.pau@citrix.com> <219593bd-e49e-ecee-0bfa-e10d67251e4c@arm.com> <20170425080110.pf7x6xx3dbtfvpnf@dhcp-3-128.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2wTn-0000Ow-Tt for xen-devel@lists.xenproject.org; Tue, 25 Apr 2017 09:09:52 +0000 In-Reply-To: <20170425080110.pf7x6xx3dbtfvpnf@dhcp-3-128.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Roger Pau Monne Cc: Stefano Stabellini , Andrew Cooper , Jan Beulich , xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, nd@arm.com List-Id: xen-devel@lists.xenproject.org SGkgUm9nZXIsCgpPbiAyNS8wNC8yMDE3IDA5OjAxLCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6Cj4g T24gTW9uLCBBcHIgMjQsIDIwMTcgYXQgMDM6NDI6MDhQTSArMDEwMCwgSnVsaWVuIEdyYWxsIHdy b3RlOgo+PiBPbiAyMC8wNC8xNyAxNjoxNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+Pj4gIC8q IFBvcHVsYXRlIGEgSFZNIG1lbW9yeSByYW5nZSB1c2luZyB0aGUgYmlnZ2VzdCBwb3NzaWJsZSBv cmRlci4gKi8KPj4+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL21lbW9yeS5jIGIveGVuL2NvbW1v bi9tZW1vcnkuYwo+Pj4gaW5kZXggNTI4NzllNzQzOC4uMGQ5NzA0ODJjYiAxMDA2NDQKPj4+IC0t LSBhL3hlbi9jb21tb24vbWVtb3J5LmMKPj4+ICsrKyBiL3hlbi9jb21tb24vbWVtb3J5LmMKPj4+ IEBAIC0xNDM4LDYgKzE0MzgsNDAgQEAgaW50IHByZXBhcmVfcmluZ19mb3JfaGVscGVyKAo+Pj4g ICAgICByZXR1cm4gMDsKPj4+ICB9Cj4+Pgo+Pj4gK2ludCBtb2RpZnlfbW1pbyhzdHJ1Y3QgZG9t YWluICpkLCB1bnNpZ25lZCBsb25nIGdmbiwgdW5zaWduZWQgbG9uZyBwZm4sCj4+Cj4+IFdoaWxz dCB5b3UgaW50cm9kdWNlIHRoaXMgbmV3IGZ1bmN0aW9uLCBwbGVhc2UgdXNlIG1mbl90IGFuZCBn Zm5fdC4KPj4KPj4gQWxzbyBzL3Bmbi9tZm4vCj4KPiBEb25lLgo+Cj4+PiArICAgICAgICAgICAg ICAgIHVuc2lnbmVkIGxvbmcgbnJfcGFnZXMsIGNvbnN0IGJvb2wgbWFwKQo+Pj4gK3sKPj4+ICsg ICAgaW50IHJjOwo+Pj4gKwo+Pj4gKyAgICAvKgo+Pj4gKyAgICAgKiBNYWtlIHN1cmUgdGhpcyBm dW5jdGlvbiBpcyBvbmx5IHVzZWQgYnkgdGhlIGhhcmR3YXJlIGRvbWFpbiwgYmVjYXVzZSBpdAo+ Pj4gKyAgICAgKiBjYW4gdGFrZSBhbiBhcmJpdHJhcnkgbG9uZyB0aW1lLCBhbmQgY291bGQgRG9T IHRoZSB3aG9sZSBzeXN0ZW0uCj4+PiArICAgICAqLwo+Pj4gKyAgICBBU1NFUlQoaXNfaGFyZHdh cmVfZG9tYWluKGQpKTsKPj4KPj4gV2hhdCB3b3VsZCBiZSB0aGUgcGxhbiBmb3IgZ3Vlc3QgaWYg d2UgZGVjaWRlIHRvIHVzZSB2cGNpPwo+Cj4gT25lIG9wdGlvbiB3b3VsZCBiZSB0byBub3QgYWxs b3cgdGhlIERvbVUgdG8gcmVsb2NhdGUgaXQncyBCQVJzIGFuZCBpZ25vcmUKPiB3cml0ZXMgdG8g dGhlIDJuZCBiaXQgb2YgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgKFBDSV9DT01NQU5EX01FTU9SWSks IHRodXMgYWx3YXlzCj4gaGF2aW5nIHRoZSBCQVJzIG1hcHBlZC4gVGhlIG90aGVyIGlzIHRvIHNv bWVob3cgYWxsb3cgVk1FeGl0IChhbmQgdGhlIEFSTQo+IGVxdWl2YWxlbnQpIGNvbnRpbnVhdGlv biAoc29tZXRoaW5nIHNpbWlsYXIgdG8gd2hhdCB3ZSBkbyB3aXRoIGh5cGVyY2FsbHMpLgoKTXkg dW5kZXJzdGFuZGluZyBpcyBCQVJzIG1heSBiZSBhbGxvY2F0ZWQgYnkgdGhlIGtlcm5lbCBiZWNh dXNlIHRoZSAKZmlybXdhcmUgZGlkbid0IGRvIGl0LiBUaGlzIGlzIHRoZSBjdXJyZW50IGNhc2Ug b24gQVJNIChhbmQgSSBndWVzcyB4ODYpIAp3aGVyZSBMaW51eCB3aWxsIGFsd2F5cyBnbyB0aHJv dWdoIHRoZSBCQVJzLgoKU28gaWYgeW91IGRvIHRoZSBmaXJzdCBvcHRpb24sIHdobyB3b3VsZCBk ZWNpZGUgdGhlIHBvc2l0aW9uIG9mIHRoZSBCQVJzPwoKRm9yIHRoZSBzZWNvbmQgb3B0aW9uLCB3 ZSBjYW4gdGFrZSBhZHZhbnRhZ2Ugb2Ygc3VwZXJwYWdlICg0SywgMk0sIDFHKSAKbWFwcGluZyBv biBBUk0sIHNvIHRoZSBudW1iZXIgb2YgYWN0dWFsIG1hcHBpbmcgd291bGQgYmUgcmVhbGx5IGxp bWl0ZWQuCgpBbHNvLCB3ZSBhcmUgbG9va2luZyBhdCBNTUlPIGNvbnRpbnVhdGlvbiBmb3IgQVJN IGZvciBvdGhlciBwYXJ0IG9mIHRoZSAKaHlwZXJ2aXNvci4gV2UgbWlnaHQgYmUgYWJsZSB0byBs ZXZlcmFnZSB0aGF0IGZvciB0aGlzIGZ1bmN0aW9uLgoKPgo+Pj4gKwo+Pj4gKyAgICBmb3IgKCA7 IDsgKQo+Pj4gKyAgICB7Cj4+PiArICAgICAgICByYyA9IChtYXAgPyBtYXBfbW1pb19yZWdpb25z IDogdW5tYXBfbW1pb19yZWdpb25zKQo+Pgo+PiBPbiBBUk0sIG1hcF9tbWlvX3JlZ2lvbnMgYW5k IHVubWFwX21taW9fcmVnaW9ucyB3aWxsIG1hcCB0aGUgTU1JTyB3aXRoIHZlcnkKPj4gc3RyaWN0 IGF0dHJpYnV0ZS4gSSB0aGluayB3ZSB3b3VsZCBuZWVkIGFuIGV4dHJhIGFyZ3VtZW50IHRvIGtu b3cgdGhlIHdhbnRlZAo+PiBtZW1vcnkgYXR0cmlidXRlIChtYXliZSBwMm1fdHlwZV90PykuCj4K PiBJJ20gbm90IHN1cmUgSSBjYW4gZG8gYW55dGhpbmcgcmVnYXJkaW5nIHRoaXMgQVRNLiBTb3Jy eSBmb3IgbXkgaWdub3JhbmNlLCBidXQKPiBtYXBfbW1pb19yZWdpb25zIG9uIEFSTSBtYXBzIHRo ZSByZWdpb24gYXMgcDJtX21taW9fZGlyZWN0X2RldiwgYW5kIGFjY29yZGluZwo+IHRvIHRoZSBj b21tZW50IHRoYXQncyAiUmVhZC93cml0ZSBtYXBwaW5nIG9mIGdlbnVpbmUgRGV2aWNlIE1NSU8g YXJlYSIsIHdoaWNoCj4gZml0cyBleGFjdGx5IGludG8gbXkgdXNhZ2UgKEknbSB1c2luZyBpdCB0 byBtYXAgQkFScykuCgpXZSBoYXZlIGZldyBwMm1fbW1pb19kaXJlY3RfKiBwMm1fdHlwZSBiZWNh dXNlIHRoZSBhcmNoaXRlY3R1cmUgYWxsb3dzIAp1cyB0byBoYXZlIGZpbmUgZ3JhaW4gbWVtb3J5 IGF0dHJpYnV0ZS4KClRoZSBwMm0gdHlwZSBwMm1fbW1pb19kaXJlY3RfZGV2IGlzIHZlcnkgcmVz dHJpY3RpdmUgKHVuYWxpZ25lZCBhY2Nlc3MgCmZvcmJpZCwgbm9uLWNhY2hlYWJsZSwgbm9uLWdh dGhlcmFibGUpLiBUaGlzIHNob3VsZCBiZSB1c2VkIGZvciBNTUlPIApyZWdpb24gdGhhdCBoYXZl IHNpZGUtZWZmZWN0cyBhbmQgd2lsbCBhZmZlY3QgcGVyZm9ybWFuY2VzLgoKV2UgdXNlIHRoaXMg b25lIGJ5IGRlZmF1bHQgYXMgaXQgd2lsbCByZXN0cmljdCB0aGUgbWVtb3J5IGF0dHJpYnV0ZSB1 c2VkIApieSB0aGUgZ3Vlc3QuIEhvd2V2ZXIsIHRoaXMgd2lsbCBiZSBhbiBpc3N1ZSBmb3IgYXQg bGVhc3QgY2FjaGVhYmxlIApCQVJzLiBXZSBoYWQgc2ltaWxhciBpc3N1ZSByZWNlbnRseSBvbiBB Uk0gd2l0aCBTUkFNIGRldmljZSBhcyBkcml2ZXIgCm1heSBkbyB1bmFsaWduZWQgYWNjZXNzIGFu ZCBjYWNoZWFibGUgb25lLgoKRm9yIERPTTAgd2UgYXJlIHVzaW5nIHAybV9tbWlvX2RpcmVjdF9j IGFuZCByZWx5IG9uIHRoZSBPUyB0byByZXN0cmljdCAKdGhlIG1lbW9yeSBhdHRyaWJ1dGUgd2hl biBuZWNlc3NhcnkuIFdlIGNhbm5vdCBkbyB0aGF0IGZvciBndWVzdCBhcyB0aGlzIAptYXkgaGF2 ZSBzb21lIHNlY3VyaXR5IGltcGxpY2F0aW9ucy4KClNvIGZvciB0aGUgZ3Vlc3Qgd2Ugd2lsbCBk byBvbiB0aGUgY2FzZSBieSBjYXNlIGJhc2lzLiBGb3IgaW5zdGFuY2Ugd2UgCnlvdSBtYXAgQkFS LCB5b3Uga25vdyB0aGUga2luZCBhbmQgY2FuIGRlY2lkZSBvZiBhIHByb3BlciBtZW1vcnkgYXR0 cmlidXRlLgoKQ2hlZXJzLAoKLS0gCkp1bGllbiBHcmFsbAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==