From: Yi Sun <yi.y.sun@linux.intel.com>
To: xen-devel@lists.xenproject.org
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
ian.jackson@eu.citrix.com, Yi Sun <yi.y.sun@linux.intel.com>,
mengxu@cis.upenn.edu, jbeulich@suse.com,
chao.p.peng@linux.intel.com, roger.pau@citrix.com
Subject: [PATCH v14 19/23] x86: L2 CAT: implement set value flow.
Date: Sat, 15 Jul 2017 08:31:52 +0800 [thread overview]
Message-ID: <1500078716-5928-20-git-send-email-yi.y.sun@linux.intel.com> (raw)
In-Reply-To: <1500078716-5928-1-git-send-email-yi.y.sun@linux.intel.com>
This patch implements L2 CAT set value related callback function
and domctl interface.
Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
v11:
- remove 'domctl->u.psr_cat_op.data' check because it has been moved into
'psr_set_val'.
(suggested by Jan Beulich)
- move 'feat->cos_reg_val' assignment and value comparison in 'write_msr'
callback function out as generic codes.
(suggested by Jan Beulich)
v10:
- check input data and remove cast in domctl.
(suggested by Jan Beulich)
- remove some hooks assignment due to previous patches changes.
(suggested by Jan Beulich)
- remove cast in 'l2_cat_write_msr'.
(suggested by Jan Beulich)
- remove 'return in 'l2_cat_write_msr'.
(suggested by Jan Beulich)
v9:
- reuse some CAT common functions for L2 CAT to reduce redundant codes.
(suggested by Roger Pau)
- remove parameter 'found' from 'cat_compare_val' and modify the return
values to let caller know if the id is found or not. These things are
done in patch "x86: refactor psr: set value: implement cos finding flow."
(suggested by Roger Pau and Dario Faggioli)
- remove 'get_cos_num' related codes.
(suggested by Jan Beulich)
- modify 'l2_cat_write_msr' according to previous patch change.
- changes about 'uint64_t' to 'uint32_t'.
(suggested by Jan Beulich)
v8:
- modify 'l2_cat_write_msr' to 'void'.
v5:
- remove type check in callback function.
(suggested by Jan Beulich)
- modify return value of callback functions because we do not need them
to return number of entries the feature uses. In caller, we call
'get_cos_num' to get the number of entries the feature uses.
(suggested by Jan Beulich)
- remove 'l2_cat_get_cos_max_from_type'.
(suggested by Jan Beulich)
- rename 'l2_cat_exceeds_cos_max' to 'l2_cat_fits_cos_max'.
(suggested by Jan Beulich)
v4:
- create this patch because of codes architecture change.
(suggested by Jan Beulich)
---
xen/arch/x86/domctl.c | 6 ++++++
xen/arch/x86/psr.c | 1 +
xen/include/public/domctl.h | 1 +
3 files changed, 8 insertions(+)
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 7b58053..e5e0df4 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -1439,6 +1439,12 @@ long arch_do_domctl(
PSR_CBM_TYPE_L3_DATA);
break;
+ case XEN_DOMCTL_PSR_CAT_OP_SET_L2_CBM:
+ ret = psr_set_val(d, domctl->u.psr_cat_op.target,
+ domctl->u.psr_cat_op.data,
+ PSR_CBM_TYPE_L2);
+ break;
+
case XEN_DOMCTL_PSR_CAT_OP_GET_L3_CBM:
ret = psr_get_val(d, domctl->u.psr_cat_op.target,
&val32, PSR_CBM_TYPE_L3);
diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index 1b1a36b..ab87004 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -408,6 +408,7 @@ static const struct feat_props l3_cdp_props = {
/* L2 CAT props */
static void l2_cat_write_msr(unsigned int cos, uint32_t val, enum cbm_type type)
{
+ wrmsrl(MSR_IA32_PSR_L2_MASK(cos), val);
}
static const struct feat_props l2_cat_props = {
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 61d44cd..0669c31 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -1142,6 +1142,7 @@ struct xen_domctl_psr_cat_op {
#define XEN_DOMCTL_PSR_CAT_OP_SET_L3_DATA 3
#define XEN_DOMCTL_PSR_CAT_OP_GET_L3_CODE 4
#define XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA 5
+#define XEN_DOMCTL_PSR_CAT_OP_SET_L2_CBM 6
#define XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM 7
uint32_t cmd; /* IN: XEN_DOMCTL_PSR_CAT_OP_* */
uint32_t target; /* IN */
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-15 0:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 0:31 [PATCH v14 00/23] Enable L2 Cache Allocation Technology & Refactor psr.c Yi Sun
2017-07-15 0:31 ` [PATCH v14 01/23] docs: create Cache Allocation Technology (CAT) and Code and Data Prioritization (CDP) feature document Yi Sun
2017-07-15 0:31 ` [PATCH v14 02/23] x86: move cpuid_count_leaf from cpuid.c to processor.h Yi Sun
2017-07-15 0:31 ` [PATCH v14 03/23] x86: refactor psr: remove L3 CAT/CDP codes Yi Sun
2017-07-15 0:31 ` [PATCH v14 04/23] x86: refactor psr: L3 CAT: implement main data structures, CPU init and free flows Yi Sun
2017-07-15 0:31 ` [PATCH v14 05/23] x86: refactor psr: L3 CAT: implement Domain init/free and schedule flows Yi Sun
2017-07-15 0:31 ` [PATCH v14 06/23] x86: refactor psr: L3 CAT: implement get hw info flow Yi Sun
2017-07-15 0:31 ` [PATCH v14 07/23] x86: refactor psr: L3 CAT: implement get value flow Yi Sun
2017-07-15 0:31 ` [PATCH v14 08/23] x86: refactor psr: L3 CAT: set value: implement framework Yi Sun
2017-07-15 0:31 ` [PATCH v14 09/23] x86: refactor psr: L3 CAT: set value: assemble features value array Yi Sun
2017-07-31 14:10 ` Jan Beulich
2017-07-15 0:31 ` [PATCH v14 10/23] x86: refactor psr: L3 CAT: set value: implement cos finding flow Yi Sun
2017-07-15 0:31 ` [PATCH v14 11/23] x86: refactor psr: L3 CAT: set value: implement cos id picking flow Yi Sun
2017-07-15 0:31 ` [PATCH v14 12/23] x86: refactor psr: L3 CAT: set value: implement write msr flow Yi Sun
2017-07-31 14:14 ` Jan Beulich
2017-07-15 0:31 ` [PATCH v14 13/23] x86: refactor psr: CDP: implement CPU init flow Yi Sun
2017-07-31 14:20 ` Jan Beulich
2017-08-01 0:44 ` Yi Sun
2017-07-15 0:31 ` [PATCH v14 14/23] x86: refactor psr: CDP: implement get hw info flow Yi Sun
2017-07-15 0:31 ` [PATCH v14 15/23] x86: refactor psr: CDP: implement set value callback function Yi Sun
2017-07-15 0:31 ` [PATCH v14 16/23] x86: L2 CAT: implement CPU init flow Yi Sun
2017-07-31 14:24 ` Jan Beulich
2017-07-15 0:31 ` [PATCH v14 17/23] x86: L2 CAT: implement get hw info flow Yi Sun
2017-07-15 0:31 ` [PATCH v14 18/23] x86: L2 CAT: implement get value flow Yi Sun
2017-07-15 0:31 ` Yi Sun [this message]
2017-07-15 0:31 ` [PATCH v14 20/23] tools: L2 CAT: support get HW info for L2 CAT Yi Sun
2017-07-15 0:31 ` [PATCH v14 21/23] tools: L2 CAT: support show cbm " Yi Sun
2017-07-15 0:31 ` [PATCH v14 22/23] tools: L2 CAT: support set " Yi Sun
2017-07-15 0:31 ` [PATCH v14 23/23] docs: add L2 CAT description in docs Yi Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500078716-5928-20-git-send-email-yi.y.sun@linux.intel.com \
--to=yi.y.sun@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=mengxu@cis.upenn.edu \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).