xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 09/25 v6] xen/arm: vpl011: Rename the console structure field conspath to xspath
Date: Mon, 17 Jul 2017 18:36:39 +0530	[thread overview]
Message-ID: <1500296815-10243-10-git-send-email-bhupinder.thakur@linaro.org> (raw)
In-Reply-To: <1500296815-10243-1-git-send-email-bhupinder.thakur@linaro.org>

The console->conspath name is changed to console->xspath as it is
clear from the name that it is referring to xenstore path.

Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Wei Liu <wei.liu2@citrix.com>
---
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>

Changes since v4:
- Split this change in a separate patch.

 tools/console/daemon/io.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c
index 30cd167..6f5c69c 100644
--- a/tools/console/daemon/io.c
+++ b/tools/console/daemon/io.c
@@ -95,7 +95,7 @@ struct console {
 	int slave_fd;
 	int log_fd;
 	struct buffer buffer;
-	char *conspath;
+	char *xspath;
 	int ring_ref;
 	xenevtchn_handle *xce_handle;
 	int xce_pollfd_idx;
@@ -463,7 +463,7 @@ static int domain_create_tty(struct domain *dom)
 		goto out;
 	}
 
-	success = asprintf(&path, "%s/limit", con->conspath) !=
+	success = asprintf(&path, "%s/limit", con->xspath) !=
 		-1;
 	if (!success)
 		goto out;
@@ -474,7 +474,7 @@ static int domain_create_tty(struct domain *dom)
 	}
 	free(path);
 
-	success = (asprintf(&path, "%s/tty", con->conspath) != -1);
+	success = (asprintf(&path, "%s/tty", con->xspath) != -1);
 	if (!success)
 		goto out;
 	success = xs_write(xs, XBT_NULL, path, slave, strlen(slave));
@@ -546,14 +546,14 @@ static int domain_create_ring(struct domain *dom)
 	char *type, path[PATH_MAX];
 	struct console *con = &dom->console;
 
-	err = xs_gather(xs, con->conspath,
+	err = xs_gather(xs, con->xspath,
 			"ring-ref", "%u", &ring_ref,
 			"port", "%i", &remote_port,
 			NULL);
 	if (err)
 		goto out;
 
-	snprintf(path, sizeof(path), "%s/type", con->conspath);
+	snprintf(path, sizeof(path), "%s/type", con->xspath);
 	type = xs_read(xs, XBT_NULL, path, NULL);
 	if (type && strcmp(type, "xenconsoled") != 0) {
 		free(type);
@@ -646,13 +646,13 @@ static bool watch_domain(struct domain *dom, bool watch)
 
 	snprintf(domid_str, sizeof(domid_str), "dom%u", dom->domid);
 	if (watch) {
-		success = xs_watch(xs, con->conspath, domid_str);
+		success = xs_watch(xs, con->xspath, domid_str);
 		if (success)
 			domain_create_ring(dom);
 		else
-			xs_unwatch(xs, con->conspath, domid_str);
+			xs_unwatch(xs, con->xspath, domid_str);
 	} else {
-		success = xs_unwatch(xs, con->conspath, domid_str);
+		success = xs_unwatch(xs, con->xspath, domid_str);
 	}
 
 	return success;
@@ -682,13 +682,13 @@ static struct domain *create_domain(int domid)
 	dom->domid = domid;
 
 	con = &dom->console;
-	con->conspath = xs_get_domain_path(xs, dom->domid);
-	s = realloc(con->conspath, strlen(con->conspath) +
+	con->xspath = xs_get_domain_path(xs, dom->domid);
+	s = realloc(con->xspath, strlen(con->xspath) +
 		    strlen("/console") + 1);
 	if (s == NULL)
 		goto out;
-	con->conspath = s;
-	strcat(con->conspath, "/console");
+	con->xspath = s;
+	strcat(con->xspath, "/console");
 
 	con->master_fd = -1;
 	con->master_pollfd_idx = -1;
@@ -712,7 +712,7 @@ static struct domain *create_domain(int domid)
 
 	return dom;
  out:
-	free(con->conspath);
+	free(con->xspath);
 	free(dom);
 	return NULL;
 }
@@ -756,8 +756,8 @@ static void cleanup_domain(struct domain *d)
 	free(con->buffer.data);
 	con->buffer.data = NULL;
 
-	free(con->conspath);
-	con->conspath = NULL;
+	free(con->xspath);
+	con->xspath = NULL;
 
 	remove_domain(d);
 }
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-07-17 13:07 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 13:06 [PATCH 00/25 v6] SBSA UART emulation support in Xen Bhupinder Thakur
2017-07-17 13:06 ` [PATCH 01/25 v6] xen/arm: vpl011: Define common ring buffer helper functions in console.h Bhupinder Thakur
2017-07-17 13:06 ` [PATCH 02/25 v6] xen/arm: vpl011: Add SBSA UART emulation in Xen Bhupinder Thakur
2017-07-17 16:39   ` Julien Grall
2017-07-18 19:35   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 03/25 v6] xen/arm: vpl011: Allocate a new GFN in the toolstack for vuart Bhupinder Thakur
2017-07-17 13:06 ` [PATCH 04/25 v6] xen/arm: vpl011: Add support for vuart in libxl Bhupinder Thakur
2017-07-18 11:19   ` Julien Grall
2017-07-18 11:30     ` Wei Liu
2017-07-25 17:38       ` Bhupinder Thakur
2017-07-28 13:49         ` Wei Liu
2017-07-28 14:14           ` Julien Grall
2017-07-28 14:42             ` Wei Liu
2017-07-28 14:46               ` Julien Grall
2017-07-17 13:06 ` [PATCH 05/25 v6] xen/arm: vpl011: Rearrange xen header includes in alphabetical order in domctl.c Bhupinder Thakur
2017-07-17 16:42   ` Julien Grall
2017-07-17 13:06 ` [PATCH 06/25 v6] xen/arm: vpl011: Add a new domctl API to initialize vpl011 Bhupinder Thakur
2017-07-17 17:03   ` Julien Grall
2017-07-18 19:42   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 07/25 v6] xen/arm: vpl011: Add a new vuart node in the xenstore Bhupinder Thakur
2017-07-17 13:06 ` [PATCH 08/25 v6] xen/arm: vpl011: Modify xenconsole to define and use a new console structure Bhupinder Thakur
2017-07-17 13:06 ` Bhupinder Thakur [this message]
2017-07-17 13:06 ` [PATCH 10/25 v6] xen/arm: vpl011: Modify xenconsole functions to take console structure as input Bhupinder Thakur
2017-07-17 13:06 ` [PATCH 11/25 v6] xen/arm: vpl011: Add a new console_init function in xenconsole Bhupinder Thakur
2017-07-18 11:40   ` Wei Liu
2017-08-07  5:32     ` Bhupinder Thakur
2017-07-17 13:06 ` [PATCH 12/25 v6] xen/arm: vpl011: Add a new buffer_available " Bhupinder Thakur
2017-07-18 11:40   ` Wei Liu
2017-07-18 19:47   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 13/25 v6] xen/arm: vpl011: Add a new add_console_evtchn_fd " Bhupinder Thakur
2017-07-18 11:52   ` Wei Liu
2017-07-20 13:55     ` Bhupinder Thakur
2017-07-17 13:06 ` [PATCH 14/25 v6] xen/arm: vpl011: Add a new add_console_tty_fd " Bhupinder Thakur
2017-07-18 11:52   ` Wei Liu
2017-07-18 19:48   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 15/25 v6] xen/arm: vpl011: Add a new console_evtchn_unmask " Bhupinder Thakur
2017-07-18 11:57   ` Wei Liu
2017-07-17 13:06 ` [PATCH 16/25 v6] xen/arm: vpl011: Add a new handle_console_ring " Bhupinder Thakur
2017-07-18 13:12   ` Wei Liu
2017-07-18 19:51   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 17/25 v6] xen/arm: vpl011: Add a new handle_console_tty " Bhupinder Thakur
2017-07-18 13:13   ` Wei Liu
2017-07-18 19:51   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 18/25 v6] xen/arm: vpl011: Add a new console_cleanup " Bhupinder Thakur
2017-07-18 13:14   ` Wei Liu
2017-07-18 19:54   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 19/25 v6] xen/arm: vpl011: Add a new console_open_log " Bhupinder Thakur
2017-07-18 19:55   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 20/25 v6] xen/arm: vpl011: Add a new console_close_evtchn " Bhupinder Thakur
2017-07-18 13:14   ` Wei Liu
2017-07-18 19:56   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 21/25 v6] xen/arm: vpl011: Add support for multiple consoles " Bhupinder Thakur
2017-07-18 13:24   ` Wei Liu
2017-07-18 20:01   ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console " Bhupinder Thakur
2017-07-18 13:27   ` Wei Liu
2017-07-18 20:07   ` Stefano Stabellini
2017-07-21  6:02     ` Bhupinder Thakur
2017-07-21  9:51     ` Julien Grall
2017-07-21 19:44       ` Stefano Stabellini
2017-07-25  9:06         ` Bhupinder Thakur
2017-07-25 17:44           ` Stefano Stabellini
2017-07-25 12:29         ` Julien Grall
2017-07-25 17:39           ` Stefano Stabellini
2017-07-17 13:06 ` [PATCH 23/25 v6] xen/arm: vpl011: Add a new vuart console type to xenconsole client Bhupinder Thakur
2017-07-17 13:06 ` [PATCH 24/25 v6] xen/arm: vpl011: Add a pl011 uart DT node in the guest device tree Bhupinder Thakur
2017-07-18 11:04   ` Julien Grall
2017-07-21  6:35     ` Bhupinder Thakur
2017-07-17 13:06 ` [PATCH 25/25 v6] xen/arm: vpl011: Update documentation for vuart console support Bhupinder Thakur
2017-07-18 11:11   ` Julien Grall
2017-07-19 15:27 ` [PATCH 00/25 v6] SBSA UART emulation support in Xen Julien Grall
2017-07-20  9:40   ` Bhupinder Thakur
2017-07-20 10:04     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500296815-10243-10-git-send-email-bhupinder.thakur@linaro.org \
    --to=bhupinder.thakur@linaro.org \
    --cc=ian.jackson@eu.citrix.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).