From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: [PATCH v2 04/13] xen/arm: p2m: Update IOMMU mapping whenever possible if page table is not shared
Date: Tue, 25 Jul 2017 20:26:46 +0300 [thread overview]
Message-ID: <1501003615-15274-5-git-send-email-olekstysh@gmail.com> (raw)
In-Reply-To: <1501003615-15274-1-git-send-email-olekstysh@gmail.com>
From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Update IOMMU mapping if the IOMMU doesn't share page table with the CPU.
The best place to do so on ARM is __p2m_set_entry(). Use mfn as an indicator
of the required action. If mfn is valid call iommu_map_pages(),
otherwise - iommu_unmap_pages().
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Acked-by: Julien Grall <julien.grall@arm.com>
---
Changes in v1:
- Update IOMMU mapping in __p2m_set_entry() instead of p2m_set_entry().
- Pass order argument to IOMMU APIs instead of page_count.
Changes in v2:
- Add Julien's acked-by
---
xen/arch/arm/p2m.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index fc2a106..729ed94 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -984,7 +984,15 @@ static int __p2m_set_entry(struct p2m_domain *p2m,
p2m_free_entry(p2m, orig_pte, level);
if ( need_iommu(p2m->domain) && (p2m_valid(orig_pte) || p2m_valid(*entry)) )
- rc = iommu_iotlb_flush(p2m->domain, gfn_x(sgfn), 1UL << page_order);
+ {
+ if ( iommu_use_hap_pt(p2m->domain) )
+ rc = iommu_iotlb_flush(p2m->domain, gfn_x(sgfn), 1UL << page_order);
+ else if ( !mfn_eq(smfn, INVALID_MFN) )
+ rc = iommu_map_pages(p2m->domain, gfn_x(sgfn), mfn_x(smfn),
+ page_order, p2m_get_iommu_flags(t));
+ else
+ rc = iommu_unmap_pages(p2m->domain, gfn_x(sgfn), page_order);
+ }
else
rc = 0;
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-25 17:27 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 17:26 [PATCH v2 00/13] "Non-shared" IOMMU support on ARM Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 01/13] xen/device-tree: Add dt_count_phandle_with_args helper Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 02/13] iommu: Add extra order argument to the IOMMU APIs and platform callbacks Oleksandr Tyshchenko
2017-08-03 11:21 ` Julien Grall
2017-08-03 12:32 ` Oleksandr Tyshchenko
2017-08-21 16:20 ` Oleksandr Tyshchenko
2017-08-22 7:21 ` Jan Beulich
2017-08-22 10:28 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 03/13] xen/arm: p2m: Add helper to convert p2m type to IOMMU flags Oleksandr Tyshchenko
2017-07-25 17:26 ` Oleksandr Tyshchenko [this message]
2017-07-25 17:26 ` [PATCH v2 05/13] iommu/arm: Re-define iommu_use_hap_pt(d) as iommu_hap_pt_share Oleksandr Tyshchenko
2017-08-03 11:23 ` Julien Grall
2017-08-03 12:33 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 06/13] iommu: Add extra use_iommu argument to iommu_domain_init() Oleksandr Tyshchenko
2017-08-21 16:29 ` Oleksandr Tyshchenko
2017-12-06 16:51 ` Jan Beulich
2017-12-06 19:53 ` Oleksandr Tyshchenko
2017-12-06 22:49 ` Julien Grall
2017-12-07 12:08 ` Oleksandr Tyshchenko
2017-12-07 12:51 ` Jan Beulich
2017-07-25 17:26 ` [PATCH v2 07/13] iommu: Make decision about needing IOMMU for hardware domains in advance Oleksandr Tyshchenko
2017-08-21 16:30 ` Oleksandr Tyshchenko
2017-12-06 17:01 ` Jan Beulich
2017-12-06 19:23 ` Oleksandr Tyshchenko
2017-12-07 8:57 ` Jan Beulich
2017-12-07 13:50 ` Oleksandr Tyshchenko
2017-12-07 13:57 ` Jan Beulich
2017-12-08 12:28 ` Oleksandr Tyshchenko
2018-01-18 12:09 ` Roger Pau Monné
2018-01-18 14:50 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 08/13] iommu/arm: Misc fixes for arch specific part Oleksandr Tyshchenko
2017-08-03 11:31 ` Julien Grall
2017-08-03 12:34 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 09/13] xen/arm: Add use_iommu flag to xen_arch_domainconfig Oleksandr Tyshchenko
2017-07-28 16:16 ` Wei Liu
2017-07-28 16:30 ` Oleksandr Tyshchenko
2017-08-03 11:33 ` Julien Grall
2017-08-03 12:31 ` Oleksandr Tyshchenko
2017-08-03 12:35 ` Julien Grall
2017-07-25 17:26 ` [PATCH v2 10/13] xen/arm: domain_build: Don't expose IOMMU specific properties to the guest Oleksandr Tyshchenko
2017-08-03 11:37 ` Julien Grall
2017-08-03 13:24 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 11/13] iommu/arm: smmu: Squash map_pages/unmap_pages with map_page/unmap_page Oleksandr Tyshchenko
2017-08-03 12:36 ` Julien Grall
2017-08-03 13:26 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 12/13] [RFC] iommu: VT-d: " Oleksandr Tyshchenko
2017-08-21 16:44 ` Oleksandr Tyshchenko
2017-09-12 14:44 ` Oleksandr Tyshchenko
2017-09-20 8:54 ` Tian, Kevin
2017-09-20 18:23 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 13/13] [RFC] iommu: AMD-Vi: " Oleksandr Tyshchenko
2017-08-21 16:44 ` Oleksandr Tyshchenko
2017-09-12 14:45 ` Oleksandr Tyshchenko
2017-07-31 5:57 ` [PATCH v2 00/13] "Non-shared" IOMMU support on ARM Tian, Kevin
2017-07-31 11:57 ` Oleksandr Tyshchenko
2017-08-01 3:06 ` Tian, Kevin
2017-08-01 11:08 ` Oleksandr Tyshchenko
2017-08-02 6:12 ` Tian, Kevin
2017-08-02 17:47 ` Oleksandr Tyshchenko
2017-08-01 18:09 ` Julien Grall
2017-08-01 18:20 ` Oleksandr Tyshchenko
2017-08-01 17:56 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501003615-15274-5-git-send-email-olekstysh@gmail.com \
--to=olekstysh@gmail.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).