From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xen.org
Cc: jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>,
boris.ostrovsky@oracle.com, sstabellini@kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 05/13] xen/pvcalls: implement connect command
Date: Mon, 31 Jul 2017 15:57:27 -0700 [thread overview]
Message-ID: <1501541855-7354-5-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1501541855-7354-1-git-send-email-sstabellini@kernel.org>
Send PVCALLS_CONNECT to the backend. Allocate a new ring and evtchn for
the active socket.
Introduce fields in struct sock_mapping to keep track of active sockets.
Introduce a waitqueue to allow the frontend to wait on data coming from
the backend on the active socket (recvmsg command).
Two mutexes (one of reads and one for writes) will be used to protect
the active socket in and out rings from concurrent accesses.
Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
---
drivers/xen/pvcalls-front.c | 146 ++++++++++++++++++++++++++++++++++++++++++++
drivers/xen/pvcalls-front.h | 2 +
2 files changed, 148 insertions(+)
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 7c4a7cb..379b8fb 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -13,6 +13,10 @@
*/
#include <linux/module.h>
+#include <linux/net.h>
+#include <linux/socket.h>
+
+#include <net/sock.h>
#include <xen/events.h>
#include <xen/grant_table.h>
@@ -44,6 +48,18 @@ struct sock_mapping {
bool active_socket;
struct list_head list;
struct socket *sock;
+ union {
+ struct {
+ int irq;
+ grant_ref_t ref;
+ struct pvcalls_data_intf *ring;
+ struct pvcalls_data data;
+ struct mutex in_mutex;
+ struct mutex out_mutex;
+
+ wait_queue_head_t inflight_conn_req;
+ } active;
+ };
};
static inline int get_request(struct pvcalls_bedata *bedata, int *req_id)
@@ -97,6 +113,18 @@ static irqreturn_t pvcalls_front_event_handler(int irq, void *dev_id)
return IRQ_HANDLED;
}
+static irqreturn_t pvcalls_front_conn_handler(int irq, void *sock_map)
+{
+ struct sock_mapping *map = sock_map;
+
+ if (map == NULL)
+ return IRQ_HANDLED;
+
+ wake_up_interruptible(&map->active.inflight_conn_req);
+
+ return IRQ_HANDLED;
+}
+
int pvcalls_front_socket(struct socket *sock)
{
struct pvcalls_bedata *bedata;
@@ -162,6 +190,124 @@ int pvcalls_front_socket(struct socket *sock)
return ret;
}
+static int create_active(struct sock_mapping *map, int *evtchn)
+{
+ void *bytes;
+ int ret = -ENOMEM, irq = -1, i;
+
+ init_waitqueue_head(&map->active.inflight_conn_req);
+
+ map->active.ring = (struct pvcalls_data_intf *)
+ __get_free_page(GFP_KERNEL | __GFP_ZERO);
+ if (map->active.ring == NULL)
+ goto out_error;
+ memset(map->active.ring, 0, XEN_PAGE_SIZE);
+ map->active.ring->ring_order = PVCALLS_RING_ORDER;
+ bytes = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO,
+ map->active.ring->ring_order);
+ if (bytes == NULL)
+ goto out_error;
+ for (i = 0; i < (1 << map->active.ring->ring_order); i++)
+ map->active.ring->ref[i] = gnttab_grant_foreign_access(
+ pvcalls_front_dev->otherend_id,
+ pfn_to_gfn(virt_to_pfn(bytes) + i), 0);
+
+ map->active.ref = gnttab_grant_foreign_access(
+ pvcalls_front_dev->otherend_id,
+ pfn_to_gfn(virt_to_pfn((void *)map->active.ring)), 0);
+
+ map->active.data.in = bytes;
+ map->active.data.out = bytes +
+ XEN_FLEX_RING_SIZE(map->active.ring->ring_order);
+
+ ret = xenbus_alloc_evtchn(pvcalls_front_dev, evtchn);
+ if (ret)
+ goto out_error;
+ irq = bind_evtchn_to_irqhandler(*evtchn, pvcalls_front_conn_handler,
+ 0, "pvcalls-frontend", map);
+ if (irq < 0) {
+ ret = irq;
+ goto out_error;
+ }
+
+ map->active.irq = irq;
+ map->active_socket = true;
+ mutex_init(&map->active.in_mutex);
+ mutex_init(&map->active.out_mutex);
+
+ return 0;
+
+out_error:
+ if (irq >= 0)
+ unbind_from_irqhandler(irq, map);
+ else if (*evtchn >= 0)
+ xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
+ kfree(map->active.data.in);
+ kfree(map->active.ring);
+ kfree(map);
+ return ret;
+}
+
+int pvcalls_front_connect(struct socket *sock, struct sockaddr *addr,
+ int addr_len, int flags)
+{
+ struct pvcalls_bedata *bedata;
+ struct sock_mapping *map = NULL;
+ struct xen_pvcalls_request *req;
+ int notify, req_id, ret, evtchn;
+
+ if (!pvcalls_front_dev)
+ return -ENETUNREACH;
+ if (addr->sa_family != AF_INET || sock->type != SOCK_STREAM)
+ return -ENOTSUPP;
+
+ bedata = dev_get_drvdata(&pvcalls_front_dev->dev);
+
+ map = (struct sock_mapping *) READ_ONCE(sock->sk->sk_send_head);
+ if (!map)
+ return -EINVAL;
+
+ spin_lock(&bedata->pvcallss_lock);
+ ret = get_request(bedata, &req_id);
+ if (ret < 0) {
+ spin_unlock(&bedata->pvcallss_lock);
+ return ret;
+ }
+ ret = create_active(map, &evtchn);
+ if (ret < 0) {
+ spin_unlock(&bedata->pvcallss_lock);
+ return ret;
+ }
+
+ req = RING_GET_REQUEST(&bedata->ring, req_id);
+ req->req_id = req_id;
+ req->cmd = PVCALLS_CONNECT;
+ req->u.connect.id = (uint64_t)map;
+ memcpy(req->u.connect.addr, addr, sizeof(*addr));
+ req->u.connect.len = addr_len;
+ req->u.connect.flags = flags;
+ req->u.connect.ref = map->active.ref;
+ req->u.connect.evtchn = evtchn;
+
+ map->sock = sock;
+
+ bedata->ring.req_prod_pvt++;
+ RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&bedata->ring, notify);
+ spin_unlock(&bedata->pvcallss_lock);
+
+ if (notify)
+ notify_remote_via_irq(bedata->irq);
+
+ wait_event(bedata->inflight_req,
+ READ_ONCE(bedata->rsp[req_id].req_id) == req_id);
+
+ ret = bedata->rsp[req_id].ret;
+ /* read ret, then set this rsp slot to be reused */
+ smp_mb();
+ WRITE_ONCE(bedata->rsp[req_id].req_id, PVCALLS_INVALID_ID);
+ return ret;
+}
+
static const struct xenbus_device_id pvcalls_front_ids[] = {
{ "pvcalls" },
{ "" }
diff --git a/drivers/xen/pvcalls-front.h b/drivers/xen/pvcalls-front.h
index b7dabed..63b0417 100644
--- a/drivers/xen/pvcalls-front.h
+++ b/drivers/xen/pvcalls-front.h
@@ -4,5 +4,7 @@
#include <linux/net.h>
int pvcalls_front_socket(struct socket *sock);
+int pvcalls_front_connect(struct socket *sock, struct sockaddr *addr,
+ int addr_len, int flags);
#endif
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-31 22:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.10.1707311536460.22381@sstabellini-ThinkPad-X260>
2017-07-31 22:57 ` [PATCH v3 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 02/13] xen/pvcalls: implement frontend disconnect Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 03/13] xen/pvcalls: connect to the backend Stefano Stabellini
2017-08-11 22:55 ` Boris Ostrovsky
[not found] ` <4fbe7300-8934-ed6b-3868-443ae96c2ecb@oracle.com>
2017-09-09 0:14 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 04/13] xen/pvcalls: implement socket command and handle events Stefano Stabellini
2017-08-13 0:42 ` Boris Ostrovsky
[not found] ` <bac44a61-e6d2-72fe-a8b4-5dec0e23186f@oracle.com>
2017-09-08 23:20 ` Stefano Stabellini
2017-07-31 22:57 ` Stefano Stabellini [this message]
2017-08-13 1:12 ` [PATCH v3 05/13] xen/pvcalls: implement connect command Boris Ostrovsky
[not found] ` <98a37ce0-468c-0938-a56d-31bbde177c91@oracle.com>
2017-09-08 21:23 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 06/13] xen/pvcalls: implement bind command Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 07/13] xen/pvcalls: implement listen command Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 08/13] xen/pvcalls: implement accept command Stefano Stabellini
2017-08-15 2:00 ` Boris Ostrovsky
[not found] ` <1a368546-fec3-7f10-cc1b-296e095c9ba1@oracle.com>
2017-08-15 2:04 ` Boris Ostrovsky
[not found] ` <37d72529-c8d4-96e1-422c-342a19af9055@oracle.com>
2017-09-08 21:58 ` Stefano Stabellini
2017-09-08 22:16 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 09/13] xen/pvcalls: implement sendmsg Stefano Stabellini
2017-08-15 2:31 ` Boris Ostrovsky
2017-09-08 23:48 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 10/13] xen/pvcalls: implement recvmsg Stefano Stabellini
2017-08-15 2:39 ` Boris Ostrovsky
2017-09-08 23:11 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 11/13] xen/pvcalls: implement poll command Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 12/13] xen/pvcalls: implement release command Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend Stefano Stabellini
2017-08-11 22:36 ` [PATCH v3 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Boris Ostrovsky
[not found] ` <1501541855-7354-2-git-send-email-sstabellini@kernel.org>
2017-08-11 22:43 ` [PATCH v3 02/13] xen/pvcalls: implement frontend disconnect Boris Ostrovsky
2017-09-09 0:07 ` Stefano Stabellini
[not found] ` <1501541855-7354-6-git-send-email-sstabellini@kernel.org>
2017-08-13 1:22 ` [PATCH v3 06/13] xen/pvcalls: implement bind command Boris Ostrovsky
[not found] ` <3591ec0c-1556-dd20-1cc9-092eb1792c42@oracle.com>
2017-09-08 21:46 ` Stefano Stabellini
[not found] ` <1501541855-7354-7-git-send-email-sstabellini@kernel.org>
2017-08-13 1:28 ` [PATCH v3 07/13] xen/pvcalls: implement listen command Boris Ostrovsky
[not found] ` <1501541855-7354-11-git-send-email-sstabellini@kernel.org>
2017-08-15 20:30 ` [PATCH v3 11/13] xen/pvcalls: implement poll command Boris Ostrovsky
[not found] ` <702cfa9c-5f14-07a3-63ba-93648ff66d9b@oracle.com>
2017-09-08 23:03 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.10.1709081540330.19719@sstabellini-ThinkPad-X260>
2017-09-12 14:14 ` Boris Ostrovsky
[not found] ` <6c9613d8-8219-d06f-9095-fa57474ed518@oracle.com>
2017-09-12 22:17 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.10.1709121502210.9439@sstabellini-ThinkPad-X260>
2017-09-12 23:04 ` Boris Ostrovsky
[not found] ` <73a6ae0f-077c-9d42-fd56-0738ccb30cec@oracle.com>
2017-09-12 23:13 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.10.1709121610250.9439@sstabellini-ThinkPad-X260>
2017-09-12 23:18 ` Stefano Stabellini
[not found] ` <1501541855-7354-12-git-send-email-sstabellini@kernel.org>
2017-08-15 20:44 ` [PATCH v3 12/13] xen/pvcalls: implement release command Boris Ostrovsky
[not found] ` <2fd1b3f3-28aa-1958-7522-766c7d92e8d3@oracle.com>
2017-09-08 23:09 ` Stefano Stabellini
2017-08-10 15:07 ` [PATCH v3 00/13] introduce the Xen PV Calls frontend Boris Ostrovsky
[not found] ` <bbff3e92-e71a-f685-bae1-59521e6f2f99@oracle.com>
2017-08-10 18:15 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501541855-7354-5-git-send-email-sstabellini@kernel.org \
--to=sstabellini@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).