From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v1 1/3] xen:rtds: enable XL to set and get vcpu work conserving flag Date: Thu, 3 Aug 2017 17:47:10 +0200 Message-ID: <1501775230.28477.8.camel@citrix.com> References: <1501612434-5803-1-git-send-email-mengxu@cis.upenn.edu> <1501612434-5803-2-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0175147779018196179==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddILI-00022K-T8 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2017 15:47:21 +0000 In-Reply-To: <1501612434-5803-2-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu , xen-devel@lists.xenproject.org Cc: george.dunlap@eu.citrix.com, wei.liu2@citrix.com, xumengpanda@gmail.com, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============0175147779018196179== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Ojsbe2t2SPuxRK21FsA5" --=-Ojsbe2t2SPuxRK21FsA5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-08-01 at 14:33 -0400, Meng Xu wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -360,6 +360,7 @@ typedef struct xen_domctl_sched_credit2 { > =C2=A0typedef struct xen_domctl_sched_rtds { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint32_t period; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint32_t budget; > +=C2=A0=C2=A0=C2=A0=C2=A0bool=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0is_work_conser= ving; > I wonder whether it wouldn't be better (e.g., more future proof) to have a 'uint32_T flags' field here too. That way, if/when, in future, we want to introduce some other way of tweaking the scheduler's behavior for this vCPU, we already have space for specifying it... Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Ojsbe2t2SPuxRK21FsA5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZg0V/AAoJEBZCeImluHPuZQ4P/3KgJwDDtNRXOx4squxLhwpQ b/BpQCLT6JbguVR5uFt9npfmvbmggUxUBq5QU0ZOW9DVZ66s64Ct6v3how/xazx4 ktbvmpNuXmWVbskPRhCs8UVwDYOmXODtvJYVkaDKvP4taW35hzIQefj+nM6Vctf3 Bucyg/KWfmQK2GhVx2/7mqkplh8kV13zlMbfeqCjncbwW8itmHEaU52F4RDi6aN7 Gf/rWRdi0LzJIAtbZjfi5Ji3zOeZic8i4hyJv5UUOBu+oT+jeJVMO+bLckYsUXqC xeagGE8/PYmkSUidt7AyfZDw29uOMI4/HJ2RRj6/fMBYASGc7KabeIFcTxBsYwh/ swElrg2Oirh1Yk+5ElAAeVR9aMEmd/fA5m54cqYOudOS7jWlvYGgSnPszjMuZ63Q 0H35IOx5MMCC5vcFI0hbfNpuxr5l8vYVVTVLWiaAtRVLwDBt6n55KOUkem3mlSCr C8vDQoda5aM9kloJxMEpYOUtwnorit2Kxtc/+F5LWAly3t2ZVOBp2pCZs8KvoKGr jEsUkqFBfaPAl0x6E9OSv0KzTPUoFJ3tifFE7e/7s4lmEvg8A5nI8HJZr7gjaCom R6UapUybrOUCvvvx7rluXKnHTacRM3HN38m79GoTJgwARHp9HX0ChwvJOoI7TzrI 8wyA8teZ8G3sNCHoiOwM =Q1np -----END PGP SIGNATURE----- --=-Ojsbe2t2SPuxRK21FsA5-- --===============0175147779018196179== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============0175147779018196179==--