From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v1 2/3] libxl: enable per-VCPU work conserving flag for RTDS Date: Thu, 3 Aug 2017 17:53:34 +0200 Message-ID: <1501775614.28477.10.camel@citrix.com> References: <1501612434-5803-1-git-send-email-mengxu@cis.upenn.edu> <1501612434-5803-3-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2253184133292178618==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddIRS-00031w-1T for xen-devel@lists.xenproject.org; Thu, 03 Aug 2017 15:53:42 +0000 In-Reply-To: <1501612434-5803-3-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu , xen-devel@lists.xenproject.org Cc: george.dunlap@eu.citrix.com, wei.liu2@citrix.com, xumengpanda@gmail.com, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============2253184133292178618== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Y87L5uu0i8I8BuQwuWsY" --=-Y87L5uu0i8I8BuQwuWsY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-08-01 at 14:33 -0400, Meng Xu wrote: > diff --git a/tools/libxl/libxl_types.idl > b/tools/libxl/libxl_types.idl > index 8a9849c..f6c3ead 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl > @@ -401,6 +401,7 @@ libxl_sched_params =3D Struct("sched_params",[ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0("period",=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0integer, {'init_val': > 'LIBXL_DOMAIN_SCHED_PARAM_PERIOD_DEFAULT'}), > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0("extratime",=C2=A0=C2=A0=C2=A0=C2=A0intege= r, {'init_val': > 'LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT'}), > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0("budget",=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0integer, {'init_val': > 'LIBXL_DOMAIN_SCHED_PARAM_BUDGET_DEFAULT'}), > +=C2=A0=C2=A0=C2=A0=C2=A0("is_work_conserving", integer, {'init_val': > 'LIBXL_DOMAIN_SCHED_PARAM_IS_WORK_CONSERVING_DEFAULT'}), > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0]) > =C2=A0 How about, here at libxl level, we use the "extratime" field that we have as a leftover from SEDF (and which had, in that scheduler, a similar meaning)? If we don't want to use that one, and we want a new field, I suggest thinking to a shorter name. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Y87L5uu0i8I8BuQwuWsY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZg0b+AAoJEBZCeImluHPulaEQAJMjbh8P5AM7HbyGVN6ZyeEk 7492qp9xGeRuFXL1k66fTM/ROUOgBse4cCfMXmj1QxG+i3+4geo6x8Ivq1n5myJ6 +qJIKUmf3v2puBaTUeRP2APnw7D84KXmyykDqbpw9b3P65FaxcedMz/XZ+Z43pH9 GtQ8dTFDD5oV87ZVd37pquTt6CwgOWdLSbr6PR+NOJlvvlZ/Y+RiCeuF+6rssDQE teUPgWHqBzKpEgzqxA+jxelyOtwBmVsYns69yYv8E6CuNqDp1b4EZx3n8PtJE863 3RrI8yZQATRG/M9LwKuG87TFr1N4CkaW/mwm0PuAIlsrS43HhEQ/b6+tL03FZwqF 9QSHZEtfwgGMe7i/ls5gkihgrTJu9y+1qboDGc0e8S9/HRTOp2HMP3xvt4YdEqcS sR/U8RGTXhWCRD4QnQdYiTFjlLRbRRZfRv5SL3ht/2Aqv7yx9fU4E7srAyEFoeRg 2C2iceoR95OfX2TQGpvfscRezqkTGLwsDoSrfEfdF9g0t4Kxva4XouWwIHX2v23V 3fUef5NyHdl9jJ0+r8xw2d8V/yk5z+ogmnIoIXVSBPy4mkR2nBvCCEvDvwJa4u79 cY4ulykSEs6h1GoVY8u+M5lhidpyK5XbuHW8tfuFNDzDEwnquhPS8Xxg9xeJuIt2 OqUPHMZ5MbpwIwNvEk+X =kdrQ -----END PGP SIGNATURE----- --=-Y87L5uu0i8I8BuQwuWsY-- --===============2253184133292178618== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============2253184133292178618==--