From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v1 1/3] xen:rtds: towards work conserving RTDS Date: Wed, 9 Aug 2017 00:52:13 +0200 Message-ID: <1502232733.5719.4.camel@citrix.com> References: <1502036563-4275-1-git-send-email-mengxu@cis.upenn.edu> <1502036563-4275-2-git-send-email-mengxu@cis.upenn.edu> <1502204233.18446.12.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5860263484059258506==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu Cc: TimDeegan , Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , "xen-devel@lists.xen.org" , Jan Beulich , Wei Liu List-Id: xen-devel@lists.xenproject.org --===============5860263484059258506== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Dc3pTip8uHB4yRlRPAcy" --=-Dc3pTip8uHB4yRlRPAcy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-08-08 at 12:06 -0700, Meng Xu wrote: > On Tue, Aug 8, 2017 at 10:57 AM, Dario Faggioli > wrote: > > On Sun, 2017-08-06 at 12:22 -0400, Meng Xu wrote: > > >=20 > > > diff --git a/xen/include/public/domctl.h > > > b/xen/include/public/domctl.h > > > index 0669c31..ba5daa9 100644 > > > --- a/xen/include/public/domctl.h > > > +++ b/xen/include/public/domctl.h > > > @@ -360,6 +360,9 @@ typedef struct xen_domctl_sched_credit2 { > > > =C2=A0typedef struct xen_domctl_sched_rtds { > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint32_t period; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint32_t budget; > > > +#define _XEN_DOMCTL_SCHED_RTDS_extratime 0 > > > +#define > > > XEN_DOMCTL_SCHED_RTDS_extratime=C2=A0=C2=A0(1U<<_XEN_DOMCTL_SCHED_RTD= S_extr > > > atim > > > e) > > > +=C2=A0=C2=A0=C2=A0=C2=A0uint32_t flags; > > >=20 > >=20 > > I'd add a one liner comment above the flag definition, as, for > > instance, how things are done in createdomain: >=20 > Sure. >=20 > How about comment: > /* Does this VCPU get extratime beyond reserved time? */ >=20 'Can this vCPU execute beyond its reserved amount of time?' > >=20 > > struct xen_domctl_createdomain { > > =C2=A0=C2=A0=C2=A0=C2=A0/* IN parameters */ > > =C2=A0=C2=A0=C2=A0=C2=A0uint32_t ssidref; > > =C2=A0=C2=A0=C2=A0=C2=A0xen_domain_handle_t handle; > > =C2=A0/* Is this an HVM guest (as opposed to a PVH or PV guest)? */ > > #define _XEN_DOMCTL_CDF_hvm_guest=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00 > > #define > > XEN_DOMCTL_CDF_hvm_guest=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(1U<<_XEN_D= OMCTL_CDF_hvm_guest) > > =C2=A0/* Use hardware-assisted paging if available? */ > > #define _XEN_DOMCTL_CDF_hap=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A01 > > #define XEN_DOMCTL_CDF_hap=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0(1U<<_XEN_DOMCTL_CDF_hap) > >=20 > > Also, consider shortening the name (e.g., by contracting the > > SCHED_RTDS > > part; it does not matter if it's not 100% equal to what's in > > sched_rt.c, I think). >=20 >=20 > How about shorten it to XEN_DOMCTL_RTDS_extra or > XEN_DOMCTL_RTDS_extratime? >=20 Personally, I'd go for XEN_DOMCTL_SCHEDRT_extra (or _extratime, or _extrat). Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Dc3pTip8uHB4yRlRPAcy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZikCdAAoJEBZCeImluHPuZ7oQAJBLheS2RQgQ52g5gvd4L1hL kEDLqMgsijcEuwBS+giALC8cjr6XDVJIF709JGltWE6cOrYqVpLlXzWOxGBBwLrD Zgd2LWOBfvNPbtE0myAmsa1ISJ9evPSLU1/qJOI3xlXJwfdR5OBgvHWpuZBydSfP xeYcz6eELLviiknuX+onYLrgXsPbO+cTt1E6FjHSTmQqaSMkTL952aSdNvSHBUd0 xPGL24kxzThgcBaFwJkuw53AP0MsmrsANoRi4/3Eb11/eanls5VLHmiTID4JgjBi eQ7MR3w/n3IvmX6XylRpM35w7Ak9wqa6ZYZm05XP6E+O0nqOeheHTVEChvUjmyTz Vd73l0Pd14oZVaJO87Eb1ud7DjkXotpCTJyomd7X5T4EKcwybHbQBVjIu2zGuZVd bugTFXGxcqOu4ZnYsHxuacNGz+Wcc0Ke3Sb/fQujERrz+YOosw89/O3DzDmPjIXN 3ArDqmMqa38mRGlvMmkDrGe9BtkaFfW1m1ZyJTRlLKlSO5VSdbxnSmdfjkVBE860 YDg9KQUMBxTSAfqwyVhrcC8Esr0uk0Vd+IMSwqTZQp4+xZupQLnBA35TfBW8KOe/ RmQw29cNz4N2DV4T3gDoy70I1Ryny2jUD2hc3RIBFboVudZXz/12D5ZLiXtLPw9W Gd35q59F2LWU2R8jbSUE =y+nW -----END PGP SIGNATURE----- --=-Dc3pTip8uHB4yRlRPAcy-- --===============5860263484059258506== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5860263484059258506==--