From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v1 3/3] xl: enable per-VCPU extratime flag for RTDS Date: Wed, 9 Aug 2017 12:32:11 +0200 Message-ID: <1502274731.5719.22.camel@citrix.com> References: <1502036563-4275-1-git-send-email-mengxu@cis.upenn.edu> <1502036563-4275-4-git-send-email-mengxu@cis.upenn.edu> <1502208576.18446.17.camel@citrix.com> <1502231091.5719.2.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1912942222585716653==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu Cc: George Dunlap , Ian Jackson , Wei Liu , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============1912942222585716653== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-XNf6hVAc5Xo3BlCVKI/r" --=-XNf6hVAc5Xo3BlCVKI/r Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-08-08 at 15:55 -0700, Meng Xu wrote: > On Tue, Aug 8, 2017 at 3:24 PM, Dario Faggioli > wrote: > >=20 > > Therefore, I think I would set extratime as on by default in both > > Xen > > an xl. What do you think? > >=20 >=20 > Right now, the domain is created with its VCPUs' extratime flag on. > So > by default, extratime is set on in Xen. >=20 > I'm not sure what do you suggest setting the extratime flag on by > default in xl? > Did you mean if users do not input -e option, the extratime flag will > be set as on? > No, as I said, I'm ok with the requirement of -e 0/1 always having to be present, when changing the vCPU(s) parameters with xl. I'm talking about what happens at domain creation time. If the default in Xen is already 'extratime on', I think we're mostly fine. As for xl/libxl, I think it would probably be good to take care of extratime, e.g., in sched_rtds_domain_set() (in a similar way to how we deal with period and budget, i.e., taking advantage of LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT). Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-XNf6hVAc5Xo3BlCVKI/r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZiuSrAAoJEBZCeImluHPub6sP/j7hx4Dj/YKWK8RL0SB6ELF+ mLzSrYztq4rAcqXju8qEc+FubhC7LeKD6K8zNT6IQNw4zPPIyP4yUgrNL1e1raJg SRHDNBMXiweNJiro2ieKTcH8mY4Qa7AAQYS50MW16Xt0X8hJDvEQgRdyOmkVmIJf i7rc8Mt1uRYGblm+f9s68gEm4f6ihksP1s8PSowNXtIXJbi8dgFME0sic1f2tGpU hSlJYkeyZInp3XVcGEabBLBRlvtXK8Jjgi/5aN9y96ri/OlMqxL5NhymUQltmQFg 1b8oZML4H898vfFdlqb5nsHQO748dWuxNmvTcL7SMR8rElpOnXbsLvClyo6pxjoD bWBF6tg6rhtCqCPWM/rXUfxJQH+d276+7EzBYNQa2yeaIh/RqDHUO5NoT8Dq8+QQ 1oyhC3iy70Sk0vpiZiNbRgqJFr8SIg6kCD+2/fFw5JipZTFf7GqSmP6+6sriGPTi uCYPoJWKFxWJueNVbh/KZaD1j5+8ajd06fvQcBsZXU4vC9vPT+gOthsqSS+pDQZN jYSiAf/rJp5kZHvAKawz2hTFzxlwBlJ4jZf4b7IuoG8H0jhsElzA/zbaOQMxYlYo SdywRaBI2XT48pfz8ZBHWRcRyw+D9gsQPwO8dim4FcYE8DBKfOJMPB9vtpTu0WF+ w0U6SuUY55Ogn+HcAO4O =Wn6C -----END PGP SIGNATURE----- --=-XNf6hVAc5Xo3BlCVKI/r-- --===============1912942222585716653== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1912942222585716653==--