From: Lan Tianyu <tianyu.lan@intel.com>
To: xen-devel@lists.xen.org
Cc: Lan Tianyu <tianyu.lan@intel.com>,
kevin.tian@intel.com, wei.liu2@citrix.com,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
julien.grall@arm.com, jbeulich@suse.com,
Chao Gao <chao.gao@intel.com>
Subject: [PATCH V2 13/25] x86/vvtd: Set Interrupt Remapping Table Pointer through GCMD
Date: Wed, 9 Aug 2017 16:34:14 -0400 [thread overview]
Message-ID: <1502310866-10450-14-git-send-email-tianyu.lan@intel.com> (raw)
In-Reply-To: <1502310866-10450-1-git-send-email-tianyu.lan@intel.com>
From: Chao Gao <chao.gao@intel.com>
Software sets this field to set/update the interrupt remapping table pointer
used by hardware. The interrupt remapping table pointer is specified through
the Interrupt Remapping Table Address (IRTA_REG) register.
This patch emulates this operation and adds some new fields in VVTD to track
info (e.g. the table's gfn and max supported entries) of interrupt remapping
table.
Signed-off-by: Chao Gao <chao.gao@intel.com>
Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
---
xen/drivers/passthrough/vtd/iommu.h | 9 ++++-
xen/drivers/passthrough/vtd/vvtd.c | 73 +++++++++++++++++++++++++++++++++++++
2 files changed, 81 insertions(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/vtd/iommu.h
index 55f3b6e..102b4f3 100644
--- a/xen/drivers/passthrough/vtd/iommu.h
+++ b/xen/drivers/passthrough/vtd/iommu.h
@@ -192,9 +192,16 @@
#define DMA_GSTS_WBFS (((u64)1) << 27)
#define DMA_GSTS_QIES (((u64)1) <<26)
#define DMA_GSTS_IRES (((u64)1) <<25)
-#define DMA_GSTS_SIRTPS (((u64)1) << 24)
+#define DMA_GSTS_SIRTPS_BIT 24
+#define DMA_GSTS_SIRTPS (((u64)1) << DMA_GSTS_SIRTPS_BIT)
#define DMA_GSTS_CFIS (((u64)1) <<23)
+/* IRTA_REG */
+#define DMA_IRTA_ADDR(val) (val & ~0xfffULL)
+#define DMA_IRTA_EIME(val) (!!(val & (1 << 11)))
+#define DMA_IRTA_S(val) (val & 0xf)
+#define DMA_IRTA_SIZE(val) (1UL << (DMA_IRTA_S(val) + 1))
+
/* PMEN_REG */
#define DMA_PMEN_EPM (((u32)1) << 31)
#define DMA_PMEN_PRS (((u32)1) << 0)
diff --git a/xen/drivers/passthrough/vtd/vvtd.c b/xen/drivers/passthrough/vtd/vvtd.c
index 94680e6..8e8dbe6 100644
--- a/xen/drivers/passthrough/vtd/vvtd.c
+++ b/xen/drivers/passthrough/vtd/vvtd.c
@@ -46,6 +46,13 @@ struct vvtd {
uint64_t length;
/* Point back to the owner domain */
struct domain *domain;
+ /* Is in Extended Interrupt Mode? */
+ bool eim;
+ /* Max remapping entries in IRT */
+ int irt_max_entry;
+ /* Interrupt remapping table base gfn */
+ uint64_t irt;
+
struct hvm_hw_vvtd_regs *regs;
struct page_info *regs_page;
};
@@ -82,6 +89,11 @@ static inline struct vvtd *vcpu_vvtd(struct vcpu *v)
return domain_vvtd(v->domain);
}
+static inline void __vvtd_set_bit(struct vvtd *vvtd, uint32_t reg, int nr)
+{
+ return __set_bit(nr, (uint32_t *)&vvtd->regs->data[reg]);
+}
+
static inline void vvtd_set_reg(struct vvtd *vtd, uint32_t reg,
uint32_t value)
{
@@ -108,6 +120,44 @@ static inline uint8_t vvtd_get_reg_byte(struct vvtd *vtd, uint32_t reg)
vvtd_set_reg(vvtd, (reg) + 4, (val) >> 32); \
} while(0)
+static int vvtd_handle_gcmd_sirtp(struct vvtd *vvtd, uint32_t val)
+{
+ uint64_t irta;
+
+ if ( !(val & DMA_GCMD_SIRTP) )
+ return X86EMUL_OKAY;
+
+ vvtd_get_reg_quad(vvtd, DMAR_IRTA_REG, irta);
+ vvtd->irt = DMA_IRTA_ADDR(irta) >> PAGE_SHIFT;
+ vvtd->irt_max_entry = DMA_IRTA_SIZE(irta);
+ vvtd->eim = DMA_IRTA_EIME(irta);
+ VVTD_DEBUG(VVTD_DBG_RW, "Update IR info (addr=%lx eim=%d size=%d).",
+ vvtd->irt, vvtd->eim, vvtd->irt_max_entry);
+ __vvtd_set_bit(vvtd, DMAR_GSTS_REG, DMA_GSTS_SIRTPS_BIT);
+
+ return X86EMUL_OKAY;
+}
+
+static int vvtd_write_gcmd(struct vvtd *vvtd, uint32_t val)
+{
+ uint32_t orig = vvtd_get_reg(vvtd, DMAR_GSTS_REG);
+ uint32_t changed;
+
+ orig = orig & 0x96ffffff; /* reset the one-shot bits */
+ changed = orig ^ val;
+
+ if ( !changed )
+ return X86EMUL_OKAY;
+ if ( (changed & (changed - 1)) )
+ VVTD_DEBUG(VVTD_DBG_RW, "Guest attempts to update multiple fields "
+ "of GCMD_REG in one write transation.");
+
+ if ( changed & DMA_GCMD_SIRTP )
+ vvtd_handle_gcmd_sirtp(vvtd, val);
+
+ return X86EMUL_OKAY;
+}
+
static int vvtd_range(struct vcpu *v, unsigned long addr)
{
struct vvtd *vvtd = vcpu_vvtd(v);
@@ -165,12 +215,18 @@ static int vvtd_write(struct vcpu *v, unsigned long addr,
{
switch ( offset_aligned )
{
+ case DMAR_GCMD_REG:
+ ret = vvtd_write_gcmd(vvtd, val);
+ break;
+
case DMAR_IEDATA_REG:
case DMAR_IEADDR_REG:
case DMAR_IEUADDR_REG:
case DMAR_FEDATA_REG:
case DMAR_FEADDR_REG:
case DMAR_FEUADDR_REG:
+ case DMAR_IRTA_REG:
+ case DMAR_IRTA_REG_HI:
vvtd_set_reg(vvtd, offset_aligned, val);
ret = X86EMUL_OKAY;
break;
@@ -179,6 +235,20 @@ static int vvtd_write(struct vcpu *v, unsigned long addr,
break;
}
}
+ else /* len == 8 */
+ {
+ switch ( offset_aligned )
+ {
+ case DMAR_IRTA_REG:
+ vvtd_set_reg_quad(vvtd, DMAR_IRTA_REG, val);
+ ret = X86EMUL_OKAY;
+ break;
+
+ default:
+ ret = X86EMUL_UNHANDLEABLE;
+ break;
+ }
+ }
return ret;
}
@@ -235,6 +305,9 @@ static int vvtd_create(struct domain *d, struct viommu *viommu)
vvtd->length = viommu->length;
vvtd->domain = d;
vvtd->status = VIOMMU_STATUS_DEFAULT;
+ vvtd->eim = 0;
+ vvtd->irt = 0;
+ vvtd->irt_max_entry = 0;
register_mmio_handler(d, &vvtd_mmio_ops);
return 0;
--
1.8.3.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-09 20:34 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 20:34 [PATCH V2 00/25] xen/vIOMMU: Add vIOMMU support with irq remapping fucntion of virtual vtd Lan Tianyu
2017-08-09 20:34 ` [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support Lan Tianyu
2017-08-17 11:18 ` Wei Liu
2017-08-18 2:57 ` Lan Tianyu
2017-08-22 14:32 ` Roger Pau Monné
2017-08-23 6:06 ` Lan Tianyu
2017-08-23 7:22 ` Roger Pau Monné
2017-08-23 9:12 ` Lan Tianyu
2017-08-23 10:19 ` Julien Grall
2017-08-23 14:05 ` Roger Pau Monné
2017-08-24 14:03 ` Julien Grall
2017-08-24 14:25 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping Lan Tianyu
2017-08-17 11:18 ` Wei Liu
2017-08-18 0:22 ` [PATCH V2 1/25] VIOMMU: Add vIOMMU helper functions to create, destroy and query capabilities Lan Tianyu
2017-08-18 8:41 ` Jan Beulich
2017-08-18 8:50 ` Lan Tianyu
2017-08-18 13:32 ` Wei Liu
2017-08-22 15:27 ` Roger Pau Monné
2017-08-23 7:10 ` Lan Tianyu
2017-08-23 7:38 ` Roger Pau Monné
2017-08-24 8:14 ` Tian, Kevin
2017-08-18 7:09 ` [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping Lan Tianyu
2017-08-18 10:13 ` Wei Liu
2017-08-22 8:04 ` Lan Tianyu
2017-08-22 8:42 ` Wei Liu
2017-08-22 10:39 ` Lan Tianyu
2017-08-22 10:53 ` Wei Liu
2017-08-22 10:54 ` Lan Tianyu
2017-08-22 15:32 ` Roger Pau Monné
2017-08-23 7:42 ` Lan Tianyu
2017-08-23 9:24 ` Jan Beulich
2017-08-23 9:47 ` Lan Tianyu
2017-08-09 20:34 ` [PATCH V2 3/25] VIOMMU: Add get irq info callback to convert irq remapping request Lan Tianyu
2017-08-17 11:19 ` Wei Liu
2017-08-22 15:38 ` Roger Pau Monné
2017-08-23 7:43 ` Lan Tianyu
2017-08-23 9:25 ` Jan Beulich
2017-08-09 20:34 ` [PATCH V2 4/25] Xen/doc: Add Xen virtual IOMMU doc Lan Tianyu
2017-08-17 11:19 ` Wei Liu
2017-08-18 7:17 ` Lan Tianyu
2017-08-18 10:15 ` Wei Liu
2017-08-22 8:07 ` Lan Tianyu
2017-08-22 11:03 ` Wei Liu
2017-08-23 2:06 ` Lan Tianyu
2017-08-22 15:55 ` Roger Pau Monné
2017-08-23 7:36 ` Lan Tianyu
2017-08-23 13:53 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 5/25] tools/libxc: Add viommu operations in libxc Lan Tianyu
2017-08-22 11:09 ` Wei Liu
2017-08-22 16:25 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 6/25] tools/libacpi: Add DMA remapping reporting (DMAR) ACPI table structures Lan Tianyu
2017-08-22 12:56 ` Wei Liu
2017-08-23 2:47 ` Lan Tianyu
2017-08-09 20:34 ` [PATCH V2 7/25] tools/libacpi: Add new fields in acpi_config for DMAR table Lan Tianyu
2017-08-22 13:12 ` Wei Liu
2017-08-23 2:36 ` Lan Tianyu
2017-08-23 8:07 ` Wei Liu
2017-08-22 16:41 ` Roger Pau Monné
2017-08-23 7:52 ` Lan Tianyu
2017-08-23 8:04 ` Roger Pau Monné
2017-08-23 14:11 ` Roger Pau Monné
2017-08-24 2:33 ` Lan Tianyu
2017-08-24 6:54 ` Jan Beulich
2017-08-24 8:36 ` Lan Tianyu
2017-08-09 20:34 ` [PATCH V2 8/25] tools/libxl: Add a user configurable parameter to control vIOMMU attributes Lan Tianyu
2017-08-22 13:19 ` Wei Liu
2017-08-23 2:46 ` Lan Tianyu
2017-08-23 8:09 ` Wei Liu
2017-08-22 16:48 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD Lan Tianyu
2017-08-17 11:32 ` Wei Liu
2017-08-17 12:28 ` Wei Liu
2017-08-18 5:45 ` Chao Gao
2017-08-18 13:45 ` Wei Liu
2017-08-18 13:56 ` Jan Beulich
2017-08-22 13:44 ` Wei Liu
2017-08-22 13:48 ` Wei Liu
2017-08-23 5:35 ` Lan Tianyu
2017-08-23 8:34 ` Wei Liu
2017-08-24 3:24 ` Lan Tianyu
2017-08-24 11:08 ` Wei Liu
2017-08-25 3:19 ` Lan Tianyu
2017-08-25 7:33 ` Lan Tianyu
2017-08-25 9:11 ` Wei Liu
2017-08-09 20:34 ` [PATCH V2 10/25] tools/libxl: create vIOMMU during domain construction Lan Tianyu
2017-08-23 7:45 ` Roger Pau Monné
2017-08-23 8:02 ` Lan Tianyu
2017-08-23 13:53 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 11/25] x86/hvm: Introduce a emulated VTD for HVM Lan Tianyu
2017-08-23 7:58 ` Roger Pau Monné
2017-08-24 2:16 ` Lan Tianyu
2017-08-24 8:49 ` Roger Pau Monné
2017-08-24 8:54 ` Lan Tianyu
2017-08-24 9:02 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 12/25] x86/vvtd: Add MMIO handler for VVTD Lan Tianyu
2017-08-23 8:27 ` Roger Pau Monné
2017-08-09 20:34 ` Lan Tianyu [this message]
2017-08-23 8:47 ` [PATCH V2 13/25] x86/vvtd: Set Interrupt Remapping Table Pointer through GCMD Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 14/25] x86/vvtd: Process interrupt remapping request Lan Tianyu
2017-08-23 9:49 ` Roger Pau Monné
2017-08-23 9:59 ` Jan Beulich
2017-08-09 20:34 ` [PATCH V2 15/25] x86/vvtd: decode interrupt attribute from IRTE Lan Tianyu
2017-08-23 9:57 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 16/25] x86/vioapic: Hook interrupt delivery of vIOAPIC Lan Tianyu
2017-08-23 9:59 ` Roger Pau Monné
2017-08-24 5:28 ` Lan Tianyu
2017-08-09 20:34 ` [PATCH V2 17/25] x86/vvtd: Enable Queued Invalidation through GCMD Lan Tianyu
2017-08-23 10:03 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 18/25] x86/vvtd: Enable Interrupt Remapping " Lan Tianyu
2017-08-23 10:07 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 19/25] x86/vioapic: extend vioapic_get_vector() to support remapping format RTE Lan Tianyu
2017-08-23 10:14 ` Roger Pau Monné
2017-08-24 6:11 ` Lan Tianyu
2017-08-24 6:59 ` Jan Beulich
2017-08-24 8:04 ` Lan Tianyu
2017-08-09 20:34 ` [PATCH V2 20/25] passthrough: move some fields of hvm_gmsi_info to a sub-structure Lan Tianyu
2017-08-09 20:34 ` [PATCH V2 21/25] tools/libxc: Add a new interface to bind remapping format msi with pirq Lan Tianyu
2017-08-23 10:41 ` Roger Pau Monné
2017-08-25 7:28 ` Chao Gao
2017-08-25 9:35 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 22/25] x86/vmsi: Hook delivering remapping format msi to guest Lan Tianyu
2017-08-23 10:55 ` Roger Pau Monné
2017-08-23 12:17 ` Jan Beulich
2017-08-09 20:34 ` [PATCH V2 23/25] x86/vvtd: Handle interrupt translation faults Lan Tianyu
2017-08-23 11:51 ` Roger Pau Monné
2017-08-25 7:17 ` Chao Gao
2017-08-25 9:43 ` Roger Pau Monné
2017-08-09 20:34 ` [PATCH V2 24/25] x86/vvtd: Add queued invalidation (QI) support Lan Tianyu
2017-08-23 12:16 ` Roger Pau Monné
2017-08-24 6:31 ` Lan Tianyu
2017-08-09 20:34 ` [PATCH V2 25/25] x86/vvtd: save and restore emulated VT-d Lan Tianyu
2017-08-23 12:19 ` Roger Pau Monné
2017-08-25 6:35 ` Chao Gao
2017-08-25 9:00 ` Jan Beulich
2017-08-25 8:27 ` Chao Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502310866-10450-14-git-send-email-tianyu.lan@intel.com \
--to=tianyu.lan@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.gao@intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=kevin.tian@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).