From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 4/4] xen/x86: Correct mandatory and SMP
 barrier definitions
Date: Wed, 16 Aug 2017 17:44:54 +0200
Message-ID: <1502898294.7157.3.camel@citrix.com>
References: <1502882530-31700-1-git-send-email-andrew.cooper3@citrix.com>
 <1502882530-31700-5-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2825713448273610599=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1502882530-31700-5-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

--===============2825713448273610599==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-GedIFPyR+0wSPe/FRUXL"

--=-GedIFPyR+0wSPe/FRUXL
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2017-08-16 at 12:22 +0100, Andrew Cooper wrote:
> Barriers are a complicated topic, a source of confusion, and their
> incorrect
> use is a common cause of bugs.=C2=A0=C2=A0It *really* doesn't help when X=
en's
> API is the
> same as Linux, but its ABI different.
>=20
> Bring the two back in line, so programmers stand a chance of actually
> getting
> their usage correct.
>=20
> Drop the links in the comment, both of which are now stale.=C2=A0=C2=A0In=
stead,
> refer to
> the vendor system manuals.
>=20
Does it perhaps make sense to link this:

https://www.kernel.org/doc/Documentation/memory-barriers.txt

> No functional change.
>=20
IAC, FWIW:

> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-GedIFPyR+0wSPe/FRUXL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZlGh2AAoJEBZCeImluHPuXZUP/313Y0RyOGWo1XJVvGMRrCU7
ynPHPQ3BLUFMCfgT0Lyyennj5LtOF81tvY6fdeuAY6vw9gZZdM68iE5qFqJT5heC
Ll8w3gvxkv5PZ3jkYbx99yFKf09ajl5YsK2cz0SfQUjZmx4OIy418338PSRMxAm6
j0O5AAzpl/RPkaOzKWv4LPVHPdBcIIeohQ2bprm+u2kZU5JcyrJ2pkkPdSPxh/4M
nNiQX2JjzXs+aHFKNyXHvMZNPXA6bz9TZeAGPHYxeh1YgiSmYjVPuPyiIfAl8Vmn
kh18I+8/5H/PhQxE4EwcLykcKEHufmtvBjs6WSJKgm1iV0siZoIs0HSJDyY0z7I7
0I/E3qrtKv1JH98ANSJgCaVmK6NB+Js23aQOyLWUlfBz+GWWhVZ7gw9mtIJSnkaA
UNRIyty54/2WFINsuuGKprUPzKrt+op9mDk0fDpe1j5FGt4LX09Re/yxKYWga08Y
YPoG9A+bqKeQQMaL44wxEzh8LJofnCEQVQWJMcg1m3S/se+WuFgPZ/3OHPFeXg3z
EvjIsyhMz6JjzxxQpH+pj6LT+qEmuxHAgFyCfLqaGxNL8msp8uhB9Y+tpbHMPle/
L+PmTe1eDpEqpMz3UUXr4lHhbBIQQIAny1ARZtNDMBis8u/iEa8HFJxoqO2G8Ond
uEBTfVd8qME4Cd+wrDJC
=zePL
-----END PGP SIGNATURE-----

--=-GedIFPyR+0wSPe/FRUXL--


--===============2825713448273610599==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============2825713448273610599==--