From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: [PATCH 1/4] mm: Initialize lowmem virq when boot-time scrubbing is disabled
Date: Mon, 28 Aug 2017 16:40:26 -0400 [thread overview]
Message-ID: <1503952829-11065-2-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1503952829-11065-1-git-send-email-boris.ostrovsky@oracle.com>
scrub_heap_pages() does early return if boot-time scrubbing is
disabled, neglecting to initialize lowmem VIRQ.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
xen/common/page_alloc.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 9fa62d2..7d56e92 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1849,6 +1849,14 @@ void __init scrub_heap_pages(void)
int last_distance, best_node;
int cpus;
+ /*
+ * Set bounds for the low mem virq algorithm.
+ * Not the most logical place for this but it needs to be done
+ * after dom0 has been constructed and this seems to be a
+ * convenient location.
+ */
+ setup_low_mem_virq();
+
if ( !opt_bootscrub )
return;
@@ -1970,10 +1978,6 @@ void __init scrub_heap_pages(void)
#ifdef CONFIG_SCRUB_DEBUG
boot_scrub_done = true;
#endif
-
- /* Now that the heap is initialized, run checks and set bounds
- * for the low mem virq algorithm. */
- setup_low_mem_virq();
}
--
1.8.3.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-28 20:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 20:40 [PATCH 0/4] Scrubbing updates Boris Ostrovsky
2017-08-28 20:40 ` Boris Ostrovsky [this message]
2017-08-29 11:51 ` [PATCH 1/4] mm: Initialize lowmem virq when boot-time scrubbing is disabled Wei Liu
2017-08-29 13:12 ` Boris Ostrovsky
2017-08-29 13:20 ` Jan Beulich
2017-08-29 13:19 ` Jan Beulich
2017-08-28 20:40 ` [PATCH 2/4] mm: Don't poison a page if boot-time scrubbing is off Boris Ostrovsky
2017-08-29 11:52 ` Wei Liu
2017-08-28 20:40 ` [PATCH 3/4] mm: Don't request scrubbing until dom0 is running Boris Ostrovsky
2017-08-29 11:56 ` Wei Liu
2017-08-29 13:22 ` Jan Beulich
2017-08-29 13:27 ` Boris Ostrovsky
2017-08-29 13:34 ` Jan Beulich
2017-08-29 14:20 ` Boris Ostrovsky
2017-08-29 14:25 ` Jan Beulich
2017-08-29 13:26 ` Jan Beulich
2017-08-29 13:31 ` Wei Liu
2017-08-28 20:40 ` [PATCH 4/4] mm: Don't hold heap lock in alloc_heap_pages() longer than necessary Boris Ostrovsky
2017-08-29 12:16 ` Wei Liu
2017-08-29 13:33 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503952829-11065-2-git-send-email-boris.ostrovsky@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).