From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [PATCH v3] x86/emul: Fix the handling of unimplemented Grp7 instructions Date: Tue, 5 Sep 2017 09:41:59 +0100 Message-ID: <1504600919-22861-1-git-send-email-andrew.cooper3@citrix.com> References: <1504545661-24626-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1504545661-24626-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Xen-devel Cc: Petre Pircalabu , Andrew Cooper , Jan Beulich List-Id: xen-devel@lists.xenproject.org R3JwNyBpcyBhYm5vcm1hbGx5IGNvbXBsaWNhdGVkIHRvIGRlY29kZSwgZXZlbiBieSB4ODYncyBz dGFuZGFyZHMsIHdpdGgKe3MsbH1tc3cgYmVpbmcgdGhlIHByb2JsZW1hdGljIGNhc2VzLgoKUHJl dmlvdXNseSwgYW55IHZhbHVlIHdoaWNoIGZlbGwgdGhyb3VnaCB0aGUgZmlyc3Qgc3dpdGNoIHN0 YXRlbWVudCAobG9va2luZwpmb3IgaW5zdHJ1Y3Rpb25zIHdpdGggZW50aXJlbHkgaW1wbGljaXQg b3BlcmFuZHMpIHdvdWxkIGJlIGludGVycHJldGVkIGJ5IHRoZQpzZWNvbmQgc3dpdGNoIHN0YXRl bWVudCAoaGFuZGxpbmcgaW5zdHJ1Y3Rpb25zIHdpdGggbWVtb3J5IG9wZXJhbmRzKS4KClVuaW1w bGVtZW50ZWQgaW5zdHJ1Y3Rpb25zIHdvdWxkIHRoZW4gaGl0IHRoZSAjVUQgY2FzZSBmb3IgaGF2 aW5nIGEgbm9uLW1lbW9yeQpvcGVyYW5kLCByYXRoZXIgdGhhbiB0YWtpbmcgdGhlIGNhbm5vdF9l bXVsYXRlIHBhdGguCgpDb25zb2xpZGF0ZSB0aGUgdHdvIHN3aXRjaCBzdGF0ZW1lbnRzIGludG8g YSBzaW5nbGUgb25lLCB1c2luZyByYW5nZXMgdG8gY292ZXIKdGhlIGluc3RydWN0aW9ucyB3aXRo IG1lbW9yeSBvcGVyYW5kcy4KClRoaXMgYWxzbyBmaXhlcyB0aGUgZW11bGF0aW9uIG9mIHhlbmQs IHdoaWNoIHdvdWxkIGhpdCB0aGUgI1VEIHBhdGggd2hlbiBpdApzaG91bGQgY29tcGxldGUgd2l0 aCBubyBzaWRlIGVmZmVjdHMuCgpSZXBvcnRlZC1ieTogUGV0cmUgUGlyY2FsYWJ1IDxwcGlyY2Fs YWJ1QGJpdGRlZmVuZGVyLmNvbT4KU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KLS0tCkNDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5j b20+CkNDOiBQZXRyZSBQaXJjYWxhYnUgPHBwaXJjYWxhYnVAYml0ZGVmZW5kZXIuY29tPgoKdjM6 CiAqIFVzZSBhIHNpbmdsZSBzd2l0Y2ggc3RhdGVtZW50LgoKdjI6CiAqIFVzZSBicmVhayByYXRo ZXIgdGhhbiBnb3RvIGNvbXBsZXRlX2luc24gZm9yIGltcGxpY2l0IGluc3RydWN0aW9ucy4KICog Tm90ZSB0aGF0IHdlIGFjdHVhbGx5IGZpeCB0aGUgYmVoYXZpb3VyIG9mIHhlbmQuCgpSRkMgYXMg SSd2ZSBvbmx5IGRvbmUgbGlnaHQgdGVzdGluZyBzbyBmYXIuCi0tLQogeGVuL2FyY2gveDg2L3g4 Nl9lbXVsYXRlL3g4Nl9lbXVsYXRlLmMgfCA0OSArKysrKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl9lbXVsYXRlL3g4Nl9lbXVsYXRlLmMgYi94 ZW4vYXJjaC94ODYveDg2X2VtdWxhdGUveDg2X2VtdWxhdGUuYwppbmRleCAyMjAxODUyLi40M2Uw ZTAwIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYveDg2X2VtdWxhdGUveDg2X2VtdWxhdGUuYwor KysgYi94ZW4vYXJjaC94ODYveDg2X2VtdWxhdGUveDg2X2VtdWxhdGUuYwpAQCAtNDk4Nyw5ICs0 OTg3LDEyIEBAIHg4Nl9lbXVsYXRlKAogICAgICAgICB9CiAgICAgICAgIGJyZWFrOwogCi0gICAg Y2FzZSBYODZFTVVMX09QQygweDBmLCAweDAxKTogLyogR3JwNyAqLyB7CisgICAgY2FzZSBYODZF TVVMX09QQygweDBmLCAweDAxKTogLyogR3JwNyAqLworICAgIHsKICAgICAgICAgdW5zaWduZWQg bG9uZyBiYXNlLCBsaW1pdCwgY3IwLCBjcjB3OwogCisgICAgICAgIHNlZyA9IChtb2RybV9yZWcg JiAxKSA/IHg4Nl9zZWdfaWR0ciA6IHg4Nl9zZWdfZ2R0cjsKKwogICAgICAgICBzd2l0Y2goIG1v ZHJtICkKICAgICAgICAgewogICAgICAgICBjYXNlIDB4Y2E6IC8qIGNsYWMgKi8KQEAgLTUwMDAs NyArNTAwMyw3IEBAIHg4Nl9lbXVsYXRlKAogICAgICAgICAgICAgX3JlZ3MuZWZsYWdzICY9IH5Y ODZfRUZMQUdTX0FDOwogICAgICAgICAgICAgaWYgKCBtb2RybSA9PSAweGNiICkKICAgICAgICAg ICAgICAgICBfcmVncy5lZmxhZ3MgfD0gWDg2X0VGTEFHU19BQzsKLSAgICAgICAgICAgIGdvdG8g Y29tcGxldGVfaW5zbjsKKyAgICAgICAgICAgIGJyZWFrOwogCiAjaWZkZWYgX19YRU5fXwogICAg ICAgICBjYXNlIDB4ZDE6IC8qIHhzZXRidiAqLwpAQCAtNTAxMiw3ICs1MDE1LDcgQEAgeDg2X2Vt dWxhdGUoCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaGFuZGxlX3hzZXRidihf cmVncy5lY3gsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBfcmVncy5lYXggfCAoX3JlZ3MucmR4IDw8IDMyKSksCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgRVhDX0dQLCAwKTsKLSAgICAgICAgICAgIGdvdG8gY29tcGxldGVfaW5zbjsK KyAgICAgICAgICAgIGJyZWFrOwogI2VuZGlmCiAKICAgICAgICAgY2FzZSAweGQ0OiAvKiB2bWZ1 bmMgKi8KQEAgLTUwMjAsNyArNTAyMyw3IEBAIHg4Nl9lbXVsYXRlKAogICAgICAgICAgICAgZmFp bF9pZighb3BzLT52bWZ1bmMpOwogICAgICAgICAgICAgaWYgKCAocmMgPSBvcHMtPnZtZnVuYyhj dHh0KSkgIT0gWDg2RU1VTF9PS0FZICkKICAgICAgICAgICAgICAgICBnb3RvIGRvbmU7Ci0gICAg ICAgICAgICBnb3RvIGNvbXBsZXRlX2luc247CisgICAgICAgICAgICBicmVhazsKIAogICAgICAg ICBjYXNlIDB4ZDU6IC8qIHhlbmQgKi8KICAgICAgICAgICAgIGdlbmVyYXRlX2V4Y2VwdGlvbl9p Zih2ZXgucGZ4LCBFWENfVUQpOwpAQCAtNTAzNCw3ICs1MDM3LDcgQEAgeDg2X2VtdWxhdGUoCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRVhDX1VEKTsKICAgICAgICAgICAgIC8q IE5laXRoZXIgSExFIG5vciBSVE0gY2FuIGJlIGFjdGl2ZSB3aGVuIHdlIGdldCBoZXJlLiAqLwog ICAgICAgICAgICAgX3JlZ3MuZWZsYWdzIHw9IFg4Nl9FRkxBR1NfWkY7Ci0gICAgICAgICAgICBn b3RvIGNvbXBsZXRlX2luc247CisgICAgICAgICAgICBicmVhazsKIAogICAgICAgICBjYXNlIDB4 ZGY6IC8qIGludmxwZ2EgKi8KICAgICAgICAgICAgIGdlbmVyYXRlX2V4Y2VwdGlvbl9pZighaW5f cHJvdG1vZGUoY3R4dCwgb3BzKSwgRVhDX1VEKTsKQEAgLTUwNDMsNyArNTA0Niw3IEBAIHg4Nl9l bXVsYXRlKAogICAgICAgICAgICAgaWYgKCAocmMgPSBvcHMtPmludmxwZyh4ODZfc2VnX25vbmUs IHRydW5jYXRlX2VhKF9yZWdzLnIoYXgpKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY3R4dCkpICkKICAgICAgICAgICAgICAgICBnb3RvIGRvbmU7Ci0gICAgICAgICAgICBn b3RvIGNvbXBsZXRlX2luc247CisgICAgICAgICAgICBicmVhazsKIAogICAgICAgICBjYXNlIDB4 Zjk6IC8qIHJkdHNjcCAqLwogICAgICAgICAgICAgZmFpbF9pZihvcHMtPnJlYWRfbXNyID09IE5V TEwpOwpAQCAtNTA5MSwxNiArNTA5NCwxNiBAQCB4ODZfZW11bGF0ZSgKICAgICAgICAgICAgICAg ICBiYXNlICs9IHNpemVvZih6ZXJvKTsKICAgICAgICAgICAgICAgICBsaW1pdCAtPSBzaXplb2Yo emVybyk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBnb3RvIGNvbXBsZXRlX2luc247Ci0g ICAgICAgIH0KKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKLSAgICAgICAgc2VnID0g KG1vZHJtX3JlZyAmIDEpID8geDg2X3NlZ19pZHRyIDogeDg2X3NlZ19nZHRyOworI2RlZmluZSBf R1JQNyhtb2QsIHJlZykgXAorICAgICAgICAgICAgKCgobW9kKSA8PCA2KSB8ICgocmVnKSA8PCAz KSkgLi4uICgoKG1vZCkgPDwgNikgfCAoKHJlZykgPDwgMykgfCA3KQorI2RlZmluZSBHUlA3X01F TShyZWcpIF9HUlA3KDAsIHJlZyk6IGNhc2UgX0dSUDcoMSwgcmVnKTogY2FzZSBfR1JQNygyLCBy ZWcpCisjZGVmaW5lIEdSUDdfQUxMKHJlZykgR1JQN19NRU0ocmVnKTogY2FzZSBfR1JQNygzLCBy ZWcpCiAKLSAgICAgICAgc3dpdGNoICggbW9kcm1fcmVnICYgNyApCi0gICAgICAgIHsKLSAgICAg ICAgY2FzZSAwOiAvKiBzZ2R0ICovCi0gICAgICAgIGNhc2UgMTogLyogc2lkdCAqLworICAgICAg ICBjYXNlIEdSUDdfTUVNKDApOiAvKiBzZ2R0ICovCisgICAgICAgIGNhc2UgR1JQN19NRU0oMSk6 IC8qIHNpZHQgKi8KICAgICAgICAgICAgIGdlbmVyYXRlX2V4Y2VwdGlvbl9pZihlYS50eXBlICE9 IE9QX01FTSwgRVhDX1VEKTsKICAgICAgICAgICAgIGdlbmVyYXRlX2V4Y2VwdGlvbl9pZih1bWlw X2FjdGl2ZShjdHh0LCBvcHMpLCBFWENfR1AsIDApOwogICAgICAgICAgICAgZmFpbF9pZighb3Bz LT5yZWFkX3NlZ21lbnQgfHwgIW9wcy0+d3JpdGUpOwpAQCAtNTExOSw4ICs1MTIyLDkgQEAgeDg2 X2VtdWxhdGUoCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb3BfYnl0ZXMsIGN0 eHQpKSAhPSBYODZFTVVMX09LQVkgKQogICAgICAgICAgICAgICAgIGdvdG8gZG9uZTsKICAgICAg ICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIDI6IC8qIGxnZHQgKi8KLSAgICAgICAgY2FzZSAz OiAvKiBsaWR0ICovCisKKyAgICAgICAgY2FzZSBHUlA3X01FTSgyKTogLyogbGdkdCAqLworICAg ICAgICBjYXNlIEdSUDdfTUVNKDMpOiAvKiBsaWR0ICovCiAgICAgICAgICAgICBnZW5lcmF0ZV9l eGNlcHRpb25faWYoIW1vZGVfcmluZzAoKSwgRVhDX0dQLCAwKTsKICAgICAgICAgICAgIGdlbmVy YXRlX2V4Y2VwdGlvbl9pZihlYS50eXBlICE9IE9QX01FTSwgRVhDX1VEKTsKICAgICAgICAgICAg IGZhaWxfaWYob3BzLT53cml0ZV9zZWdtZW50ID09IE5VTEwpOwpAQCAtNTEzOCw3ICs1MTQyLDgg QEAgeDg2X2VtdWxhdGUoCiAgICAgICAgICAgICBpZiAoIChyYyA9IG9wcy0+d3JpdGVfc2VnbWVu dChzZWcsICZzcmVnLCBjdHh0KSkgKQogICAgICAgICAgICAgICAgIGdvdG8gZG9uZTsKICAgICAg ICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIDQ6IC8qIHNtc3cgKi8KKworICAgICAgICBjYXNl IEdSUDdfQUxMKDQpOiAvKiBzbXN3ICovCiAgICAgICAgICAgICBnZW5lcmF0ZV9leGNlcHRpb25f aWYodW1pcF9hY3RpdmUoY3R4dCwgb3BzKSwgRVhDX0dQLCAwKTsKICAgICAgICAgICAgIGlmICgg ZWEudHlwZSA9PSBPUF9NRU0gKQogICAgICAgICAgICAgewpAQCAtNTE1Myw3ICs1MTU4LDggQEAg eDg2X2VtdWxhdGUoCiAgICAgICAgICAgICBpZiAoIChyYyA9IG9wcy0+cmVhZF9jcigwLCAmZHN0 LnZhbCwgY3R4dCkpICkKICAgICAgICAgICAgICAgICBnb3RvIGRvbmU7CiAgICAgICAgICAgICBi cmVhazsKLSAgICAgICAgY2FzZSA2OiAvKiBsbXN3ICovCisKKyAgICAgICAgY2FzZSBHUlA3X0FM TCg2KTogLyogbG1zdyAqLwogICAgICAgICAgICAgZmFpbF9pZihvcHMtPnJlYWRfY3IgPT0gTlVM TCk7CiAgICAgICAgICAgICBmYWlsX2lmKG9wcy0+d3JpdGVfY3IgPT0gTlVMTCk7CiAgICAgICAg ICAgICBnZW5lcmF0ZV9leGNlcHRpb25faWYoIW1vZGVfcmluZzAoKSwgRVhDX0dQLCAwKTsKQEAg LTUxNjksMTYgKzUxNzUsMjMgQEAgeDg2X2VtdWxhdGUoCiAgICAgICAgICAgICBpZiAoIChyYyA9 IG9wcy0+d3JpdGVfY3IoMCwgY3IwLCBjdHh0KSkgKQogICAgICAgICAgICAgICAgIGdvdG8gZG9u ZTsKICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIDc6IC8qIGludmxwZyAqLworCisg ICAgICAgIGNhc2UgR1JQN19NRU0oNyk6IC8qIGludmxwZyAqLwogICAgICAgICAgICAgZ2VuZXJh dGVfZXhjZXB0aW9uX2lmKCFtb2RlX3JpbmcwKCksIEVYQ19HUCwgMCk7CiAgICAgICAgICAgICBn ZW5lcmF0ZV9leGNlcHRpb25faWYoZWEudHlwZSAhPSBPUF9NRU0sIEVYQ19VRCk7CiAgICAgICAg ICAgICBmYWlsX2lmKG9wcy0+aW52bHBnID09IE5VTEwpOwogICAgICAgICAgICAgaWYgKCAocmMg PSBvcHMtPmludmxwZyhlYS5tZW0uc2VnLCBlYS5tZW0ub2ZmLCBjdHh0KSkgKQogICAgICAgICAg ICAgICAgIGdvdG8gZG9uZTsKICAgICAgICAgICAgIGJyZWFrOworCiAgICAgICAgIGRlZmF1bHQ6 CiAgICAgICAgICAgICBnb3RvIGNhbm5vdF9lbXVsYXRlOwogICAgICAgICB9CisKKyN1bmRlZiBH UlA3X0FMTAorI3VuZGVmIEdSUDdfTUVNCisjdW5kZWYgX0dSUDcKKwogICAgICAgICBicmVhazsK ICAgICB9CiAKLS0gCjIuMS40CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9y ZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==