From: Dario Faggioli <dario.faggioli@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xensource.com,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
osstest service owner <osstest-admin@xenproject.org>,
Julien Grall <julien.grall@gmail.com>,
Julien Grall <julien.grall@arm.com>,
andre.przywara@arm.com
Subject: Re: [xen-unstable-smoke test] 112957: regressions - trouble: broken/fail/pass
Date: Thu, 7 Sep 2017 01:36:36 +0200 [thread overview]
Message-ID: <1504740996.30217.14.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1709061224510.26407@sstabellini-ThinkPad-X260>
[-- Attachment #1.1: Type: text/plain, Size: 942 bytes --]
On Wed, 2017-09-06 at 12:29 -0700, Stefano Stabellini wrote:
> On Wed, 6 Sep 2017, Dario Faggioli wrote:
> >
> > Or, in general, make sense out of the fact that the stack pointer
> > register changes in such a way that, when we get back in
> > do_softirq(),
> > what's in the stack in the place where there was the 'cpu' local
> > variable has (at least in some circumstances) changed?
>
> I think yes, it could cause the smp_processor_id() mismatch.
>
Ok, then the patch was wrong (sorry again), and should stay reverted.
I still find the comment very confusing (if correct at all), and I'll
probably send a new patch to improve it.
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-06 23:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 13:49 [xen-unstable-smoke test] 112957: regressions - trouble: broken/fail/pass osstest service owner
2017-08-30 13:54 ` Andrew Cooper
2017-08-30 14:15 ` George Dunlap
2017-08-31 15:53 ` Wei Liu
2017-09-02 15:39 ` Julien Grall
2017-09-04 8:46 ` George Dunlap
2017-09-05 15:50 ` Dario Faggioli
2017-09-05 22:06 ` Stefano Stabellini
2017-09-06 10:27 ` Dario Faggioli
2017-09-06 19:29 ` Stefano Stabellini
2017-09-06 23:36 ` Dario Faggioli [this message]
2017-09-07 16:05 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504740996.30217.14.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=andre.przywara@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=julien.grall@gmail.com \
--cc=osstest-admin@xenproject.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).