From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 2/5] libxl: enable per-VCPU extratime
	flag for RTDS
Date: Thu, 14 Sep 2017 02:12:18 +0200
Message-ID: <1505347938.13935.2.camel@citrix.com>
References: <1504281532-3766-1-git-send-email-mengxu@cis.upenn.edu>
 <1504281532-3766-3-git-send-email-mengxu@cis.upenn.edu>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2250127857567505586=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1504281532-3766-3-git-send-email-mengxu@cis.upenn.edu>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Meng Xu <mengxu@cis.upenn.edu>, xen-devel@lists.xen.org
Cc: george.dunlap@eu.citrix.com, xumengpanda@gmail.com, ian.jackson@eu.citrix.com, wei.liu@citrix.com
List-Id: xen-devel@lists.xenproject.org

--===============2250127857567505586==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-Xd0uBtU3VcT0b0x1FfGw"

--=-Xd0uBtU3VcT0b0x1FfGw
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2017-09-01 at 11:58 -0400, Meng Xu wrote:
> Modify libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
> functions to support per-VCPU extratime flag
>=20
> Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
>=20
This patch looks ok to me.

Only one thing: in libxl_types.idl is, when its inside
libxl_domain_sched_params, marked as deprecated. I think it should be
moved out of that.

One (very) minor thing too:

> diff --git a/tools/libxl/libxl_sched.c b/tools/libxl/libxl_sched.c
> index faa604e..b76a29a 100644
> --- a/tools/libxl/libxl_sched.c
> +++ b/tools/libxl/libxl_sched.c
> @@ -558,6 +558,10 @@ static int sched_rtds_vcpu_get_all(libxl__gc
> *gc, uint32_t domid,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0for (i =3D 0; i < num_vcpus; i++) {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0scinfo->vcpus[i].pe=
riod =3D vcpus[i].u.rtds.period;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0scinfo->vcpus[i].bu=
dget =3D vcpus[i].u.rtds.budget;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (vcpus[i].u.rtds.flag=
s & XEN_DOMCTL_SCHEDRT_extra)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0scinfo=
->vcpus[i].extratime =3D 1;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0scinfo=
->vcpus[i].extratime =3D 0;
>
This can be:

 scinfo->vcpus[i].extratime =3D vcpus[i].u.rtds.flags & XEN_DOMCTL_SCHEDRT_=
extra ? 1 : 0

or:

 scinfo->vcpus[i].extratime =3D !!(vcpus[i].u.rtds.flags & XEN_DOMCTL_SCHED=
RT_extra);

Regards,
Dario=C2=A0
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-Xd0uBtU3VcT0b0x1FfGw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZucliAAoJEBZCeImluHPu410QALifgZnbj/U16ue6nEDavQOd
lw1JmesiTmHcoroJ+eB56plCN3/QZQ5UCXdP0XcMKqCaPaddgvDbjlyjwi55/pVQ
A1U5JFQ1zP56fXw0YexGTJwfE6Z5lH8R1HhMv+6lPcOLhx/xMfxejg6ibzhBAHLI
gkjqKNxEkRog/CT0Y9lcMInV8Gkj6BJ5We1Td0VjHKlTL/8PsDBpIqZ0ptxzIOOj
KcDtlNtkHFrUO9wpPdVxfYXitvLnFaOjP+qUYBCMlTbWS57tmxBJji6RRAoRWb7Z
D8bvTSX7xc7KjRXj45kbEC0dkywiUM+cR+Bjvm3cItXh3wTcdcNRbuQtR29BWEDI
t3OafR7JifIVTAjKhAIxQ6aAxZ1Xw51tAkb8NTiBjADYo0/Myc3PI7j3nJNFO5vH
vbB6oWppoM0YoVpb4Pb5tdPnlPVEXVDI98WpJwbjBuKPWhwR8WZH79z4QA675QeZ
bX4grOmg+sGdzkxNIJNXaQkWOnu3euNZX1+8Yj6d/Cmj/u+d/ZgakwCbAyyGhhIF
iPaqckiiVcH+YGURXlNbxvv9vvo5ICsy8MGPRhbi0tRa69pEgOYRdWE9SGAt87t7
VSoIMjqj7mLdJonnbiJEgecR38ezU35kZQ7UThA6ctZW8Rvc2do8aQUHQTa9L7yd
mYJlvMxj7AyO+ST/Y2Ga
=nbSu
-----END PGP SIGNATURE-----

--=-Xd0uBtU3VcT0b0x1FfGw--


--===============2250127857567505586==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============2250127857567505586==--