From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 2/5] libxl: enable per-VCPU extratime
	flag for RTDS
Date: Thu, 14 Sep 2017 02:16:35 +0200
Message-ID: <1505348195.13935.4.camel@citrix.com>
References: <1504281532-3766-1-git-send-email-mengxu@cis.upenn.edu>
 <1504281532-3766-3-git-send-email-mengxu@cis.upenn.edu>
 <CAENZ-+namY-SKVFyf_==cJX2H1mVWcEWrgx8YcYqEQd2cJvihg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7244171517207660598=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAENZ-+namY-SKVFyf_==cJX2H1mVWcEWrgx8YcYqEQd2cJvihg@mail.gmail.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Meng Xu <xumengpanda@gmail.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu@citrix.com>, Meng Xu <mengxu@cis.upenn.edu>
List-Id: xen-devel@lists.xenproject.org

--===============7244171517207660598==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-TYcBesV/rUfiRQz19VrF"

--=-TYcBesV/rUfiRQz19VrF
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2017-09-01 at 12:03 -0400, Meng Xu wrote:
> On Fri, Sep 1, 2017 at 11:58 AM, Meng Xu <mengxu@cis.upenn.edu>
> wrote:
> > @@ -705,6 +717,12 @@ static int sched_rtds_domain_set(libxl__gc
> > *gc, uint32_t domid,
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sdom.period =3D s=
cinfo->period;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (scinfo->budget !=3D LIBXL_DOMAIN_SCHE=
D_PARAM_BUDGET_DEFAULT)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sdom.budget =3D s=
cinfo->budget;
> > +=C2=A0=C2=A0=C2=A0=C2=A0if (scinfo->extratime !=3D
> > LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT) {
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (scinfo->extratime)
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0sdom.flags |=3D XEN_DOMCTL_SCHEDRT_extra;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0sdom.flags &=3D ~XEN_DOMCTL_SCHEDRT_extra;
> > +=C2=A0=C2=A0=C2=A0=C2=A0}
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (sched_rtds_validate_params(gc, sdom.p=
eriod, sdom.budget))
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return ERROR_INVA=
L;
>=20
>=20
> As you mentioned in the comment to the xl patch v1, I used
> LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT for extratime flag as what
> we did for period and budget. But the way we handle flags is exactly
> the same with the way we handle period and budget.
>=20
Mmm... and (since you say 'But') is that a problem?

> I'm ok with what it is in this patch, although I feel that we can
> kill the
> =C2=A0if (scinfo->extratime !=3D LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAU=
LT)
> because LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT is -1.
>=20
No, sorry, I don't understand what you mean here...

Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-TYcBesV/rUfiRQz19VrF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZucpjAAoJEBZCeImluHPutzcP/A+jAxH0NkHBG2s1nJpuM22L
AItuoTazKY2qHBEpZxS1CxUREJrFDGS6AETcOEhCNSlZ68hqm6GivjlUrGRLNROn
EFxV9W4gbTO/JxPxDBdr2gz/WNtmHJKvhXVCHa296xTBWSPSG/kwpebS2G2Qri1W
/hchTSn2jFIUkwWWyMQAWd/dAgnZCW3FA9PgJMdqNCW3NEBQq3/wN3+63l8iLS/D
OIyBtA2fT8KyxHyLoS9c5C6rJhl6l8VplSxA6FZfgGp5hWyU9k6HlEf9MGI1NuHq
U4cPGWS12IfE0BGKkB4ogbeAU8c/043CCqfjWXh/36GvWfUxspHGNl1ezeNCrCLo
0CNvuCIj/Qrd2ClSivu8nImjzelywC8rDkakjIg8xNv9uPQnpUrMn1CbdBZOZXww
HmOXMDIm9eUVXYe7Ruw0Rbg+EcOrx97AiiUqQXGhkpLI17TIUrQ3Sii7r0UH9VjI
M0PCXGB10Jn+YtBo4asdwBqt2gwq1Y8KwicQK+S4QCRqNa3Btew+gMLBwviRMWpu
xbTCgN7PtgaEd4tKCXPLWIWmyDvZLYQuvPepNcGL7WE13RQ6k0Qhc7UFYTMx4/ni
8pwiVjWDgbTr5LKeAzbaZwcYB6joqTJbwcoxfH/OR6STMz7bUofdiimIdFqoyeoJ
DK6dNg4nMkpnyXuaTu4U
=q2kF
-----END PGP SIGNATURE-----

--=-TYcBesV/rUfiRQz19VrF--


--===============7244171517207660598==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============7244171517207660598==--