From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1/3] credit2: libxc related changes to add support for runqueue per cpupool. Date: Thu, 14 Sep 2017 14:58:56 +0200 Message-ID: <1505393936.13935.15.camel@citrix.com> References: <1505177142-14864-1-git-send-email-anshulmakkar@gmail.com> <1505177142-14864-2-git-send-email-anshulmakkar@gmail.com> <47f9a7d0-7993-300c-8618-a5352f8b97a3@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2231685741988101362==" Return-path: In-Reply-To: <47f9a7d0-7993-300c-8618-a5352f8b97a3@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross , anshulmakkar , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, marmarek@invisiblethingslab.com, robert.vanvossen@dornerworks.com, tim@xen.org, josh.whitehead@dornerworks.com, mengxu@cis.upenn.edu, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============2231685741988101362== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-YHNqyNOBhhC5JqT++0xr" --=-YHNqyNOBhhC5JqT++0xr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-09-14 at 08:42 +0200, Juergen Gross wrote: > > --- a/tools/libxc/include/xenctrl.h > > +++ b/tools/libxc/include/xenctrl.h > > @@ -1077,17 +1077,21 @@ typedef struct xc_cpupoolinfo { > > =C2=A0 > > =C2=A0#define XC_CPUPOOL_POOLID_ANY 0xFFFFFFFF > > =C2=A0 > > +typedef xen_sysctl_sched_param_t xc_schedparam_t; > > + > > =C2=A0/** > > =C2=A0 * Create a new cpupool. > > =C2=A0 * > > =C2=A0 * @parm xc_handle a handle to an open hypervisor interface > > =C2=A0 * @parm ppoolid pointer to the new cpupool id (in/out) > > =C2=A0 * @parm sched_id id of scheduler to use for pool > > + * @parm sched_param parameter of the scheduler of the cpupool eg. > > runq for credit2 >=20 > I would drop "eg. runq for credit2" >=20 +1 > > --- a/tools/python/xen/lowlevel/xc/xc.c > > +++ b/tools/python/xen/lowlevel/xc/xc.c > > @@ -1704,6 +1704,7 @@ static PyObject *pyxc_cpupool_create(XcObject > > *self, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0PyObject *kwds) > > =C2=A0{ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uint32_t cpupool =3D XC_CPUPOOL_POOLID_AN= Y, sched =3D > > XEN_SCHEDULER_CREDIT; > > +=C2=A0=C2=A0=C2=A0=C2=A0xc_schedparam_t param; > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0static char *kwd_list[] =3D { "pool", "sc= hed", NULL }; >=20 > [..] > Another possibility would be to drop the cpupool python bindings > completely (which I would prefer, TBH). >=20 +1 Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-YHNqyNOBhhC5JqT++0xr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZun0RAAoJEBZCeImluHPu4JYQALaEYtmvwXI337M52ihoBKc6 mPg8Y/J34axB1u2tM8JS8eyI5C8JCOVBWqiopyZCsiRxMW8N3fon4lP4eftxrZJa 9HGWp1bn04uw8SFdS6dXcgNZRkcCTOuzTUHr22wkz8q9Ouus/bn/n23n3o/cyuUX 3nYlw5Smi2CwlpqHmuBuzcIMgnv/xWS6fogXAJo3Iv7rEn7EmhuV4BA1y4VaNhMt zhz7cD53ewXQ/1wWSbJ8L0R0uLCC5yvLRGqCShOWVdCXvzi7Z6mE6gvdkYjHd9HQ MnqckKiZUknOw9uCgnCuvOR/l1T04PZro0vG5+SGsEMVEx2qD3QzNGY+aH6e9Sef DFq/L36/GWWxhn1iZvfFh4WRoliESJ6/dtpmev0avMUdXuX0nlhKGVNvi6zOPWJB I9b04FydeCXQEGIy4XfApzgJZwAgC/xFxeOAxd58/pe7O+PQxUkkcx1lSmr9uD+U PtLkskStFhUXQHAaxnStgGNcHapK1xOtWk32m7/M7IGUek8EAA9ZCxeNHs21TFSr EnZGhl4UAex5YfZIZ6f3lyVSFzevgzn3NgFpFLXN5+FjjkgP604PAhRdmFG5vdcW ekkUGGg7wiK5vC0YercQl4W74qpZuu9bp2DQ3oX/6EwaKjTABzMiHezjQQ/9UH1Z zrW5hrDgElGKuME1dpLl =IXjt -----END PGP SIGNATURE----- --=-YHNqyNOBhhC5JqT++0xr-- --===============2231685741988101362== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============2231685741988101362==--