xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH 07/22] xentoolcore_restrict_all: Implement for libxendevicemodel
Date: Fri, 15 Sep 2017 19:48:44 +0100	[thread overview]
Message-ID: <1505501339-11965-8-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1505501339-11965-1-git-send-email-ian.jackson@eu.citrix.com>

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 tools/Rules.mk                              |  2 +-
 tools/libs/devicemodel/Makefile             |  3 ++-
 tools/libs/devicemodel/core.c               | 16 ++++++++++++++++
 tools/libs/devicemodel/private.h            |  3 +++
 tools/libs/devicemodel/xendevicemodel.pc.in |  2 +-
 5 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/tools/Rules.mk b/tools/Rules.mk
index 5e1c7cb..9b2fe36 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -129,7 +129,7 @@ LDLIBS_libxenforeignmemory = $(SHDEPS_libxenforeignmemory) $(XEN_LIBXENFOREIGNME
 SHLIB_libxenforeignmemory  = $(SHDEPS_libxenforeignmemory) -Wl,-rpath-link=$(XEN_LIBXENFOREIGNMEMORY)
 
 CFLAGS_libxendevicemodel = -I$(XEN_LIBXENDEVICEMODEL)/include $(CFLAGS_xeninclude)
-SHDEPS_libxendevicemodel = $(SHLIB_libxentoollog) $(SHLIB_xencall)
+SHDEPS_libxendevicemodel = $(SHLIB_libxentoollog) $(SHLIB_libxentoolcore) $(SHLIB_xencall)
 LDLIBS_libxendevicemodel = $(SHDEPS_libxendevicemodel) $(XEN_LIBXENDEVICEMODEL)/libxendevicemodel$(libextension)
 SHLIB_libxendevicemodel  = $(SHDEPS_libxendevicemodel) -Wl,-rpath-link=$(XEN_LIBXENDEVICEMODEL)
 
diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
index f0e1e6c..3f7efd5 100644
--- a/tools/libs/devicemodel/Makefile
+++ b/tools/libs/devicemodel/Makefile
@@ -8,6 +8,7 @@ SHLIB_LDFLAGS += -Wl,--version-script=libxendevicemodel.map
 CFLAGS   += -Werror -Wmissing-prototypes
 CFLAGS   += -I./include $(CFLAGS_xeninclude)
 CFLAGS   += $(CFLAGS_libxentoollog)
+CFLAGS   += $(CFLAGS_libxentoolcore)
 CFLAGS   += $(CFLAGS_libxencall)
 
 SRCS-y                 += core.c
@@ -63,7 +64,7 @@ libxendevicemodel.so.$(MAJOR): libxendevicemodel.so.$(MAJOR).$(MINOR)
 	$(SYMLINK_SHLIB) $< $@
 
 libxendevicemodel.so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxendevicemodel.map
-	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxencall) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxencall) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS)
 
 .PHONY: install
 install: build
diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c
index 2093884..3292e53 100644
--- a/tools/libs/devicemodel/core.c
+++ b/tools/libs/devicemodel/core.c
@@ -21,6 +21,16 @@
 
 #include "private.h"
 
+static int all_restrict_cb(Xentoolcore__Active_Handle *ah, uint32_t domid) {
+    xendevicemodel_handle *dmod = CONTAINER_OF(ah, *dmod, tc_ah);
+
+    if (dmod->fd < 0)
+        /* just in case */
+        return 0;
+
+    return xendevicemodel_restrict(dmod, domid);
+}
+
 xendevicemodel_handle *xendevicemodel_open(xentoollog_logger *logger,
                                            unsigned open_flags)
 {
@@ -30,6 +40,10 @@ xendevicemodel_handle *xendevicemodel_open(xentoollog_logger *logger,
     if (!dmod)
         return NULL;
 
+    dmod->fd = -1;
+    dmod->tc_ah.restrict_callback = all_restrict_cb;
+    xentoolcore__register_active_handle(&dmod->tc_ah);
+
     dmod->flags = open_flags;
     dmod->logger = logger;
     dmod->logger_tofree = NULL;
@@ -55,6 +69,7 @@ xendevicemodel_handle *xendevicemodel_open(xentoollog_logger *logger,
 err:
     xtl_logger_destroy(dmod->logger_tofree);
     xencall_close(dmod->xcall);
+    xentoolcore__deregister_active_handle(&dmod->tc_ah);
     free(dmod);
     return NULL;
 }
@@ -69,6 +84,7 @@ int xendevicemodel_close(xendevicemodel_handle *dmod)
     rc = osdep_xendevicemodel_close(dmod);
 
     xencall_close(dmod->xcall);
+    xentoolcore__deregister_active_handle(&dmod->tc_ah);
     xtl_logger_destroy(dmod->logger_tofree);
     free(dmod);
     return rc;
diff --git a/tools/libs/devicemodel/private.h b/tools/libs/devicemodel/private.h
index 4ce5aac..c4a225f 100644
--- a/tools/libs/devicemodel/private.h
+++ b/tools/libs/devicemodel/private.h
@@ -7,11 +7,14 @@
 #include <xendevicemodel.h>
 #include <xencall.h>
 
+#include <xentoolcore_internal.h>
+
 struct xendevicemodel_handle {
     xentoollog_logger *logger, *logger_tofree;
     unsigned int flags;
     xencall_handle *xcall;
     int fd;
+    Xentoolcore__Active_Handle tc_ah;
 };
 
 struct xendevicemodel_buf {
diff --git a/tools/libs/devicemodel/xendevicemodel.pc.in b/tools/libs/devicemodel/xendevicemodel.pc.in
index ed08f83..8bd04fa 100644
--- a/tools/libs/devicemodel/xendevicemodel.pc.in
+++ b/tools/libs/devicemodel/xendevicemodel.pc.in
@@ -7,4 +7,4 @@ Description: The Xendevicemodel library for Xen hypervisor
 Version: @@version@@
 Cflags: -I${includedir} @@cflagslocal@@
 Libs: @@libsflag@@${libdir} -lxendevicemodel
-Requires.private: xentoollog,xencall
+Requires.private: xentoolcore,xentoollog,xencall
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-09-15 18:48 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15 18:48 [PATCH 00/22] Provide some actual restriction of qemu Ian Jackson
2017-09-15 18:48 ` [PATCH 01/22] xen: Provide XEN_DMOP_remote_shutdown Ian Jackson
2017-09-18  9:44   ` Jan Beulich
2017-09-18 13:57     ` Ian Jackson
2017-09-18 14:16       ` Jan Beulich
2017-09-18 14:18   ` Wei Liu
2017-09-15 18:48 ` [PATCH 02/22] tools: libxendevicemodel: Provide xendevicemodel_shutdown Ian Jackson
2017-09-18 14:18   ` Wei Liu
2017-09-18 17:09     ` Ian Jackson
2017-09-15 18:48 ` [PATCH 03/22] xentoolcore, _restrict_all: Introduce new library and implementation Ian Jackson
2017-09-18 14:52   ` Wei Liu
2017-09-18 16:08     ` Ian Jackson
2017-09-19  8:52       ` Wei Liu
2017-09-19  8:52   ` Wei Liu
2017-09-19 10:42     ` Ian Jackson
2017-09-19  9:33   ` Wei Liu
2017-09-19 10:47     ` Ian Jackson
2017-09-19 10:57       ` Wei Liu
2017-09-19 11:04         ` Ian Jackson
2017-09-20 15:24           ` Wei Liu
2017-09-15 18:48 ` [PATCH 04/22] tools: qemu-xen build: prepare to link against xentoolcore Ian Jackson
2017-09-19  8:52   ` Wei Liu
2017-09-15 18:48 ` [PATCH 05/22] libxl: #include "xentoolcore_internal.h" Ian Jackson
2017-09-19  8:53   ` Wei Liu
2017-09-15 18:48 ` [PATCH 06/22] tools: move CONTAINER_OF to xentoolcore_internal.h Ian Jackson
2017-09-19  8:53   ` Wei Liu
2017-09-15 18:48 ` Ian Jackson [this message]
2017-09-19  9:37   ` [PATCH 07/22] xentoolcore_restrict_all: Implement for libxendevicemodel Wei Liu
2017-09-15 18:48 ` [PATCH 08/22] xentoolcore_restrict_all: "Implement" for libxencall Ian Jackson
2017-09-19  9:38   ` Wei Liu
2017-09-19 10:49     ` Ian Jackson
2017-09-15 18:48 ` [PATCH 09/22] xentoolcore_restrict: Break out xentoolcore__restrict_by_dup2_null Ian Jackson
2017-09-19  9:38   ` Wei Liu
2017-09-15 18:48 ` [PATCH 10/22] xentoolcore_restrict_all: Implement for libxenforeignmemory Ian Jackson
2017-09-19  9:40   ` Wei Liu
2017-09-19 10:51     ` Ian Jackson
2017-09-19 10:58       ` Wei Liu
2017-09-19 11:08         ` Ian Jackson
2017-09-20 15:25           ` Wei Liu
2017-09-21 16:18             ` Ian Jackson
2017-09-15 18:48 ` [PATCH 11/22] xentoolcore_restrict_all: Declare problems due to no evtchn support Ian Jackson
2017-09-19  9:40   ` Wei Liu
2017-09-15 18:48 ` [PATCH 12/22] xentoolcore_restrict_all: "Implement" for xengnttab Ian Jackson
2017-09-19  9:41   ` Wei Liu
2017-09-15 18:48 ` [PATCH 13/22] tools/xenstore: get_handle: use "goto err" error handling style Ian Jackson
2017-09-19  9:42   ` Wei Liu
2017-09-15 18:48 ` [PATCH 14/22] tools/xenstore: get_handle: Allocate struct before opening fd Ian Jackson
2017-09-19  9:43   ` Wei Liu
2017-09-15 18:48 ` [PATCH 15/22] xentoolcore_restrict_all: "Implement" for xenstore Ian Jackson
2017-09-19  9:43   ` Wei Liu
2017-09-15 18:48 ` [PATCH 16/22] xentoolcore, _restrict_all: Document implementation "complete" Ian Jackson
2017-09-18 14:49   ` Wei Liu
2017-09-18 16:06     ` Ian Jackson
2017-09-15 18:48 ` [PATCH 17/22] xl, libxl: Provide dm_restrict Ian Jackson
2017-09-19  9:48   ` Wei Liu
2017-09-19 10:54     ` Ian Jackson
2017-09-15 18:48 ` [PATCH 18/22] libxl: Rationalise calculation of user to run qemu as Ian Jackson
2017-09-18 14:49   ` Wei Liu
2017-09-15 18:48 ` [PATCH 19/22] libxl: libxl__dm_runas_helper: return pwd Ian Jackson
2017-09-19  9:48   ` Wei Liu
2017-09-15 18:48 ` [PATCH 20/22] libxl: userlookup_helper_getpwnam rename and turn into a macro Ian Jackson
2017-09-19  9:50   ` Wei Liu
2017-09-19 10:57     ` Ian Jackson
2017-09-15 18:48 ` [PATCH 21/22] libxl: dm_restrict: Support uid range user Ian Jackson
2017-09-15 18:48 ` [PATCH 22/22] RFC: tools: xentoolcore_restrict_all: use domid_t Ian Jackson
2017-09-19 10:02   ` Wei Liu
2017-09-19 11:01     ` Ian Jackson
2017-09-20 15:28       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505501339-11965-8-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).