From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 3/3] xen: RCU: make the period of the idle
 timer adaptive.
Date: Tue, 26 Sep 2017 19:50:50 +0200
Message-ID: <1506448250.27663.36.camel@citrix.com>
References: <150549814200.30442.14095065559616595274.stgit@Solace.fritz.box>
 <150549849185.30442.2268783824567221047.stgit@Solace.fritz.box>
 <59CA8D5C020000780017FE08@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5211534783580567794=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=4350faf84=dario.faggioli@citrix.com>)
 id 1dwu0Z-0003RH-IH
 for xen-devel@lists.xenproject.org; Tue, 26 Sep 2017 17:50:59 +0000
In-Reply-To: <59CA8D5C020000780017FE08@prv-mh.provo.novell.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Andrew Cooper <andrew.cooper3@citrix.com>, Tim Deegan <tim@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

--===============5211534783580567794==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-AGj/NDN17A1RQC+mQZLl"

--=-AGj/NDN17A1RQC+mQZLl
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2017-09-26 at 09:24 -0600, Jan Beulich wrote:
> > > > On 15.09.17 at 20:01, <dario.faggioli@citrix.com> wrote:
> > @@ -495,8 +507,18 @@ void rcu_idle_timer_stop()
> > =C2=A0
> > =C2=A0static void rcu_idle_timer_handler(void* data)
> > =C2=A0{
> > -=C2=A0=C2=A0=C2=A0=C2=A0/* Nothing, really... Just count the number of=
 times we fire
> > */
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0perfc_incr(rcu_idle_timer);
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0if ( !cpumask_empty(&rcu_ctrlblk.cpumask) )
> > +=C2=A0=C2=A0=C2=A0=C2=A0{
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0idle_timer_period =3D =
min_t(s_time_t, IDLE_TIMER_PERIOD_MAX,
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0idle_timer_peri=
od +
> > IDLE_TIMER_PERIOD_INCR);
> > +=C2=A0=C2=A0=C2=A0=C2=A0}
> > +=C2=A0=C2=A0=C2=A0=C2=A0else
> > +=C2=A0=C2=A0=C2=A0=C2=A0{
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0idle_timer_period =3D =
max_t(s_time_t, IDLE_TIMER_PERIOD_MIN,
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0idle_timer_peri=
od -
> > IDLE_TIMER_PERIOD_DECR);
> > +=C2=A0=C2=A0=C2=A0=C2=A0}
>=20
> Pointless braces. And do you really need min_t()/max_t() here,
> rather than just min()/max()?
>=20
I probably can. This must be a leftover from a version when the time of
idle_timer_period, and of the IDLE_TIMER_PERIOD_{MIN,MAX} constants
wasn't matching.

Sorry!

Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-AGj/NDN17A1RQC+mQZLl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZypN7AAoJEBZCeImluHPuwe0P/jD0ltDut3Kf5d2LOreNl/Zx
PWHuDumljepu8skB09bRDStcgYjoKX5UK3GhM1EqmoRlMOq646WEUP4lHAl5yCQd
azmqgAQA5Bd50aSpj8ut/eNWe3A8JRgTMhoSMYtk/yIwYyPAoogfRnEDnzcI3aRX
BQcmAGV0nzwJBH45TbmzOENRT8tI35tVf84qV0QnrCiDU7p6iqsvhrkFnU/9zaCs
gW6bO/oCem+g7uvwOzCWKJ2HhdYJOlJ+K0Nn/XYR47flnJFkGQ6rK2JlEAN1fQSv
0TqKvL9J2ualFVB4v+mY77z1wd2VtDgTUXs25uTLitwnUGHPCBrWndjqcTEjYMdK
wzLpiVV0VK8wR+n69+Or2AmqehJI4KGqfH5S4/AB7WDGJc1GxFzkLt8xeviotbaF
oiDSVPfSo1mfkLgqO4oxEYBg2l46BWG7bddGm/lWjK/vzLWdW3sDzWWYb2/y43Gj
BP/wWQC/LIL0/hob/ES6/QZpAgMGOVcnXhIwYOIjJrM+qfXXhU8WR6I5PYqX2SSw
gtNrrjSR5uR3kpo+wEJl1NiZlAcWAEI9JhMwQrf3FTS6rXPGo6rwuQ4h+iyMohmg
NFSlWhBCFZzP1mVzNjcikbi0F/7TIG6iwcgztMA6hFuGASgUr5bRzJMROXOUd99E
eu/3yo6VdcK88HxtP2cp
=PBk/
-----END PGP SIGNATURE-----

--=-AGj/NDN17A1RQC+mQZLl--


--===============5211534783580567794==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============5211534783580567794==--