From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 17/27 v11] xen/arm: vpl011: Add a new handle_console_tty function in xenconsole
Date: Wed, 27 Sep 2017 11:43:26 +0530 [thread overview]
Message-ID: <1506492816-25954-18-git-send-email-bhupinder.thakur@linaro.org> (raw)
In-Reply-To: <1506492816-25954-1-git-send-email-bhupinder.thakur@linaro.org>
This patch introduces a new handle_console_tty function. This function
performs read/write from/to console tty.
Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Wei Liu <wei.liu2@citrix.com>
---
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>
Changes since v5:
- Split this change in a separate patch.
tools/console/daemon/io.c | 35 +++++++++++++++++++----------------
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c
index c361b42..5c6da31 100644
--- a/tools/console/daemon/io.c
+++ b/tools/console/daemon/io.c
@@ -1130,6 +1130,24 @@ static void maybe_add_console_tty_fd(struct console *con)
}
}
+static void handle_console_tty(struct console *con)
+{
+ if (con->master_fd != -1 && con->master_pollfd_idx != -1) {
+ if (fds[con->master_pollfd_idx].revents &
+ ~(POLLIN|POLLOUT|POLLPRI))
+ console_handle_broken_tty(con, domain_is_valid(con->d->domid));
+ else {
+ if (fds[con->master_pollfd_idx].revents &
+ POLLIN)
+ handle_tty_read(con);
+ if (fds[con->master_pollfd_idx].revents &
+ POLLOUT)
+ handle_tty_write(con);
+ }
+ }
+ con->master_pollfd_idx = -1;
+}
+
void handle_io(void)
{
int ret;
@@ -1260,22 +1278,7 @@ void handle_io(void)
handle_console_ring(con);
- if (con->master_fd != -1 && con->master_pollfd_idx != -1) {
- if (fds[con->master_pollfd_idx].revents &
- ~(POLLIN|POLLOUT|POLLPRI))
- console_handle_broken_tty(con,
- domain_is_valid(d->domid));
- else {
- if (fds[con->master_pollfd_idx].revents &
- POLLIN)
- handle_tty_read(con);
- if (fds[con->master_pollfd_idx].revents &
- POLLOUT)
- handle_tty_write(con);
- }
- }
-
- con->master_pollfd_idx = -1;
+ handle_console_tty(con);
if (d->last_seen != enum_pass)
shutdown_domain(d);
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-27 6:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 6:13 [PATCH 00/27 v11] SBSA UART emulation support in Xen Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 01/27 v11] xen/arm: vpl011: Define common ring buffer helper functions in console.h Bhupinder Thakur
2017-09-29 20:10 ` Stefano Stabellini
2017-09-29 21:35 ` Julien Grall
2017-09-29 21:46 ` Stefano Stabellini
2017-10-03 22:27 ` Stefano Stabellini
2017-09-27 6:13 ` [PATCH 02/27 v11] xen/arm: vpl011: Add SBSA UART emulation in Xen Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 03/27 v11] xen/arm: vpl011: Allocate a new GFN in the toolstack for vuart Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 04/27 v11] xen/arm: vpl011: Add support for vuart in libxl Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 05/27 v11] xen/arm: vpl011: Rearrange xen header includes in alphabetical order in domctl.c Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 06/27 v11] xen/arm: vpl011: Add a new domctl API to initialize vpl011 Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 07/27 v11] xen/arm: vpl011: Add a new vuart node in the xenstore Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 08/27 v11] xen/arm: vpl011: Modify xenconsole to define and use a new console structure Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 09/27 v11] xen/arm: vpl011: Rename the console structure field conspath to xspath Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 10/27 v11] xen/arm: vpl011: Modify xenconsole functions to take console structure as input Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 11/27 v11] xen/arm: vpl011: Add a new console_init function in xenconsole Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 12/27 v11] xen/arm: vpl011: Add a new buffer_available " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 13/27 v11] xen/arm: vpl011: Add a new maybe_add_console_evtchn_fd " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 14/27 v11] xen/arm: vpl011: Add a new maybe_add_console_tty_fd " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 15/27 v11] xen/arm: vpl011: Add a new console_evtchn_unmask " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 16/27 v11] xen/arm: vpl011: Add a new handle_console_ring " Bhupinder Thakur
2017-09-27 6:13 ` Bhupinder Thakur [this message]
2017-09-27 6:13 ` [PATCH 18/27 v11] xen/arm: vpl011: Add a new console_cleanup " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 19/27 v11] xen/arm: vpl011: Add a new console_open_log " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 20/27 v11] xen/arm: vpl011: Add a new console_close_evtchn " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 21/27 v11] xen/arm: vpl011: Add support for multiple consoles " Bhupinder Thakur
2017-10-04 14:03 ` Boris Ostrovsky
2017-10-04 14:06 ` Wei Liu
2017-10-04 14:28 ` Boris Ostrovsky
2017-10-04 14:29 ` Wei Liu
2017-10-04 14:52 ` Boris Ostrovsky
2017-09-27 6:13 ` [PATCH 22/27 v11] xen/arm: vpl011: Add support for vuart console " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 23/27 v11] xen/arm: vpl011: Add a new vuart console type to xenconsole client Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 24/27 v11] xen/arm: vpl011: Add a pl011 uart DT node in the guest device tree Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 25/27 v11] xen/arm: vpl011: Update documentation for vuart console support Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 26/27 v11] xen/arm: vpl011: Fix the slow early console SBSA UART output Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 27/27 v11] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt Bhupinder Thakur
2017-10-09 17:18 ` Andre Przywara
2017-10-12 9:33 ` Bhupinder Thakur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506492816-25954-18-git-send-email-bhupinder.thakur@linaro.org \
--to=bhupinder.thakur@linaro.org \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).