From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 03/27 v11] xen/arm: vpl011: Allocate a new GFN in the toolstack for vuart
Date: Wed, 27 Sep 2017 11:43:12 +0530 [thread overview]
Message-ID: <1506492816-25954-4-git-send-email-bhupinder.thakur@linaro.org> (raw)
In-Reply-To: <1506492816-25954-1-git-send-email-bhupinder.thakur@linaro.org>
Allocate a new gfn to be used as a ring buffer between xenconsole
and Xen for sending/receiving pl011 console data.
Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Wei Liu <wei.liu2@citrix.com>
---
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>
Changes since v4:
- Removed xc_get_vuart_gfn() as it is not required since the vpl011 initialization
function which used this API has been moved to after gfn is allocated.
- I have included the reviewed-by and acked-by tags as there is no change in the
logic.
Changes since v3:
- Added a new helper function xc_get_vuart_gfn() to return the GFN allocated for
vpl011.
- Since a new function has been added in this patch, I have not included Stefano's
reviewed-by and Wei's acked-by tags.
Changes since v2:
- Removed the DOMCTL call to set the GFN as now this information is passed
in the DOMCTL call to initialize vpl011 emulation.
tools/libxc/include/xc_dom.h | 2 ++
tools/libxc/xc_dom_arm.c | 5 ++++-
tools/libxc/xc_dom_boot.c | 2 ++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/xc_dom.h
index ce47058..6e06ef1 100644
--- a/tools/libxc/include/xc_dom.h
+++ b/tools/libxc/include/xc_dom.h
@@ -216,6 +216,8 @@ struct xc_dom_image {
/* Extra SMBIOS structures passed to HVMLOADER */
struct xc_hvm_firmware_module smbios_module;
+
+ xen_pfn_t vuart_gfn;
};
/* --- pluggable kernel loader ------------------------------------- */
diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c
index e669fb0..98200ae 100644
--- a/tools/libxc/xc_dom_arm.c
+++ b/tools/libxc/xc_dom_arm.c
@@ -26,10 +26,11 @@
#include "xg_private.h"
#include "xc_dom.h"
-#define NR_MAGIC_PAGES 3
+#define NR_MAGIC_PAGES 4
#define CONSOLE_PFN_OFFSET 0
#define XENSTORE_PFN_OFFSET 1
#define MEMACCESS_PFN_OFFSET 2
+#define VUART_PFN_OFFSET 3
#define LPAE_SHIFT 9
@@ -85,10 +86,12 @@ static int alloc_magic_pages(struct xc_dom_image *dom)
dom->console_pfn = base + CONSOLE_PFN_OFFSET;
dom->xenstore_pfn = base + XENSTORE_PFN_OFFSET;
+ dom->vuart_gfn = base + VUART_PFN_OFFSET;
xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn);
xc_clear_domain_page(dom->xch, dom->guest_domid, dom->xenstore_pfn);
xc_clear_domain_page(dom->xch, dom->guest_domid, base + MEMACCESS_PFN_OFFSET);
+ xc_clear_domain_page(dom->xch, dom->guest_domid, base + VUART_PFN_OFFSET);
xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_PFN,
dom->console_pfn);
xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_STORE_PFN,
diff --git a/tools/libxc/xc_dom_boot.c b/tools/libxc/xc_dom_boot.c
index c3b44dd..8a376d0 100644
--- a/tools/libxc/xc_dom_boot.c
+++ b/tools/libxc/xc_dom_boot.c
@@ -226,6 +226,8 @@ int xc_dom_boot_image(struct xc_dom_image *dom)
return rc;
if ( (rc = clear_page(dom, dom->xenstore_pfn)) != 0 )
return rc;
+ if ( (rc = clear_page(dom, dom->vuart_gfn)) != 0 )
+ return rc;
/* start info page */
if ( dom->arch_hooks->start_info )
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-27 6:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 6:13 [PATCH 00/27 v11] SBSA UART emulation support in Xen Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 01/27 v11] xen/arm: vpl011: Define common ring buffer helper functions in console.h Bhupinder Thakur
2017-09-29 20:10 ` Stefano Stabellini
2017-09-29 21:35 ` Julien Grall
2017-09-29 21:46 ` Stefano Stabellini
2017-10-03 22:27 ` Stefano Stabellini
2017-09-27 6:13 ` [PATCH 02/27 v11] xen/arm: vpl011: Add SBSA UART emulation in Xen Bhupinder Thakur
2017-09-27 6:13 ` Bhupinder Thakur [this message]
2017-09-27 6:13 ` [PATCH 04/27 v11] xen/arm: vpl011: Add support for vuart in libxl Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 05/27 v11] xen/arm: vpl011: Rearrange xen header includes in alphabetical order in domctl.c Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 06/27 v11] xen/arm: vpl011: Add a new domctl API to initialize vpl011 Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 07/27 v11] xen/arm: vpl011: Add a new vuart node in the xenstore Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 08/27 v11] xen/arm: vpl011: Modify xenconsole to define and use a new console structure Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 09/27 v11] xen/arm: vpl011: Rename the console structure field conspath to xspath Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 10/27 v11] xen/arm: vpl011: Modify xenconsole functions to take console structure as input Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 11/27 v11] xen/arm: vpl011: Add a new console_init function in xenconsole Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 12/27 v11] xen/arm: vpl011: Add a new buffer_available " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 13/27 v11] xen/arm: vpl011: Add a new maybe_add_console_evtchn_fd " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 14/27 v11] xen/arm: vpl011: Add a new maybe_add_console_tty_fd " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 15/27 v11] xen/arm: vpl011: Add a new console_evtchn_unmask " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 16/27 v11] xen/arm: vpl011: Add a new handle_console_ring " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 17/27 v11] xen/arm: vpl011: Add a new handle_console_tty " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 18/27 v11] xen/arm: vpl011: Add a new console_cleanup " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 19/27 v11] xen/arm: vpl011: Add a new console_open_log " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 20/27 v11] xen/arm: vpl011: Add a new console_close_evtchn " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 21/27 v11] xen/arm: vpl011: Add support for multiple consoles " Bhupinder Thakur
2017-10-04 14:03 ` Boris Ostrovsky
2017-10-04 14:06 ` Wei Liu
2017-10-04 14:28 ` Boris Ostrovsky
2017-10-04 14:29 ` Wei Liu
2017-10-04 14:52 ` Boris Ostrovsky
2017-09-27 6:13 ` [PATCH 22/27 v11] xen/arm: vpl011: Add support for vuart console " Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 23/27 v11] xen/arm: vpl011: Add a new vuart console type to xenconsole client Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 24/27 v11] xen/arm: vpl011: Add a pl011 uart DT node in the guest device tree Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 25/27 v11] xen/arm: vpl011: Update documentation for vuart console support Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 26/27 v11] xen/arm: vpl011: Fix the slow early console SBSA UART output Bhupinder Thakur
2017-09-27 6:13 ` [PATCH 27/27 v11] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt Bhupinder Thakur
2017-10-09 17:18 ` Andre Przywara
2017-10-12 9:33 ` Bhupinder Thakur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506492816-25954-4-git-send-email-bhupinder.thakur@linaro.org \
--to=bhupinder.thakur@linaro.org \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).