From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1/2] xen/credit2: add missing unlock Date: Wed, 27 Sep 2017 14:10:51 +0200 Message-ID: <1506514251.17428.4.camel@citrix.com> References: <20170927114622.14789-1-wei.liu2@citrix.com> <20170927114622.14789-2-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5994228805100507451==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxBBb-0006jx-2p for xen-devel@lists.xenproject.org; Wed, 27 Sep 2017 12:11:31 +0000 In-Reply-To: <20170927114622.14789-2-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu , Xen-devel Cc: George Dunlap List-Id: xen-devel@lists.xenproject.org --===============5994228805100507451== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-+GlT+tzRsgSogeT7v2c7" --=-+GlT+tzRsgSogeT7v2c7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-09-27 at 12:46 +0100, Wei Liu wrote: > Coverity-ID: 1418531 >=20 > Signed-off-by: Wei Liu > --- > diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c > index d33c881c3d..18f39cafe4 100644 > --- a/xen/common/sched_credit2.c > +++ b/xen/common/sched_credit2.c > @@ -2831,6 +2831,7 @@ csched2_dom_cntl( > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0if ( op->u.credit2.cap > 100 * sdom->nr_vcpus ) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0rc =3D -EINVAL; > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0write_unlock_irqrestore(&prv->lock, flags); > Indeed... :-/ Reviewed-by: Dario Faggioli Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-+GlT+tzRsgSogeT7v2c7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZy5VLAAoJEBZCeImluHPumuAQAIJcgG4SqhzRRPi1IjB+ZTYI zEur4zggClfcQ4A0TIx6MVsFz0Q8Tfx9Mi9kuBvsTp5utiKNlfPVIWXhmMOHmPtU z+AFu4vlIm1FWcN9gwJxnjdap6dEHpVa4VarszyLn/O1OrKCxOCxrHskpe5w9EEB Lyq292vkk4vYnuQPYXxVIYoD795n40rCfDjnkvKp/vccXVIni+WT8scdpgwoHPH3 R/hUKTDf8Oy45HFl0NFq8oD3xOznkaoLAD4GA2KnCENIuYRRudRpdMPSj5urri4L f7q8FNvlg28YvJZJYitVEDwHx2TNiowuY0khvjOn9RPxS7TqCaJ/5H1B03/F9V/T ykijWRoKedgIlhlGWESi2XAhUbtMyTKnrxp089L64C4iUjac9ih0AUH3FBGWsVnK 07S/VRFLG0HMV8MBGIxhahfLnDdrwcnA2wzUsl1ijGB0Zqx/muwfCJcI0aXnsQJC gnoiSIpSIIt7nrYTwgnSFnRMnHS2dmmBXVh6Q4+u3NGBx1PA8XSFWCCwDOIC+ulb u8kFtoqZ81oqBgrqpfQmT1X+zg8fUqa84Kl50fGmD955QrPkjXRAMP7FCxP1NcLc VZKeFN35AZtxgzY75LKBS93d8BAuUdflbQkovKuTP4DDv0FYAr/eTU7tqWZLVeLC 84zO/Cys6lnNLFAS72Gl =DGZ1 -----END PGP SIGNATURE----- --=-+GlT+tzRsgSogeT7v2c7-- --===============5994228805100507451== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5994228805100507451==--