From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 1/3] xen: timers: don't miss a timer event because of stop_timer() Date: Thu, 28 Sep 2017 11:51:28 +0200 Message-ID: <1506592288.5001.5.camel@citrix.com> References: <150549814200.30442.14095065559616595274.stgit@Solace.fritz.box> <150549847722.30442.110948122518687861.stgit@Solace.fritz.box> <59CA8789020000780017FDDC@prv-mh.provo.novell.com> <1506449460.27663.37.camel@citrix.com> <59CB7B5D0200007800180006@prv-mh.provo.novell.com> <1506507507.17428.1.camel@citrix.com> <59CB9A02020000780018008D@prv-mh.provo.novell.com> <1506519589.17428.8.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8052690258811307059==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxVUD-0005ug-Me for xen-devel@lists.xenproject.org; Thu, 28 Sep 2017 09:52:05 +0000 In-Reply-To: <1506519589.17428.8.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Stefano Stabellini , George Dunlap , Andrew Cooper , TimDeegan , Julien Grall , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============8052690258811307059== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-qWKLBmaGAF7npmUbS0Hj" --=-qWKLBmaGAF7npmUbS0Hj Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-09-27 at 15:39 +0200, Dario Faggioli wrote: > On Wed, 2017-09-27 at 04:30 -0600, Jan Beulich wrote: > > =C2=A0Or wait - > > wouldn't all you need be to avoid calling stop_timer() in the > > call tree above, if the timer's expiry has passed (suitably > > explained in a comment)? > >=20 > Yes. For the reason stated above, I addressed the problem at the > generic code level. If that doesn't fly, I'll do like this. I had > thought about that, and although I haven't tried, I think it works > for > this case. >=20 Anyway, given the timing, I'll send a v2 of this series, where I do things as suggested above. I may want to try again to persuade you (and others) that this needs to be changed in timer's code. But that will be for another time. :-) Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-qWKLBmaGAF7npmUbS0Hj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZzMYgAAoJEBZCeImluHPuMHgQAMPQ9F9NQ8H07BlL8RDUjcHR tAN7O9F01AbpqQOySsXL1zfTgnTYPDieiZwWWn0IyC+P+OaTH4ryKANvRvxzBeSm zyaAhIJGUwgk3BeByfkMcX3K264MnyNU7k6nchq8pAvkxzKhl4zGvJKNT6npcuw3 h4JMNiUDDkbvKROlZBxSaj2Nk5z+dr+l+u0myXKHv1A+9dlEInm07CD6DldcXrBN 0LNVz8gT+mrh55ofelG3GSKcj5af2tyjUMwbrgABMe6DR6yuIhcJZyrVdj2Hjd+V Z24J7G1v3wcJFmwKUIMSucAeRQGz90rtFc8t1BvPdFCKvs6rW8BRdc3BnFr1n4K2 /Jzk3L8+uZ0/Kh5pDuynKheIDdmekN2fa35KBR70DhTF5/WaW3gpufIKHCr374xi Vdjyx9JyksCinNhhCbmdujkzjb9DBMDVYugng6TNKi0ebstS1zty9H97IPKSagzH aM/veU8E8D4ED2G9w3zfj9URqWlDQzQ2WtcScJaJNjcfCLGiaWQmEZQkPQdUoOWp PPL95QmcgT8WDC13ZXthvAOfF/ztBPXEgwgmz8tY46xdll6KjUKcb/yRqMVBRcbd ttkazLFDvEK4LUctDSlgP7i7SWCxNZ39NLBrqcd4vuX6qzC9YDqDZeCHx0q0VLwg HM93rpgrr58v7uPmk6jh =5/9A -----END PGP SIGNATURE----- --=-qWKLBmaGAF7npmUbS0Hj-- --===============8052690258811307059== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============8052690258811307059==--