From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen Devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Glenn Enright <glenn@rimuhosting.com>
Subject: [PATCH XTF 2/4] build: Drop unnecessary register clobbers
Date: Thu, 28 Sep 2017 11:59:30 +0100 [thread overview]
Message-ID: <1506596372-24393-2-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1506596372-24393-1-git-send-email-andrew.cooper3@citrix.com>
The code in question is executing __HYPERVISOR_multicall which is 2-parameter
hypercall, which means that args 3-6 are preserved (as opposed to the
arguments in the multicall_entry_t list, which are clobbered).
GCC 4.4 in CentOS 6 can't cope with the ebp clobber.
Reported-by: Glenn Enright <glenn@rimuhosting.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
tests/xsa-213/main.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tests/xsa-213/main.c b/tests/xsa-213/main.c
index 34eac06..6ecaf11 100644
--- a/tests/xsa-213/main.c
+++ b/tests/xsa-213/main.c
@@ -96,12 +96,6 @@ static long multi_iret_call(multicall_entry_t *multi, size_t nr)
#else
"D" (multi), "S" (nr)
#endif
- :
-#ifdef __i386__
- "edx", "esi", "edi", "ebp"
-#else
- "rdx", "r10", "r8", "r9"
-#endif
);
return rc;
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-28 10:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 1:43 Building xtf on older distros Glenn Enright
2017-09-28 8:45 ` Wei Liu
2017-09-28 8:51 ` Andrew Cooper
2017-09-28 8:53 ` Wei Liu
2017-09-28 10:59 ` [PATCH XTF 1/4] build: Support BUILD_BUG_ON() with compilers lacking _Static_assert() Andrew Cooper
2017-09-28 10:59 ` Andrew Cooper [this message]
2017-09-28 12:33 ` [PATCH XTF 2/4] build: Drop unnecessary register clobbers Jan Beulich
2017-09-28 10:59 ` [PATCH XTF 3/4] build: Opencode vmfunc as bytes Andrew Cooper
2017-09-28 12:34 ` Jan Beulich
2017-09-28 10:59 ` [PATCH XTF 4/4] build: Avoid using initialisers for anonymous unions Andrew Cooper
2017-09-28 12:37 ` Jan Beulich
2017-09-28 16:56 ` Andrew Cooper
2017-09-28 17:10 ` [PATCH XTF v2 " Andrew Cooper
2017-10-01 21:04 ` Glenn Enright
2017-09-28 12:32 ` [PATCH XTF 1/4] build: Support BUILD_BUG_ON() with compilers lacking _Static_assert() Jan Beulich
2017-09-28 12:34 ` Andrew Cooper
2017-09-28 12:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506596372-24393-2-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=glenn@rimuhosting.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).