xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen Devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Glenn Enright <glenn@rimuhosting.com>
Subject: [PATCH XTF v2 4/4] build: Avoid using initialisers for anonymous unions
Date: Thu, 28 Sep 2017 18:10:43 +0100	[thread overview]
Message-ID: <1506618643-17163-1-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <7a09af63-2600-8093-525c-e379b83889b9@citrix.com>

GCC 4.4 of CentOS 6 vintage can't cope.

Reported-by: Glenn Enright <glenn@rimuhosting.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
v2: Reduce to just the anonymous parts of the union
---
 tests/livepatch-priv-check/main.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/livepatch-priv-check/main.c b/tests/livepatch-priv-check/main.c
index e51ba64..8a96ad0 100644
--- a/tests/livepatch-priv-check/main.c
+++ b/tests/livepatch-priv-check/main.c
@@ -46,11 +46,11 @@ static void test_upload(void)
             .cmd = XEN_SYSCTL_LIVEPATCH_UPLOAD,
             .u.upload = {
                 .name = {
-                    .name.p = TEST_NAME,
+                    .name = {{ TEST_NAME }},
                     .size = sizeof(TEST_NAME),
                 },
                 .size = PAGE_SIZE,
-                .payload.p = payload,
+                .payload = {{ payload }},
             },
         },
     };
@@ -74,8 +74,8 @@ static void test_list(void)
             .u.list = {
                 .idx = 0,
                 .nr = NR_PAYLOADS,
-                .name.p = names,
-                .len.p = lengths,
+                .name = {{ names }},
+                .len = {{ lengths }},
             },
         },
     };
@@ -93,7 +93,7 @@ static void test_get(void)
             .cmd = XEN_SYSCTL_LIVEPATCH_GET,
             .u.get = {
                 .name = {
-                    .name.p = TEST_NAME,
+                    .name = {{ TEST_NAME }},
                     .size = sizeof(TEST_NAME),
                 },
             },
@@ -113,7 +113,7 @@ static void test_action(uint32_t action)
             .cmd = XEN_SYSCTL_LIVEPATCH_ACTION,
             .u.action = {
                 .name = {
-                    .name.p = TEST_NAME,
+                    .name = {{ TEST_NAME }},
                     .size = sizeof(TEST_NAME),
                 },
                 .cmd = action,
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-09-28 17:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28  1:43 Building xtf on older distros Glenn Enright
2017-09-28  8:45 ` Wei Liu
2017-09-28  8:51   ` Andrew Cooper
2017-09-28  8:53     ` Wei Liu
2017-09-28 10:59 ` [PATCH XTF 1/4] build: Support BUILD_BUG_ON() with compilers lacking _Static_assert() Andrew Cooper
2017-09-28 10:59   ` [PATCH XTF 2/4] build: Drop unnecessary register clobbers Andrew Cooper
2017-09-28 12:33     ` Jan Beulich
2017-09-28 10:59   ` [PATCH XTF 3/4] build: Opencode vmfunc as bytes Andrew Cooper
2017-09-28 12:34     ` Jan Beulich
2017-09-28 10:59   ` [PATCH XTF 4/4] build: Avoid using initialisers for anonymous unions Andrew Cooper
2017-09-28 12:37     ` Jan Beulich
2017-09-28 16:56       ` Andrew Cooper
2017-09-28 17:10         ` Andrew Cooper [this message]
2017-10-01 21:04           ` [PATCH XTF v2 " Glenn Enright
2017-09-28 12:32   ` [PATCH XTF 1/4] build: Support BUILD_BUG_ON() with compilers lacking _Static_assert() Jan Beulich
2017-09-28 12:34     ` Andrew Cooper
2017-09-28 12:50       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506618643-17163-1-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=glenn@rimuhosting.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).