From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 2/3] xen: RCU: make the period of the idle timer configurable. Date: Thu, 28 Sep 2017 19:16:43 +0200 Message-ID: <1506619003.5001.18.camel@citrix.com> References: <150659250903.4057.6425247157210641083.stgit@Solace.fritz.box> <150659376652.4057.12723423135216244659.stgit@Solace.fritz.box> <59CD100D0200007800180825@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1885717638545318103==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxcQg-0004DM-GT for xen-devel@lists.xenproject.org; Thu, 28 Sep 2017 17:16:54 +0000 In-Reply-To: <59CD100D0200007800180825@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Stefano Stabellini , Andrew Cooper , Tim Deegan , George Dunlap , Julien Grall , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============1885717638545318103== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-xNO74arwembjfCrv/iyC" --=-xNO74arwembjfCrv/iyC Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-09-28 at 07:06 -0600, Jan Beulich wrote: > > > > On 28.09.17 at 12:16, wrote: > >=20 > And then, as a cosmetic thing, idle_timer_period_ms now isn't > really needed outside of this function. I'd prefer if you moved it > and the integer_param() into this function, to limit their scopes > as much as possible. >=20 On an unrelated (to this series) note, does this means that patches like the one below are welcome/accepted? Not that I plan to start sending them (not right now, at least). I was rather thinking that it could be a nice bite project for beginners and GSoC/Outreacy applicants. Dario --- diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c index 8e6c96d..a6cb263 100644 --- a/xen/arch/x86/acpi/boot.c +++ b/xen/arch/x86/acpi/boot.c @@ -50,10 +50,6 @@ bool __initdata acpi_ht =3D true; /* enable HT */ bool __initdata acpi_lapic; bool __initdata acpi_ioapic; =20 -/* acpi_skip_timer_override: Skip IRQ0 overrides. */ -static bool __initdata acpi_skip_timer_override; -boolean_param("acpi_skip_timer_override", acpi_skip_timer_override); - static u64 acpi_lapic_addr __initdata =3D APIC_DEFAULT_PHYS_BASE; =20 /* -----------------------------------------------------------------------= --- @@ -225,6 +221,9 @@ static int __init acpi_parse_int_src_ovr(struct acpi_subtable_header * header, const unsigned long end) { + /* acpi_skip_timer_override: Skip IRQ0 overrides. */ + static bool __initdata acpi_skip_timer_override; + boolean_param("acpi_skip_timer_override", acpi_skip_timer_override)= ; struct acpi_madt_interrupt_override *intsrc =3D container_of(header, struct acpi_madt_interrupt_override, header); --- --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-xNO74arwembjfCrv/iyC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZzS58AAoJEBZCeImluHPuK3wQAMYhnQQ/bvdBkxhp6TbDPF+w u1yj66qSlWy8TEK3aOEcoxMHZVEy8tjvdhhqslFPpm7gr8agHfseI1K+89ppHMHM asiPOYCfyGYoGikuuaG0SNwDdIR2p7TXDCvzGmLv53ZFzhMuyJxLJbaPzv0pHAU1 7BFyJYgr2ZWeaMeLgtQNjCiBqL8TcekYtOlGUkOXzYeBWQUIerzQVdTKMOQ06AQY 3favAsfq/1oKK3Eg7rXgPW53XGWilkdExsaM2AD9xDeyrkbBTqXWalcvKjUTwUQi 1u7IvtyM5fD7PMHq9pKCBoLiB+LKRUdQnp09azbwVtm3t2wokYnZmx7M7U/RRgI0 CdDvFUeOr0qZR5wxDaCBwKMZhzgVPm6O45pR+pSwfrRCAF49qNDxoP1C47JIeZmV cgz1dTVjzptCrL5M0NB0pyhkiCvBKIMuumrq2S/WReXY4PyABm2H7Q/wTeSoHpQ0 LNuJf1HZ2VMGRH6eZk3HJnMPoM/AZPkCKxWFd/nkJALkeosO2mlXxyHXjk3wxBIh UCLzGqbd8IICMSDFn5H7TwaC2sB8u/y0brhANbwYvOFOPpha28SdQimXztjFnlL7 HSrvQxKVDIMSTCaJjlycShWKWisnnJG9vPLOOLwuR1VyGpK/e3yzKxRhIVknILC1 EJyaylJfw+XfgwDJWkdo =MGPJ -----END PGP SIGNATURE----- --=-xNO74arwembjfCrv/iyC-- --===============1885717638545318103== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1885717638545318103==--