From: Dario Faggioli <raistlin@linux.it>
To: Meng Xu <mengxu@cis.upenn.edu>, xen-devel@lists.xenproject.org
Cc: george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
xumengpanda@gmail.com, wei.liu2@citrix.com
Subject: Re: [PATCH v3 4/5] xentrace: enable per-VCPU extratime flag for RTDS
Date: Wed, 11 Oct 2017 12:57:57 +0200 [thread overview]
Message-ID: <1507719477.19120.19.camel@linux.it> (raw)
In-Reply-To: <1507677465-3840-5-git-send-email-mengxu@cis.upenn.edu>
[-- Attachment #1.1: Type: text/plain, Size: 2707 bytes --]
On Tue, 2017-10-10 at 19:17 -0400, Meng Xu wrote:
> --- a/tools/xentrace/formats
> +++ b/tools/xentrace/formats
> @@ -75,7 +75,7 @@
> 0x00022801 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:tickle [
> cpu = %(1)d ]
> 0x00022802 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:runq_pick [
> dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget =
> 0x%(5)08x%(4)08x ]
> 0x00022803 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:burn_budget [
> dom:vcpu = 0x%(1)08x, cur_budget = 0x%(3)08x%(2)08x, delta = %(4)d ]
> -0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [
> dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget =
> 0x%(5)08x%(4)08x ]
> +0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [
> dom:vcpu = 0x%(1)08x, priority_level = 0x%(2)08d cur_deadline =
> 0x%(4)08x%(3)08x, cur_budget = 0x%(6)08x%(5)08x ]
> 0x00022805 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:sched_tasklet
> 0x00022806 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:schedule [
> cpu[16]:tasklet[8]:idle[4]:tickled[4] = %(1)08x ]
>
But, both in case of this file and below in xenalyze.c, you update 1
record (the one of REPL_BUDGET). However, in patch 1, you added the
priority_level field to two records: REPL_BUDGET and BURN_BUDGET.
Or am I missing something?
Regards,
Dario
> diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
> index 79bdba7..2783204 100644
> --- a/tools/xentrace/xenalyze.c
> +++ b/tools/xentrace/xenalyze.c
> @@ -7946,12 +7946,14 @@ void sched_process(struct pcpu_info *p)
> if(opt.dump_all) {
> struct {
> unsigned int vcpuid:16, domid:16;
> + unsigned int priority_level;
> uint64_t cur_dl, cur_bg;
> } __attribute__((packed)) *r = (typeof(r))ri->d;
>
> - printf(" %s rtds:repl_budget d%uv%u, deadline =
> %"PRIu64", "
> - "budget = %"PRIu64"\n", ri->dump_header,
> - r->domid, r->vcpuid, r->cur_dl, r->cur_bg);
> + printf(" %s rtds:repl_budget d%uv%u, priority_level
> = %u,"
> + "deadline = %"PRIu64", budget = %"PRIu64"\n",
> + ri->dump_header, r->domid, r->vcpuid,
> + r->priority_level, r->cur_dl, r->cur_bg);
> }
> break;
> case TRC_SCHED_CLASS_EVT(RTDS, 5): /* SCHED_TASKLET */
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-11 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 23:17 [PATCH v3 0/5] Towards work-conserving RTDS Meng Xu
2017-10-10 23:17 ` [PATCH v3 1/5] xen:rtds: towards work conserving RTDS Meng Xu
2017-10-11 10:49 ` Dario Faggioli
2017-10-10 23:17 ` [PATCH v3 2/5] libxl: enable per-VCPU extratime flag for RTDS Meng Xu
2017-10-11 10:20 ` Wei Liu
2017-10-11 10:48 ` Dario Faggioli
2017-10-10 23:17 ` [PATCH v3 3/5] xl: " Meng Xu
2017-10-11 10:20 ` Wei Liu
2017-10-11 10:45 ` Dario Faggioli
2017-10-10 23:17 ` [PATCH v3 4/5] xentrace: " Meng Xu
2017-10-11 10:57 ` Dario Faggioli [this message]
2017-10-11 17:13 ` Meng Xu
2017-10-10 23:17 ` [PATCH v3 5/5] docs: " Meng Xu
2017-10-11 10:20 ` Wei Liu
2017-10-11 10:45 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507719477.19120.19.camel@linux.it \
--to=raistlin@linux.it \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mengxu@cis.upenn.edu \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).