From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 4/5] xentrace: enable per-VCPU extratime flag for RTDS Date: Wed, 11 Oct 2017 12:57:57 +0200 Message-ID: <1507719477.19120.19.camel@linux.it> References: <1507677465-3840-1-git-send-email-mengxu@cis.upenn.edu> <1507677465-3840-5-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5577359575299806727==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2EiA-0002kx-Iv for xen-devel@lists.xenproject.org; Wed, 11 Oct 2017 10:58:02 +0000 Received: by mail-wr0-f194.google.com with SMTP id k15so893719wrc.4 for ; Wed, 11 Oct 2017 03:58:00 -0700 (PDT) In-Reply-To: <1507677465-3840-5-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu , xen-devel@lists.xenproject.org Cc: george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, xumengpanda@gmail.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org --===============5577359575299806727== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-IBJUtLKRoQF8FloUiF4y" --=-IBJUtLKRoQF8FloUiF4y Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-10-10 at 19:17 -0400, Meng Xu wrote: > --- a/tools/xentrace/formats > +++ b/tools/xentrace/formats > @@ -75,7 +75,7 @@ > 0x00022801 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:tickle [ > cpu =3D %(1)d ] > 0x00022802 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:runq_pick [ > dom:vcpu =3D 0x%(1)08x, cur_deadline =3D 0x%(3)08x%(2)08x, cur_budget =3D > 0x%(5)08x%(4)08x ] > 0x00022803 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:burn_budget [ > dom:vcpu =3D 0x%(1)08x, cur_budget =3D 0x%(3)08x%(2)08x, delta =3D %(4)d = ] > -0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [ > dom:vcpu =3D 0x%(1)08x, cur_deadline =3D 0x%(3)08x%(2)08x, cur_budget =3D > 0x%(5)08x%(4)08x ] > +0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [ > dom:vcpu =3D 0x%(1)08x, priority_level =3D 0x%(2)08d cur_deadline =3D > 0x%(4)08x%(3)08x, cur_budget =3D 0x%(6)08x%(5)08x ] > 0x00022805 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:sched_tasklet > 0x00022806 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:schedule [ > cpu[16]:tasklet[8]:idle[4]:tickled[4] =3D %(1)08x ] > =20 But, both in case of this file and below in xenalyze.c, you update 1 record (the one of REPL_BUDGET). However, in patch 1, you added the priority_level field to two records: REPL_BUDGET and BURN_BUDGET. Or am I missing something? Regards, Dario > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c > index 79bdba7..2783204 100644 > --- a/tools/xentrace/xenalyze.c > +++ b/tools/xentrace/xenalyze.c > @@ -7946,12 +7946,14 @@ void sched_process(struct pcpu_info *p) > if(opt.dump_all) { > struct { > unsigned int vcpuid:16, domid:16; > + unsigned int priority_level; > uint64_t cur_dl, cur_bg; > } __attribute__((packed)) *r =3D (typeof(r))ri->d; > =20 > - printf(" %s rtds:repl_budget d%uv%u, deadline =3D > %"PRIu64", " > - "budget =3D %"PRIu64"\n", ri->dump_header, > - r->domid, r->vcpuid, r->cur_dl, r->cur_bg); > + printf(" %s rtds:repl_budget d%uv%u, priority_level > =3D %u," > + "deadline =3D %"PRIu64", budget =3D %"PRIu64"\n", > + ri->dump_header, r->domid, r->vcpuid, > + r->priority_level, r->cur_dl, r->cur_bg); > } > break; > case TRC_SCHED_CLASS_EVT(RTDS, 5): /* SCHED_TASKLET */ --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli --=-IBJUtLKRoQF8FloUiF4y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAlnd+TUACgkQFkJ4iaW4 c+6RDRAAwNN8A9KP5V3GTW2rA6FF/odemlHvHLSA+0OTcIl9f+Lnh8+DE/JcKfus YmTLD/ZUKgWd0/evQWf2CNdAJCJ2yL7yk64Bp/vwzlAunbOnr54JJhzvC5BupDzz f3xz+x/pW7ZIH+EmPZ2xqwZvQkcgX2D2url2io24SJJfNq7UeNz4KiXXLyu+QE1y uZ2d0zipEheEo1oF4ZlfHXVnTjBjFl0PxYV+AJVUOgg6wq7W/Dbnt4r/ejSk8zsw sQEH++97mFurb9Yh/HaE/DhGyGDrpyNbjsXfhtkzM3KfEnEOOUlIp6QO4J2F3MuI enjXz8QlIE1BF0btaaVa2EF/xS8GpdbinXSQq2QGna06S61CMStG/TJidLIuldZH r/9ORonnp07ARjzxowNC3VKycBOq6x/k0BReks+EHdQ5SnOxT57T8P7QKIqT7Kzg +vyjv9FFoppqgS02EHAwcLT1Y1eDIxnienKzPh6xdRIwVoOslldZsz18DYJ3DGTV lIr0hHHtPD6IIHoGJMWwzvoVOvbOFw53LL1QXJz2Fpk9qglFHKS3NCY3RN/H/TPw A4E3xO48dWzbHW/IUX6fJ0Eiym48f2VeEh2iFF2seYaHUxeuSvULHHDhMMTfr/Q7 ky9KIzObAej4vX1XgiVF0t1K2H7hsY/x+cY6ItJw5i0FUPzDYC0= =5HND -----END PGP SIGNATURE----- --=-IBJUtLKRoQF8FloUiF4y-- --===============5577359575299806727== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5577359575299806727==--